Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1292075lql; Tue, 12 Mar 2024 12:38:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXTHnTRph5Ocj5gPCBhretn6PeHy3+2UMVIZx2WBKvH+cCHNAROcawxdo4AJoTJ4fYHfO25rWMhXG0wfVYqtdinj63LrmbLoaJNwSoA4w== X-Google-Smtp-Source: AGHT+IHdx4HcXDADHcDXbZZ3/ZCrL0UH3iV15zQ0+vBIlDsaUYEGdfHeA65iynM7Vf8wjRr/BIFK X-Received: by 2002:a17:907:d041:b0:a46:1cd4:cb49 with SMTP id vb1-20020a170907d04100b00a461cd4cb49mr6372062ejc.48.1710272316925; Tue, 12 Mar 2024 12:38:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710272316; cv=pass; d=google.com; s=arc-20160816; b=XbHNcagskXDkXcoIcoKJCvdUkkOfBiOThs4NW48qBC/GTxAPZT3pxovam2LV0Itdcf 6zob3PElRP2IJ2uTLYlvI5sOHg9KLXW4Sn+xHNEGfGqIn7mMOwUQBtPAYG8EhVQeqIjB PFtqyh3e9cFdYtUIDdcz5XnKBfgFRKCONJld6nkEDoxIHbbThhv+1cFlhVpdQQNzaXga eQ6aEZ2u4F9Me8msKQpfZLyjSI2oe/j3NpLfaEy9FPhtzdJnaU/5wLuFFHbYE3GLA00G jhxzG10yARZtrkT9kC30EnzAT+i2kW1Y4z3MPVLufknRoliXpTyOkjQUMTheMssB8gaA XaKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=psDXtzAtaeLWZ6h84OMUa5HGJJQUkVe5Pctqz1uMo58=; fh=b2beVgGYeKzmaaHe+PczOGA9BZaryo8yqfiv2A10AwU=; b=ebge39Wsu1MZL9S0tE3ZAzveH0k7RT7tmmrk2EbGH6j3tkzz9iLGmfjnAOAPJlUn54 2RlgbfGbIqfEjAZ6Ij3cgpYVOu2Ie9MYeBXcwOhSwxVL98gbuMVRTVXl5BTAbXVjpw+S qwmC9Ht21SDo2Lp5luFqqz8Y9EMxIXRXUBpR7YRJP3fQdaCjZVHDvbW9HU7APovIl2YO YRtafnXQxXp4v7FpIq0JkryFMy8ANLAIxboB3ciHNQEhq36kE4G4JSXUXTliH6vM00LT AC1GVIf+LmTv7FugStZZ78XzH3h/hRIjJuMAK+7iFYbae1cfZ3Raj/E9aYvJGDQGHBES JFyQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gXORYVQT; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-100714-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100714-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id n26-20020a170906841a00b00a4652ee103csi56424ejx.488.2024.03.12.12.38.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 12:38:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100714-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gXORYVQT; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-100714-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100714-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7C8671F2346F for ; Tue, 12 Mar 2024 19:38:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67BB5142648; Tue, 12 Mar 2024 19:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gXORYVQT" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52B423A6 for ; Tue, 12 Mar 2024 19:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710272309; cv=none; b=ALYt1efXZ6lsEQuwj1RDdtiGwlPFEpA+65NVpo8Hl2bAgi8FyvB1yERSiDYL7r+Rq/gc+L1TLx/VkH646XwgMmEWU7dZ+d/dEnSO8hS9grqkwrVdXMQx0yrfPhARQT/CfV3bWO3WoY9vdNoZH4JXd+ohH6DPTiFAoEoKyulvIMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710272309; c=relaxed/simple; bh=tZ8a6vbF2Am0MpFqEToA50rmKFe/nHhBL/0jX4rogxg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FB7GkvYDIxHeK9kpyDtFc7/OSy5CXaILfHLIE4RFgoKue8nd9BMJDWIZog8+aCCwQNiSwGH9xEQJI1BvmMxFcL5EvMRkcSDoMm4ipe0IVTtWf+ZhPkHMZC6+cviXga/qdYXmdDHzw+B2vqlxDwI4J27f4AZoKVAA2wcsIUE+Zbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gXORYVQT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710272306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=psDXtzAtaeLWZ6h84OMUa5HGJJQUkVe5Pctqz1uMo58=; b=gXORYVQT+7lQ48Zw3HhZfSpB4ohpX68VRJD+jEyDVW6ZfGFN3ewtw5+YdovVfAvLeSITej yyktCUAEPgLN6aR36yzUHtTIBu80FaIC7oHSaeGNfBOJAXq6nrdxbxQiVWWoY1K3en03EI XLUAGEU9o1+P9xrWCvS01FjrARV4fo0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-vPtgj_-BOeOava5HI44tGQ-1; Tue, 12 Mar 2024 15:38:25 -0400 X-MC-Unique: vPtgj_-BOeOava5HI44tGQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4131b4161dcso21552365e9.2 for ; Tue, 12 Mar 2024 12:38:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710272304; x=1710877104; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=psDXtzAtaeLWZ6h84OMUa5HGJJQUkVe5Pctqz1uMo58=; b=qtGh5fABHeotTOuD7gkPYqfXNe8LS2M93Or0WSD3NpuPt6SnqGVDen67Om1djfguRN uaEyZSivkey7dMZAM3QN4IQM8M6NAI6WEOvnrBEwNmBvnUZGdEOzWoD3JuGA8StQTJEJ EKMM+U6WJZPMwS0lZftCRAA8wymvEA+Vcj0w8e8Ajj4u4Xf9C/EX/wfu5byqGRJOwbk+ EK2pkJGoLaIGgUUDxUQloZNy8FHJOFRRVQkIwK0sHCndWP1UYnSfMZhEd7+tWlkioLED xpBeGidmlJOppSns/X8+PpeNEx5n1o2UpEVCFsRWmtb+KpcfbnLkv6lKdpj37o3jLzPj ltlw== X-Gm-Message-State: AOJu0YxAKz3kv+vRU/JqJK6/m1fFWmg5dKa69tSLpnbx1kaMgKMZU1k3 /EzJnq7/XLiXnKYXlWXwOxgWb62wlU1Q+lZv5N8uLZO5khOxYIq57VhcOyG5/H3GXyafxzQMJ/A sm+Be9sKzksN7v3Tjs6nm+3mmdL/TyNKO5kDtl6evKxO2c1CcsqwFSkR0T3liow== X-Received: by 2002:a05:600c:6a1a:b0:413:1285:6e40 with SMTP id jj26-20020a05600c6a1a00b0041312856e40mr7921406wmb.20.1710272303969; Tue, 12 Mar 2024 12:38:23 -0700 (PDT) X-Received: by 2002:a05:600c:6a1a:b0:413:1285:6e40 with SMTP id jj26-20020a05600c6a1a00b0041312856e40mr7921394wmb.20.1710272303587; Tue, 12 Mar 2024 12:38:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4f00:a44a:5ad6:765a:635? (p200300cbc7074f00a44a5ad6765a0635.dip0.t-ipconnect.de. [2003:cb:c707:4f00:a44a:5ad6:765a:635]) by smtp.gmail.com with ESMTPSA id ea13-20020a05600c674d00b004132ae838absm6845613wmb.43.2024.03.12.12.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 12:38:23 -0700 (PDT) Message-ID: <5bc9de2f-c3ba-46e7-a234-3d3a46e53ba1@redhat.com> Date: Tue, 12 Mar 2024 20:38:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] x86/mm/pat: fix VM_PAT handling in COW mappings Content-Language: en-US To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Wupeng Ma , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton References: <20240312181118.318701-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.03.24 20:22, Matthew Wilcox wrote: > On Tue, Mar 12, 2024 at 07:11:18PM +0100, David Hildenbrand wrote: >> PAT handling won't do the right thing in COW mappings: the first PTE >> (or, in fact, all PTEs) can be replaced during write faults to point at >> anon folios. Reliably recovering the correct PFN and cachemode using >> follow_phys() from PTEs will not work in COW mappings. > > I guess the first question is: Why do we want to support COW mappings > of VM_PAT areas? What breaks if we just disallow it? Well, that was my first approach. Then I decided to be less radical (IOW make my life easier by breaking less user space) and "fix it" with minimal effort. Chances of breaking some weird user space is possible, although I believe for most such mappings MAP_PRIVATE doesn't make too much sense sense. Nasty COW support for VM_PFNMAP mappings dates back forever. So does PAT support. I can try finding digging through some possible user space users tomorrow. -- Cheers, David / dhildenb