Received-SPF: pass (google.com: domain of linux-kernel+bounces-100736-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240223-topic-sm8650-upstream-hdk-v1-0-ccca645cd901@linaro.org>
 <20240223-topic-sm8650-upstream-hdk-v1-2-ccca645cd901@linaro.org>
 <8a1b08df-dc44-6f9f-c819-33491308699e@linaro.org> <65d60ed4-e52c-4f98-84e1-4d753e29adfc@linaro.org>
In-Reply-To: <65d60ed4-e52c-4f98-84e1-4d753e29adfc@linaro.org>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Tue, 12 Mar 2024 21:59:39 +0200
Message-ID: <CAA8EJppT_hnzkzf0txesadt1MNky=d1swx9kD15RS3KQN2VHqw@mail.gmail.com>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8650: add support for the
 SM8650-HDK board
To: neil.armstrong@linaro.org
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>, Bjorn Andersson <andersson@kernel.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Tue, 12 Mar 2024 at 20:45, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> On 03/03/2024 00:26, Vladimir Zapolskiy wrote:
> > Hi Neil,
> >
> > On 2/23/24 10:52, Neil Armstrong wrote:
> >> The SM8650-HDK is an embedded development platforms for the
> >> Snapdragon 8 Gen 3 SoC aka SM8650, with the following features:
> >> - Qualcomm SM8650 SoC
> >> - 16GiB On-board LPDDR5
> >> - On-board WiFi 7 + Bluetooth 5.3/BLE
> >> - On-board UFS4.0
> >> - M.2 Key B+M Gen3x2 PCIe Slot
> >> - HDMI Output
> >> - USB-C Connector with DP Almode & Audio Accessory mode
> >> - Micro-SDCard Slot
> >> - Audio Jack with Playback and Microphone
> >> - 2 On-board Analog microphones
> >> - 2 On-board Speakers
> >> - 96Boards Compatible Low-Speed and High-Speed connectors [1]
> >>    - For Camera, Sensors and external Display cards
> >>      - Compatible with the Linaro Debug board [2]
> >
> > what are these [1] and [2] references? Probably there might be some links.
>
> Indeed
>
> >
> >>      - SIM Slot for Modem
> >>      - Debug connectors
> >>      - 6x On-Board LEDs
> >>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >> ---
> >>   arch/arm64/boot/dts/qcom/Makefile       |    1 +
> >>   arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 1259 +++++++++++++++++++++++++++++++
> >>   2 files changed, 1260 insertions(+)


> >
> >> +&pcie_1_phy_aux_clk {
> >> +    clock-frequency = <1000>;
> >> +};
> >> +
> >
> > May be put the clock above after &pcie1_phy like in the list of gcc
> > source clocks?
>
> Ack

IIUC, this is not the actual frequency of the clock.


-- 
With best wishes
Dmitry