Received-SPF: pass (google.com: domain of linux-kernel+bounces-100739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <fa04abad-9191-4333-bcad-9b37ac23e6aa@amd.com>
Date: Tue, 12 Mar 2024 15:06:04 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v5 2/2] x86/resctrl: Simplify call convention for MSR
 update functions
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>,
 "Chatre, Reinette" <reinette.chatre@intel.com>,
 Borislav Petkov <bp@alien8.de>, James Morse <james.morse@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
 linux-kernel@vger.kernel.org, "Yu, Fenghua" <fenghua.yu@intel.com>,
 Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
 shameerali.kolothum.thodi@huawei.com,
 D Scott Phillips OS <scott@os.amperecomputing.com>,
 carl@os.amperecomputing.com, lcherian@marvell.com,
 bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
 baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
 Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
 dfustini@baylibre.com, amitsinght@marvell.com,
 David Hildenbrand <david@redhat.com>,
 Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
References: <ZdZPht8hY4J9uIOz@agluck-desk3>
 <20240308213846.77075-1-tony.luck@intel.com>
 <20240308213846.77075-3-tony.luck@intel.com>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <20240308213846.77075-3-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bWxKNXBEWHhVeTZVa0dzVlFvQUhXY091YmFmUSt5cWdKVHRIbEdIcml0UWlU?=
 =?utf-8?B?SzFJbzJaUitoZlA0aVA0bThiNmVpQ2tXN3FhODJMeDRrNUJUc0VoWDlrWjlx?=
 =?utf-8?B?aVJod25FM0ZDTS96aFBEeXllemJKcXU2MnV1SmNtbGE5Mkd4dlVObEtXNE1H?=
 =?utf-8?B?OUhlUEI3STBxeVNYSUFHaGxwaDNlbEpDdFVZRGlCTCtxamRWNzgvWlVTUGFq?=
 =?utf-8?B?Um1FYzdmdGp3VGM0WUhnSEJGT0xhNENPSDlpVFh2dkVkdmsrdm5FaVFpYUdL?=
 =?utf-8?B?aWkxM2MzSG8wTWZKRThxK1lnUGFyV3FtSzQwRDZhOUpwUWVvbmlwWFFaOUti?=
 =?utf-8?B?NmliOU5yN2RJQWt3OHlFL0dWZVpMeGhqOE0zREFEbTlpMkRUQjBnN3BVbWxD?=
 =?utf-8?B?b1l4UjBKZmhwTUVDeHl5ODNqQ1R2cFFSTXNOUkdkajc4MWp2Zi9KbG9mdmF5?=
 =?utf-8?B?MGFZZjNSdWJoQ2hjdnNGbHlsd21RMXFWVHRqRUVRZ3N2TWluYWZ5d2tzeDJm?=
 =?utf-8?B?NURhUi9zQW5qZWRlRWFoa1Z6K3BxMndWUkIvOHhFcXUrMkRpNUJiTkhGR24y?=
 =?utf-8?B?S2UrQm4zcU90ZEk0WG9ScjZOMGx6SERzNzlTNmVvWG5WV3NqZEZkU21yZzVQ?=
 =?utf-8?B?UUhuVnpqUzRSYVhaaUZMaWNNc1lKRFkxWFF2bk5BcVdzaWZ5UUpabXc4VDUv?=
 =?utf-8?B?bklGWVEvL0FOL1ZFaFcxN0dJbFAzWmZnVXM4UmtuQ054NElORGI2TjBaMUZH?=
 =?utf-8?B?bmR5cFFCYzE2aGZnRUk1dWpwR1dOOCtDd01WL1g1OGt3QjgvdXFZWURIYitN?=
 =?utf-8?B?cXNFMlp4dStlenN0MjdIY2VoNWJ0SmNVaVpCVlpHR1JEOWRaSUNPQ0F5STJK?=
 =?utf-8?B?Y1poZXUwL1MyZ2NFNDk0eWU0NHJVTWJaYmZveThLenNVWElqbm1sWmhnQW1t?=
 =?utf-8?B?VEU2VzByMjMxVzFSaHRyRk9kTnJTK2xKT01VMHUwVXhQcXE4OVNEYnc5T1kz?=
 =?utf-8?B?aVVnVTBiY2ZrNVFaaU1naUJickpic1d1NFFITldJMmZybW5jemxHVnpWdkVo?=
 =?utf-8?B?TkxUUzNZYndsM2RSUHNDYjg1bFFYUVJqZGxGZmowZ3NVUXVOKzZadzc0eWdW?=
 =?utf-8?B?TVhqbjJ2R1dvalZuRnBXUTBnZXNQbjQ2clBRYXE4cEhmTktWaS9zajk2ZmRw?=
 =?utf-8?B?OXBZbHFTQU5sMmFKT3Q2QVZPRWJsOWtzWVNlWHhWQXQxK09nbWorZzJrNlNh?=
 =?utf-8?B?R0RtK29UVU5XdzRqOUNtRGJDbFRPQlZmSzl2YXhXRzJPbHoyai9iWU5pUE9r?=
 =?utf-8?B?TFlzeHBtUnRyUHl4dlBrKzI0UTVyY05XL0UxVEJxZVlhT01NeFZkNnZkZm1l?=
 =?utf-8?B?a3RRUVg2UGQ4LzBpRHQ1b0swMUk2ZTBlM0hWdzdRMnRJL3JJVzlCc25lUkl1?=
 =?utf-8?B?S1dJVGdZRE1yWmFYVnA3V2NNbit4UnBJOGQxT1hlRDZpTysrdFJOS3BTVk40?=
 =?utf-8?B?VHZseEN4TklOamtYZ2dRQ0hUQ3E3Rk9zZktPNVQ4N2NOVHNaQXZtRUhxa0kr?=
 =?utf-8?B?QW5VUXJaZ2tnK2VrTFRNcjR5bEt4SXhua3lGbGxuQ0lSVkhXRHA4R0pYSVZn?=
 =?utf-8?B?d2JoSThHVDNjYzFjdkRWU1hmcVlVeUI1S2ZobXBqNTFwSHMxMTdJTU1mY2dF?=
 =?utf-8?B?TnRjSUEzTHZuSnpIY3NOZFM4VUtObEdwYzMwZUJuRVlzQy9iOFdSbG9jdUFo?=
 =?utf-8?B?a3RtNi9YWnlsenJOSUt3Z0djMXBKTHU4ZWdjRDZzTTN0YUtlVnJ6MDJGaU5h?=
 =?utf-8?B?TmhCQi9GWFE4L2dsTnVWZkJNZ3l1K2hJWVByeWtWZC9zVlZxOW9pV3RSOWVM?=
 =?utf-8?B?OEhSczhhZzJ0S3JxdVQ0UnNvRUROcXBWeXJjMXZIdEQ0SCs3dVBhYXhwMExX?=
 =?utf-8?B?ZFo1VVBSdEpma1RzbnlZdkFOOFphVEs4ZmhJMndpUzFoWUpaQ0Jrd25nTXBR?=
 =?utf-8?B?YnB4Mm9WelRQUjBIbmN0c1grcCtZWEp0cEd1bUtXblJDSFNlWFBId2ZsWmhj?=
 =?utf-8?B?M2t4V3FtQm5SQXdSNVlhWjJpaFJjdHptajNjcU9rNVhGSmxlK3dud3gxSFFR?=
 =?utf-8?Q?mSxQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04fee30e-8c80-41c3-2286-08dc42cfdb22
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 20:06:08.3147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fIZzSEQQFTV9wt+BLMY37iHQOLLlRyXDpdofbYxBOQFjsgGZeRu3sBblAtAczfkz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7410


On 3/8/24 15:38, Tony Luck wrote:
> The per-resource MSR update functions cat_wrmsr(), mba_wrmsr_intel(),
> and mba_wrmsr_amd() all take three arguments:
> 
>   (struct rdt_domain *d, struct msr_param *m, struct rdt_resource *r)
> 
> struct msr_param contains pointers to both struct rdt_resource and struct
> rdt_domain, thus only struct msr_param is necessary.
> 
> Pass struct msr_param as a single parameter. Clean up formatting and
> fix some fir tree declaration ordering.
> 
> No functional change.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Tested-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reviewed-by: Babu Moger <babu.moger@amd.com>