Received-SPF: pass (google.com: domain of linux-kernel+bounces-100742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 12 Mar 2024 13:07:11 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>, Dan Williams
	<dan.j.williams@intel.com>, Dave Jiang <dave.jiang@intel.com>, Andrew Morton
	<akpm@linux-foundation.org>, Oscar Salvador <osalvador@suse.de>
CC: <linux-kernel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
	<linux-cxl@vger.kernel.org>, David Hildenbrand <david@redhat.com>, "Dave
 Hansen" <dave.hansen@linux.intel.com>, Huang Ying <ying.huang@intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Matthew Wilcox
	<willy@infradead.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v7 1/5] dax/bus.c: replace driver-core lock usage by a
 local rwsem
Message-ID: <65f0b5ef41817_aa222941a@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240124-vv-dax_abi-v7-0-20d16cb8d23d@intel.com>
 <20240124-vv-dax_abi-v7-1-20d16cb8d23d@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240124-vv-dax_abi-v7-1-20d16cb8d23d@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DzWfIir/dJgX7dJNUdas0VRxdP0QqF6OOxgX1syTZd15PgZ166MBI3BiSfHA?=
 =?us-ascii?Q?ytV/uvoV+PDH80Tp72kOtUeZk2CnAaZacF/4WIABNNlceEqmltQOflCJjSON?=
 =?us-ascii?Q?JQjJrv72hRPdfRP50xewz30yocRdV9rl110VIOZxRlZ781P+qEwhGu6/3qkh?=
 =?us-ascii?Q?N3HKDqDxtNmoXmPgqKAAyBGSQs9J7PGz/wlQy1tvj20I0EaqnrYtTcomjgp3?=
 =?us-ascii?Q?4KvScQS7rD0N+EpWrY1wmGXJXsVs2hqa1Ha141QP4AkKjSC5vYpoQ3+vmrna?=
 =?us-ascii?Q?fpyEnof+IP/Jqz/jp1wHw2Gkv5S43hDDt5XfmJmEhuXPXC6Rsxdz/Sv5vdGw?=
 =?us-ascii?Q?FBXtjhK3qrcPlyhvaOljO1h1Eo91RnNIFPgx4FQM5oCmTowjWHCaab2hVuWw?=
 =?us-ascii?Q?rHdZ45wodqaKRJF7AKghIiRheGrOlgZ3QNBv0AsEotGauGy8Hj5s/mPfg1qo?=
 =?us-ascii?Q?fnsOGvuhzh+RP9Tndx4nykBdmfOAAG6Ci70YHxk7KLqbSXGFOFP0V/AC4Hja?=
 =?us-ascii?Q?VQYtJe8/6B+lf54zRX7/0KGy+Dg/f4rH3SPefgDvKp6Ky3HOD51/tRUWW55P?=
 =?us-ascii?Q?kFgnAHZ31vnLR4Q9JkRJ2t35Psv+tdsOLOg6YbFL5OAZSr4amqzKh2cdHWz1?=
 =?us-ascii?Q?lIaZWXOh1demqwKs5dHzuHBqEjLWOZPi+wDgYtTDZikcvI8ajFDIfzAvMo3y?=
 =?us-ascii?Q?xh9+ivliGiccINPEVVFZ1ni4A0AIcNiffJQzRe6DgqtFgCbnIPbBokuIEOED?=
 =?us-ascii?Q?GRZrSW+Dp+BWebQX0U8dOBXB3MOJdqRp0G8upIkCACcDPTeb2aS3Ah9qUW5Q?=
 =?us-ascii?Q?W6hsQZ9l96KsHZC4ZlvDX6496H0fhb1dyga4kofHdaOqO+96jj62HVakoKwI?=
 =?us-ascii?Q?scoCxsMAxQsS4MpdmI7bjbPMoYNMer7JbIkkB/3+NFxnsvnZI4AbIToPyFRf?=
 =?us-ascii?Q?KqTQeqY9gikU7lBAZ3arF88BCxSiqSc5uIHEXQTsVGONY1spTH6hgrNHrx9N?=
 =?us-ascii?Q?1p7JJuKJsoorKcNJpgoSKGrucvYun58sLo0QAa4fwpRlqDMte87wkcKJbnFv?=
 =?us-ascii?Q?Nsh90LdsxFH3++K+8GjgcPNcV8GNaAhkZQObX1wsxGjE2LxJrh4j25/MqS4Z?=
 =?us-ascii?Q?3xmweU0FRUvD9YDk+/xEOU34TYasi06zQ49wEae2hg30YxkzrS0xaRzwdbfg?=
 =?us-ascii?Q?PIv03L8/jmU/Jjzf1PSaKE7btk0B6xqgIt5JbNn9TZDjDiailF4AUI+0mAZh?=
 =?us-ascii?Q?EfCTO05lPG8ChZ7vRzuG2coUSQxcrN3ncRp7pxqVqvYmdT4gJPeFsIcVbwZf?=
 =?us-ascii?Q?CdNqhHSGfRenGTDKLdWy6ACE+cdMalTQ13lG0CNbOsI2fFS4wiDGOEMdACcj?=
 =?us-ascii?Q?IWSasp/l/JWpxiUiVqR8ebVyd5EmkY9Uwic6HlRYcwrFS5dALe4qBIdh8Vhl?=
 =?us-ascii?Q?RbGN1hxLEfGrKQzdSs/f4BfKjZCZMr6gpHFDyS3UNbFNRIc2rAML93PnE2PL?=
 =?us-ascii?Q?NsY1YB+gMGuqBWCRLseeRA1/24qpLSXZVzHLko7wWngI1oV7iycH6NaiX0sK?=
 =?us-ascii?Q?xIafILORRJzjyQ+fbVbXgfL9yYhV7RWO74Kzwgi7LinjInJEyKTZGBaau5xr?=
 =?us-ascii?Q?pw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: faf131ee-86b4-4b8c-2c10-08dc42d0023b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 20:07:14.0703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N05pPaEks3awzD0sKgt5H6WCKZKU0bpx9dpuK2OJN6rinhSU07Qh6Bgf9qkRDAmKp4eyDxax2n2SvaNxfp5Vhm/9jxCY8JNyHnUafJ34YB8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8073
X-OriginatorOrg: intel.com

Vishal Verma wrote:
> The dax driver incorrectly used driver-core device locks to protect
> internal dax region and dax device configuration structures. Replace the
> device lock usage with a local rwsem, one each for dax region
> configuration and dax device configuration. As a result of this
> conversion, no device_lock() usage remains in dax/bus.c.
> 
> Cc: Dan Williams <dan.j.williams@intel.com>
> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  drivers/dax/bus.c | 220 ++++++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 157 insertions(+), 63 deletions(-)
> 
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 1ff1ab5fa105..cb148f74ceda 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -12,6 +12,18 @@
>  
>  static DEFINE_MUTEX(dax_bus_lock);
>  
> +/*
> + * All changes to the dax region configuration occur with this lock held
> + * for write.
> + */
> +DECLARE_RWSEM(dax_region_rwsem);
> +
> +/*
> + * All changes to the dax device configuration occur with this lock held
> + * for write.
> + */
> +DECLARE_RWSEM(dax_dev_rwsem);
> +
>  #define DAX_NAME_LEN 30
>  struct dax_id {
>  	struct list_head list;
> @@ -180,7 +192,7 @@ static u64 dev_dax_size(struct dev_dax *dev_dax)
>  	u64 size = 0;
>  	int i;
>  
> -	device_lock_assert(&dev_dax->dev);
> +	WARN_ON_ONCE(!rwsem_is_locked(&dax_dev_rwsem));

Apologies for the late review, but...

All of these WARN_ON_ONCE() usages should be replaced with
lockdep_assert_held() and lockdep_assert_held_write() where appropriate.