Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1314095lql; Tue, 12 Mar 2024 13:22:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVBExXP7ckXY0qbEBC653UEKprjt9JKzeqloKwt82jQu6+v4vpX/+EpOvxNEsRBqKQX+8a+FRSYWBll0IuQABiokuVuRYQ3QhwD4XevoQ== X-Google-Smtp-Source: AGHT+IGlCDfRFoMP8v09OfMptpQGYGaPMGaTVZBgsPW73vYCYdL4FLrMcUg9iykvp35zG8qOqDCi X-Received: by 2002:a05:6902:1828:b0:dcf:3ef5:4d30 with SMTP id cf40-20020a056902182800b00dcf3ef54d30mr587928ybb.17.1710274962230; Tue, 12 Mar 2024 13:22:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710274962; cv=pass; d=google.com; s=arc-20160816; b=r8NqpzP2pQPVjo1CuWQtogVWnht6StIJSmLdUj7lTpSiXxOq1/hxr1eAWIn8nb4Yx5 R7kmrKZAvyjOREVL4MCv3KUIWFVuGCtCYXUhPOMM6JDH6vrRHNY2QBE71AaG8bq4qSKI oQCXUMLfW2XONpMLlhWy13Xeo1T9gQMREaoXSU2yRwu5fPRnbq/pDAqqeYJQ/bY7+Zw1 E/yDMF9EtmQppmaHJdMqYJ4UFhgJ+D9jjlQhfBWPn642ZqtJf18yKXn55NkotvY5h8MF HEsTVwMiL6sY8ib1GT4xE/6SBcPNv5b0p1fDvi/qrS7YhAgZjdZgehb0c5pwGWlMm8pQ 5UgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=f950I9DA6InL9WeqO03KJL02LHxnT+fxujYUhBAlvo8=; fh=L1vHkzbDGXihQ/IaEoPFQuy6SML/CiBvBkr8bQ3AXR4=; b=PJr3QAL4dqW2FPtzf9YUA4ybctIRLnU8SxxNj681m+qiaIjOkVFusgWvHea/WVTZEB DncmUj4iMcao1HPGyXihaQEyZNtH++NN4cLdh2wOopyXUtoox+d7+NqjfSd975kzZnMT R3Jv/HBMh2TBGHIVlcdGwp7hGqfE7RgOGUQd4MIYV0S00ez8x2ccKTzdGU1RcUttIP9Y 1oYCz1c5CzTQpNjZJ3eYyRcsZ8O654rFpVb/yMdE3P+BVeZqX8hSyzMLktkmzvEZv7gp c/DMObJ3LOCBgPxousez3UmYqgWhGt/VfOeBV6bKJ9GCSfHVla4tEx2yorvqWrbyf/W+ t20w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=JMWslwId; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-100757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100757-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d18-20020a05622a101200b0042ed7f78f81si8664844qte.418.2024.03.12.13.22.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 13:22:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=JMWslwId; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-100757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100757-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E97C81C2141C for ; Tue, 12 Mar 2024 20:22:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B541714290E; Tue, 12 Mar 2024 20:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="JMWslwId" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C28B81386AA; Tue, 12 Mar 2024 20:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710274954; cv=none; b=Wa3wAx+rb1AZwDe3ZYIkV43fJzLp+qdM+hCzf/L8WC8uyAHR03lnYcKug09wyYuguzrspj/kwkaQW6MHHADI8r97vAuC0CqCVcpmsVCpoNeJFdv2SNZd/THmfK0VTf/kkLhg70/21IUNGz7noLVFwrmuvYxJd37J18XKZ4wtmeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710274954; c=relaxed/simple; bh=Pr5lhOrEPrMJqPAwR3vdY7dlJDIhGLkhSYZOK85QpNs=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=X6NvG3cIV51+0VhsEdT3msPJwV5IYj/BBzz4g126hd3fUaBKdH00OhJPJ7HMLFaH2ti5S4O/lUH6Ekbd7Dh5aIzqwHT2EVDt/TRdbU0IvfDrMA+haiKoA2bqPxtn6nXU0c1vkeKY0PsFdNmPXgTKjReqjzvF6589tjQ6DiRBe8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=JMWslwId; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB5D0C433C7; Tue, 12 Mar 2024 20:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1710274954; bh=Pr5lhOrEPrMJqPAwR3vdY7dlJDIhGLkhSYZOK85QpNs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JMWslwIdP4OWf5ct0J5wlCAlOEXwLAlFAYm+rpdZuRElOApbGIZ0KcNkJ2S3qG6b+ fGQkSlgljL2lZyAwVOiEzbdcv+3noDCbQtArckxN/voeH/K5KOFFGLOeQ5eYCbj4c8 aWDQufFjOWDNbpL/L7XxWZsj5Mii5d0ZR+29Dm4E= Date: Tue, 12 Mar 2024 13:22:33 -0700 From: Andrew Morton To: "Verma, Vishal L" Cc: "Williams, Dan J" , "Jiang, Dave" , "osalvador@suse.de" , "david@redhat.com" , "gregkh@linuxfoundation.org" , "Huang, Ying" , "linux-cxl@vger.kernel.org" , "dave.hansen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "willy@infradead.org" , "nvdimm@lists.linux.dev" Subject: Re: [PATCH v7 1/5] dax/bus.c: replace driver-core lock usage by a local rwsem Message-Id: <20240312132233.4a04a742c7bae02a31eed78f@linux-foundation.org> In-Reply-To: References: <20240124-vv-dax_abi-v7-0-20d16cb8d23d@intel.com> <20240124-vv-dax_abi-v7-1-20d16cb8d23d@intel.com> <65f0b5ef41817_aa222941a@dwillia2-mobl3.amr.corp.intel.com.notmuch> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 12 Mar 2024 20:20:17 +0000 "Verma, Vishal L" wrote: > > All of these WARN_ON_ONCE() usages should be replaced with > > lockdep_assert_held() and lockdep_assert_held_write() where appropriate. > > Makes sense - I can send a patch post -rc1 to change these if that's okay Andrew? Please do.