Received-SPF: pass (google.com: domain of linux-kernel+bounces-100801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Zaid Alali <zaidal@os.amperecomputing.com>
To: zaidal@os.amperecomputing.com,
	lenb@kernel.org,
	james.morse@arm.com,
	tony.luck@intel.com,
	bp@alien8.de,
	robert.moore@intel.com,
	Avadhut.Naik@amd.com,
	xueshuai@linux.alibaba.com
Cc: linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	acpica-devel@lists.linux.dev
Subject: [RFC PATCH 1/5] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities
Date: Tue, 12 Mar 2024 14:26:22 -0700
Message-Id: <20240312212626.29007-2-zaidal@os.amperecomputing.com>
In-Reply-To: <20240312212626.29007-1-zaidal@os.amperecomputing.com>
References: <20240312212626.29007-1-zaidal@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+FIXpn1KDn2NJmm0vQwplmjCqaukPSBmXcOqBCwNM7jKWAW+NUQzblazBouq?=
 =?us-ascii?Q?g4KskdTBPkK9GVYeKbuodTFVFtajIstCSbVpZDJ84gT8+QuHERFF2/jLMIFf?=
 =?us-ascii?Q?JBxl9nbMGN+OcIrg33piqdzhsNi0Kbjf4KDgsn6B0x0UpQclKBrskITHirCH?=
 =?us-ascii?Q?LN6gim2wFpvymiAzbRBAd7S2L3SnZkMkp+CHIpHsf9JuK3D1ps74SPo87yLX?=
 =?us-ascii?Q?QfhbgSDFJCIvKmHvVLXsbh3KBOOFzkOWqGsSoqJqcrqsa/UBBAO19Epm3Dn2?=
 =?us-ascii?Q?CnWLi5jmSIVO62c017EbYxEgZ7dKEAm+QfbgSZa8ioFUFcTcnzhqYd6AthcX?=
 =?us-ascii?Q?6O/O0Me3XOxzw7JQFAkiPmsEzaHtkYRQv3Xx/anCT7b/i4HwDIr9WJW3Jc/t?=
 =?us-ascii?Q?RGu6Rj7RoFaQLkV2QAqzEsuHyYePdUfquk8cZhWcmQRGlU9Tay0SumjgpOOd?=
 =?us-ascii?Q?7N/B4UB1cOKAKhC7r7V4cqx4d8vzl6UA8bamkg7HK38bcc9rjuY7hq5UXOq3?=
 =?us-ascii?Q?O1k3ZzdnhZZ0pr1sNCNqh7D6macfHxb2TJfaz0I4XFZkDIaaqfGOenThPsMD?=
 =?us-ascii?Q?8MptpbUr0Fa/YkMmwdeUVQ9UKYjVBfDTdDbP0lY5i9eJlsqWZL5M86M2ne1a?=
 =?us-ascii?Q?1hefXM5T3u+3EDQ1O0xaUp/u/gswwaiAFj98HwC0pSxvLAP0yl03/cD6Qq2B?=
 =?us-ascii?Q?S/8OwWWRYxZAqMTWMuu68/UJMXnY8Cps8uODMVO15KIjg4mAYuTsY6KKRuYn?=
 =?us-ascii?Q?QoX5PxgnCfgrW3M/8s+5v5FOGiklrcyUrb769Qkh9+DTAvc9sacxaKez1twB?=
 =?us-ascii?Q?E9x6B7XnXP8R15W0ic0XHbd8Bqn169QUa/1Tjs7LpX5Z78qMZYa3hLRp7cAO?=
 =?us-ascii?Q?JRl3QzpmrHgQuGFfMa4IEIe1f4qQ7M3WjFpqb+Fu6+Y10cOAQxQ0HfTUlTiI?=
 =?us-ascii?Q?8+/WwuZbVFbTYitVeYZ96eeHCOnDkxm9jADSyoXsFSE5o03MKbOHY0HKJRA/?=
 =?us-ascii?Q?02EVB2MBsbcKlve8Q81bH2lVW1YcHGUQcaymfDnA1pydvtNRyPoaqXv+ghA5?=
 =?us-ascii?Q?FItwKyer8de7B0jd2tr8J47t0FmJ0sUn0sQePKyvxeT+DeWXRECXUTL+7ZsD?=
 =?us-ascii?Q?awXqZX3jcTvNS7ChqWnE+KllCjHCSjXX+fx+J+smBH9asA2Vnx1h/idkZ4wh?=
 =?us-ascii?Q?/iLi8Ye7q5z0zaXMnqnJLnwHwUB67CnjbVzBbPDXdBZst8+6Mc5NLw4JN6ZB?=
 =?us-ascii?Q?DSoYLgMHxqBJrlL6oqkZMc36lkn0Uq6gmuX2FB1IGuDb5AtEctOW49BMfr76?=
 =?us-ascii?Q?0u2sQhzi+NTq+AP95XaV7Ddqw/SsJ/4kU3OXPYHSpJlfcEGCrfVW02FHND/q?=
 =?us-ascii?Q?a7A3APJfndmOsR0HqdHMZnVExbStB529xI00qI6jK+iafHmuPkAel90IpDja?=
 =?us-ascii?Q?oEi5Fb1r/udCDnPWrOmWs/Jh9mhgUfuDQ99F0GpOq8YBVezL1gcNfekoNYZb?=
 =?us-ascii?Q?bRk2xUnAr342JlTE3Yn/5dysfyt5RFBpUsaxoqn+0j6/cmNhJcqNfi/jMxdr?=
 =?us-ascii?Q?RmaTsoZG94g66GM6Qw5iQDKfluDoUKrbzOX35iGBBpLKWU2LIRbdc7c1HSa0?=
 =?us-ascii?Q?9siA7QOIMp30L8qJNFI8zes=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e1ed599-288f-45df-ba07-08dc42db1a13
X-MS-Exchange-CrossTenant-AuthSource: SN7PR01MB7903.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 21:26:38.3472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: onH7Re8X/I/yjCB0utQ5u4/mIHMYyBc0rr9OImmHwmCRnFr33RNJ1b8bb8f22kgsZXOhISTdC9c//VwxVIQ1U2lAyYAyvOJ+GNUqGDaZbW7dUCIpximBgqyPfowVVZ+6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR01MB8102

EINJv2 capabilities can be discovered by checking the return value
of get_error_type, where bit 30 set indicates EINJv2 support. This
commit enables the driver to show all supported error injections
for EINJ and EINJv2 at the same time.

Signed-off-by: Zaid Alali <zaidal@os.amperecomputing.com>
---
 drivers/acpi/apei/einj.c | 37 ++++++++++++++++++++++++++++++-------
 include/acpi/actbl1.h    |  1 +
 2 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 89fb9331c611..90efbcbf6b54 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -32,6 +32,7 @@
 #define SLEEP_UNIT_MAX		5000			/* 5ms */
 /* Firmware should respond within 1 seconds */
 #define FIRMWARE_TIMEOUT	(1 * USEC_PER_SEC)
+#define ACPI65_EINJV2_SUPP	BIT(30)
 #define ACPI5_VENDOR_BIT	BIT(31)
 #define MEM_ERROR_MASK		(ACPI_EINJ_MEMORY_CORRECTABLE | \
 				ACPI_EINJ_MEMORY_UNCORRECTABLE | \
@@ -145,13 +146,13 @@ static void einj_exec_ctx_init(struct apei_exec_context *ctx)
 			   EINJ_TAB_ENTRY(einj_tab), einj_tab->entries);
 }
 
-static int __einj_get_available_error_type(u32 *type)
+static int __einj_get_available_error_type(u32 *type, int version)
 {
 	struct apei_exec_context ctx;
 	int rc;
 
 	einj_exec_ctx_init(&ctx);
-	rc = apei_exec_run(&ctx, ACPI_EINJ_GET_ERROR_TYPE);
+	rc = apei_exec_run(&ctx, version);
 	if (rc)
 		return rc;
 	*type = apei_exec_ctx_get_output(&ctx);
@@ -160,12 +161,12 @@ static int __einj_get_available_error_type(u32 *type)
 }
 
 /* Get error injection capabilities of the platform */
-static int einj_get_available_error_type(u32 *type)
+static int einj_get_available_error_type(u32 *type, int version)
 {
 	int rc;
 
 	mutex_lock(&einj_mutex);
-	rc = __einj_get_available_error_type(type);
+	rc = __einj_get_available_error_type(type, version);
 	mutex_unlock(&einj_mutex);
 
 	return rc;
@@ -221,9 +222,14 @@ static void check_vendor_extension(u64 paddr,
 
 static void *einj_get_parameter_address(void)
 {
-	int i;
+	int i, rc;
 	u64 pa_v4 = 0, pa_v5 = 0;
 	struct acpi_whea_header *entry;
+	u32 error_type = 0;
+
+	rc = einj_get_available_error_type(&error_type, ACPI_EINJ_GET_ERROR_TYPE);
+	if (rc)
+		return NULL;
 
 	entry = EINJ_TAB_ENTRY(einj_tab);
 	for (i = 0; i < einj_tab->entries; i++) {
@@ -615,19 +621,35 @@ static struct { u32 mask; const char *str; } const einj_error_type_string[] = {
 	{ BIT(17), "CXL.mem Protocol Uncorrectable fatal" },
 	{ BIT(31), "Vendor Defined Error Types" },
 };
+static struct { u32 mask; const char *str; } const einjv2_error_type_string[] = {
+	{ BIT(0), "EINJV2 Processor Error" },
+	{ BIT(1), "EINJV2 Memory Error" },
+	{ BIT(2), "EINJV2 PCI Express Error" },
+};
 
 static int available_error_type_show(struct seq_file *m, void *v)
 {
 	int rc;
 	u32 error_type = 0;
 
-	rc = einj_get_available_error_type(&error_type);
+	rc = einj_get_available_error_type(&error_type, ACPI_EINJ_GET_ERROR_TYPE);
 	if (rc)
 		return rc;
 	for (int pos = 0; pos < ARRAY_SIZE(einj_error_type_string); pos++)
 		if (error_type & einj_error_type_string[pos].mask)
 			seq_printf(m, "0x%08x\t%s\n", einj_error_type_string[pos].mask,
 				   einj_error_type_string[pos].str);
+	if (error_type & ACPI65_EINJV2_SUPP) {
+		rc = einj_get_available_error_type(&error_type, ACPI_EINJV2_GET_ERROR_TYPE);
+		if (rc)
+			return rc;
+		seq_printf(m, "====================\n");
+		for (int pos = 0; pos < ARRAY_SIZE(einjv2_error_type_string); pos++)
+			if (error_type & einjv2_error_type_string[pos].mask)
+				seq_printf(m, "0x%08x\t%s\n", einjv2_error_type_string[pos].mask,
+					einjv2_error_type_string[pos].str);
+
+	}
 
 	return 0;
 }
@@ -662,7 +684,8 @@ static int error_type_set(void *data, u64 val)
 	if (tval & (tval - 1))
 		return -EINVAL;
 	if (!vendor) {
-		rc = einj_get_available_error_type(&available_error_type);
+		rc = einj_get_available_error_type(&available_error_type,
+				ACPI_EINJ_GET_ERROR_TYPE);
 		if (rc)
 			return rc;
 		if (!(val & available_error_type))
diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index a33375e055ad..a07d564b0590 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -1030,6 +1030,7 @@ enum acpi_einj_actions {
 	ACPI_EINJ_SET_ERROR_TYPE_WITH_ADDRESS = 8,
 	ACPI_EINJ_GET_EXECUTE_TIMINGS = 9,
 	ACPI_EINJ_ACTION_RESERVED = 10,	/* 10 and greater are reserved */
+	ACPI_EINJV2_GET_ERROR_TYPE = 0x11,
 	ACPI_EINJ_TRIGGER_ERROR = 0xFF	/* Except for this value */
 };
 
-- 
2.34.1