Received-SPF: pass (google.com: domain of linux-kernel+bounces-100832-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 12 Mar 2024 14:48:06 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, Johannes Thumshirn
 <johannes.thumshirn@wdc.com>, davem@davemloft.net, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, pabeni@redhat.com, bpf@vger.kernel.org, Tejun
 Heo <tj@kernel.org>
Subject: Re: [GIT PULL] Networking for v6.9
Message-ID: <20240312144806.5f9c5d8e@kernel.org>
In-Reply-To: <39c3c4dc-d852-40b3-a662-6202c5422acf@kernel.dk>
References: <20240312042504.1835743-1-kuba@kernel.org>
	<CAHk-=wgknyB6yR+X50rBYDyTnpcU4MukJ2iQ5mQQf+Xzm9N9Dw@mail.gmail.com>
	<20240312133427.1a744844@kernel.org>
	<20240312134739.248e6bd3@kernel.org>
	<CAHk-=wiOaBLqarS2uFhM1YdwOvCX4CZaWkeyNDY1zONpbYw2ig@mail.gmail.com>
	<39c3c4dc-d852-40b3-a662-6202c5422acf@kernel.dk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 12 Mar 2024 15:40:07 -0600 Jens Axboe wrote:
> Hmm, I wonder if the below will fix it. At least from the timer side,
> we should not be using the cached clock.
> 
> 
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index 9a85bfbbc45a..646b50e1c914 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -1044,7 +1044,7 @@ static void ioc_now(struct ioc *ioc, struct ioc_now *now)
>  	unsigned seq;
>  	u64 vrate;
>  
> -	now->now_ns = blk_time_get_ns();
> +	now->now_ns = ktime_get_ns();
>  	now->now = ktime_to_us(now->now_ns);
>  	vrate = atomic64_read(&ioc->vtime_rate);

Let me try this, 'cause doing the revert while listening to some
meeting is beyond me :)