Received-SPF: pass (google.com: domain of linux-kernel+bounces-100854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c35ee088-9502-41e4-b47d-c42ad9c5fb24@intel.com>
Date: Tue, 12 Mar 2024 15:07:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v3] i40e: Prevent setting MTU if greater than MFS
To: Erwan Velu <erwanaliasr1@gmail.com>, Paolo Abeni <pabeni@redhat.com>
CC: Erwan Velu <e.velu@criteo.com>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240312094259.770554-1-e.velu@criteo.com>
 <7169b33e1e4487370a530fb60d97dc096a24acfc.camel@redhat.com>
 <CAL2JzuxA1h=L=0cr+Q6CZ9UDbHB6ptbzCQ7gZddZLi2JumdLQQ@mail.gmail.com>
Content-Language: en-US
From: Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <CAL2JzuxA1h=L=0cr+Q6CZ9UDbHB6ptbzCQ7gZddZLi2JumdLQQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHBUS25aWTVIYjBDOFFWcVdUcnJGMjQxaTdXdm5rU1pjbUFJT1pXOHNMclps?=
 =?utf-8?B?TnBoZTRLeGRXL2JkUWp6ZUhreG1rWGRQNTFwelN4ZWZDc0ZTcEdSbXFqVHU0?=
 =?utf-8?B?RVpPVHlVK0hNdWxTcGlQcUtUVGswdFdzTW1GRUNiZ1J5aVlpVVI0QW54UU9y?=
 =?utf-8?B?a000cy9XdEVIYTl1c3F1Qkc3dTdrZlZUWlgwK0FlU3lrSFkvZTU3dWlXNW91?=
 =?utf-8?B?K2NxdXRQRzBvQmd4SEMyRGRERk5XZ1REZlVwNTZWVElVQTlzUmtUOG10Ujkv?=
 =?utf-8?B?Q2pVMnNld0lRR1BSSDRMejhKb25VdVdLYllvdGZRU0xPc1lyUmpVbW9uWlFh?=
 =?utf-8?B?Z3VqZmhNU2hoRnA1bW9nRUpWT09VeHVqL0xmVThlRi9WUE9SRWtQVUgyOHVC?=
 =?utf-8?B?SHZzUUtSNkFFaVY5VWhtUHBIcHZmZDlCSGpzY2RZVWdUM3hIQllyVmcxUWND?=
 =?utf-8?B?K1IrRHN4cUtndXYzYmJvYlViQzJRRVUxbmFiOGlsdzBqeHZZbVdNaTE0Qlo5?=
 =?utf-8?B?NzRDU0VCMloyNTNkSWRvQndyNjFLTVhIR3VrcW1SeTc4OGZlSVljZ2c0NTdS?=
 =?utf-8?B?d09KL3R5WXkzbDhzV1U4ZldkcmZ3RUdoTXUzTTNocDNORHJLRDFLNWZSSVo4?=
 =?utf-8?B?ek9OdWZja3pNNTRvZHVYZm93SWMwVzBseXhQR2ozV29YYkd4dFBpOWFBdHJO?=
 =?utf-8?B?S2xBZkJnZlp3cWFsWEhCNSsvQkh1anlhZ0Y3ekxXN2JTWmIvcGZOeWVZNUlk?=
 =?utf-8?B?RTBxOVYxOXY1VkE5ckF0bEFxbGd6d0p0UEE3MDZqL01ZamdSSS9YYncrYWti?=
 =?utf-8?B?TEpYSUozZnpJMFJidFkreDlLRitHTjlod3FiRHRyZ1ViYVdZZHVGZTZHTDBQ?=
 =?utf-8?B?YzlFN2NkNmF5cG8yemJBZERoR3lEcXU1YkF0VEo4UGNNLzcvd2tCQW1aVzB6?=
 =?utf-8?B?Y0F3NVpuZk5tUUVGYmtFZ1I4dERaLzZwMDJjajBEc1JTeUI1c2czVzA3dG9H?=
 =?utf-8?B?MkR6U0VLTlBpTys2Ny9Yclh3UWwzNmZCclp0eklPK1IyZ0t4cjNPZW0xemc5?=
 =?utf-8?B?Ui9BdUlJSzU4Skl0MU42L2FLVFdkM2svN29WMDZDWVlLNnZOOFJyY2lIaVhG?=
 =?utf-8?B?VzM2VkQzM2JnRWZZYTNISURXeDFLN3JOSmpVOWRlc0ZzVTNMZXdWeVRyZWoz?=
 =?utf-8?B?QzM4bFUvbmdzTkUrNkFLRk4xc1kvVlU4YnpGSG16U25icTJUOU1YckhKc1pO?=
 =?utf-8?B?cnR1RDl5Q3BEWnRPSUwzVWVKZmNpS0RHVnc4L2kwRGpBTjJtWTczV2RNV0xQ?=
 =?utf-8?B?YklWdkhtSEw1dTdBdzhpS3F5b1d3clpIQkVQdEFXV1lCczYxNmlQRldHZ1lz?=
 =?utf-8?B?QVRoWjY4TnNVbzB4MG1aeUhOUGNIU0ZxeFgzQ0IwL2tjNWgwMVJsTDk2QkpQ?=
 =?utf-8?B?UnFNbmlhZ1A4LzJ5eE0xVHdGYzZORUNHWGxmc0Joc25qcHJLSXpXRi9uMWRH?=
 =?utf-8?B?VlhOckhNVVY5UWxmd0FIeDdoTXhFTGlxMGJIdFA2UHJBcFYwdkZZMDg0RXR1?=
 =?utf-8?B?aFlOS0xrR0taOW1oYjZJbXQxWW45L0RPNnJGM3JnZmR2OTkwVWtWYUoxZ0tK?=
 =?utf-8?B?eDhGMzdGTVZyYTgxTjVIaGkyZzVlcnRNMHJuT2NpcCs4WGdzYU9YRURlTWFN?=
 =?utf-8?B?aHlleE43TUh6N0VVQ3FJbXB1R25vUGRrTkNmY1BnMEFDc3ZRRFAwdDNwb2h0?=
 =?utf-8?B?Vk56N0lDaGNIdmNnbEkyTlVYeWlNdE82ejJJQkliM2owZ1d1RkZvcUVTRGsw?=
 =?utf-8?B?ZkpSUkRWZ3hKL1RRNGs5b0pGcHpzOWZsWHVscXdoNHpTMngvUGVKdnFsVXVW?=
 =?utf-8?B?ZU9haE9MeXlQdmZsSk1WOXVRNnBUUENFUDZCYjc3UGE1TVdxYmFYTmtweXFj?=
 =?utf-8?B?R1JNOXNqUVU2VGpNQ1JMa2o0YzI1Q0ZSUWV5cWJpRkc2ZUlONDZOTXppRGwy?=
 =?utf-8?B?RWszUTJYZWRMTnlFd3Q1eWxqc0ZpTk9RM0VvZnJtQmszRTdrR3VSQmQ3cC8x?=
 =?utf-8?B?QkNxOHY4YW1NSGtuZ2x5ZWlXLzlmNGlJdGg0aS9rbWpvVUw5RmFWV0xIWGM3?=
 =?utf-8?B?L1VzekpMMkF6OS9uTGVtdUdKdEtHTE11SXZWMTVxazJzOHZvdmxEL0Q3SUtH?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 98d18c3e-8e31-4ca7-f471-08dc42e0d9e8
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 22:07:47.7654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g4V3Bhm5eUHUGlJwQT66rqJGu2wcj6VPNUNPu4KnF6IWKzROBpO275w2hz+OtmauW3lVmm4U53kJ0wlPvwYs4rK3MEdl3s/LLTnShIO11Hc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6995
X-OriginatorOrg: intel.com

On 3/12/2024 3:29 AM, Erwan Velu wrote:
>> On Tue, 2024-03-12 at 10:42 +0100, Erwan Velu wrote:
> 
>> This looks like a legit fix that should target the 'net' tree, @Tony:
>> do you agree?
>> If so, Erwan, please include a suitable fixes tag in the next revision.
>> Please include into the subj prefix a suitable target tree. I think
>> this should go first via the intel tree for testing, so 'iwl-net'
>> should fit.
> Oh I didn't knew that part, thx. I'll wait @Tony to see what target I
> should use.

I agree with both parts, so 'iwl-net' would be best.

Thanks,
Tony

> 
>> In any case please respect the 24h grace period when posting on netdev:
> Yeah sorry for the v3 ... I shouldn't have done that way, that fast.