Received-SPF: pass (google.com: domain of linux-kernel+bounces-100855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.87 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.87; helo=repost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <7fc69bf7-4f89-41c0-a800-6e7d450d8b20@seco.com>
Date: Tue, 12 Mar 2024 18:09:03 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/2] nvmem: add new NXP QorIQ eFuse driver
Content-Language: en-US
To: Richard Alpe <richard@bit42.se>, srinivas.kandagatla@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 niklas.soderlund+renesas@ragnatech.se, Michael Walle <michael@walle.cc>
References: <20230410082051.2948510-1-richard@bit42.se>
 <20230410082051.2948510-2-richard@bit42.se>
From: Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20230410082051.2948510-2-richard@bit42.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 XrsAQBYP8aUZYNbVgWHwwLSPN4agnqwRGDF4dokOPD+ITjt4z96OFhE/fUciMk8O20CEM9qU36UZYunUlksd5xqb/6dwhFXWeS+13FOna0RzeheHdkebDV9LzYkA8bJPGHCwC2+H0zjOoivgFyaWprKYZmor44D3d5A5LN0P3crSCK6jxNr7iP5aQgGVIiu1V3icdGRBOelfwoPMml7IVySBiKbZ2wvycO11Kvz8/7EeqjVIoT6H/D68HuLNRVh06eSYkJLyEl/0l6tRGRGO10yV/6yMTHAllampQrRLsBNwpjCHW8tkqbvwVPOHPRzqIFHwhZMeY7Yx2F/G7OvifhsxhXS1/jMnzcNt/80t3CWHtZdUeWcA7+1H30PHFXW93yaA/oFMamB/lSjfaL+tP3FDRGzfjrYx5nGe2fo5VvCOcLpVgrOdX5af0iHaqnG9ralIwja4hSQAOFqJjng5Uwb5dSdsYmKC5iTFkCaEjPr6Yi/0I8wFHM0Mj5QCGGO721Se8gtqUAitSWIsQT9JHyaiLlv2YXWdxpxPtvzeNtMMqjZAOAwhEJhGLLrlW/0FuZB3azybcH70U0/SSln4ivVycZxMaQNB7FjZvlAo/H/M9iYkuQwMXsUatI8it7wyFhZNipQAZdjDJkv43X5Ti1wmixO2cN+GnmdCtvJAWmhXbkDgqz+ofV1Grf66udprLhekcZ9wsJRBXATI1KFUtwFa6NzwRVBiP1wcsiryo9E=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(52116005)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB8145
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM2PEPF0001C715.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	58a46dd3-5006-4e24-49b7-08dc42e10ac4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cbPgq71lUHpHBnNNmQqlu2gkOxiDkdp2bXBykfUe689dwaN24uWhrxzB97vKZOml6fG3zuRvvyBXrqOm1X6zeEcUf+3EE48orVn3CIPLH1es91kgxbzokY7mqHRtTB8kmeLIzX2vfj7VDjlZV/cmReIAiiig15kwyhvDKfzP2LzcJgJRCc6ryAjZkafvOKXHZGndX8vdQqtf0S56H/dUXYLwxQdrxwv9XstCQAzG2GHjicEXtoqlCeMYM2vELly/Mha/Tb3/mNZoIly7H1pPTYL+KxZj+pi1TNPQyRet6mWlh3YXf0vgak2r+5ecRQYyoBK+jTIJMxglquRpIYVYFtp+NUXeTJZcwS5vbld1TFrlkjQE7GuWMROyajQ6NKbDAwgjMX7/qZ2bmDHgHz8QKc6D2z5sDZJQa0rd4YyNW06XGMgwLp80fmGumOVCajKa8BkkRQe6Syi8J2u69Ym1ki5dMO/Rl0XukwP+UZUH//bqxWTPYBFTxDZ5CVWnDSRTwA7APpXPY+4jgHFDoxZOtOeFIMBnea8qklHy92jaq/VyjEmerBS7CXLGUqhjSI1oilSbnVbu9frjIPY27wOEP3DDb3yXWFs6lDM/cNtAIDFvBOP094264lFvu+4ar/u6CGLr50va9464jGAV2tyUvF94h9fMne8+VZ1SGNdO60y5lag+a6nTxJuoeFR/S8diXPcjwtU+V6L+Sz/OLcLGzymbePwaC3ICK7WALdmmmieXXoIV/TYfxNZl7T0h006R
X-Forefront-Antispam-Report:
	CIP:20.160.56.87;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(376005)(1800799015)(82310400014)(36860700004);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 22:09:16.5126
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b803e02-2f3a-4855-2cb4-08dc42e10ef2
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.87];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM2PEPF0001C715.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6564

On 4/10/23 04:20, Richard Alpe wrote:
> Add SFP (Security Fuse Processor) read support for NXP (Freescale)
> QorIQ series SOC's.
>
> This patch adds support for the T1023 SOC using the SFP offset from
> the existing T1023 device tree. In theory this should also work for
> T1024, T1014 and T1013 which uses the same SFP base offset.
>
> Signed-off-by: Richard Alpe <richard@bit42.se>

This seems like a duplicate of layerscape-sfp.c. The hardware is
(presumably) quite similar, with the T1024RM referencing the QorIQ Trust
Architecture User Guide version 2.0, and the L1046 (e.g.) referencing
version 2.1.

I think this driver should be removed in favor of the older driver.
There are some problematic bits: most notably no offset is applied by
this driver, so all fuses have an offset of 0x200. So we will need to
implement/document this only for the "fsl,t1023-sfp" compatible, which
has already made its way into the T1023 devicetree...

This really should have been caught during review; a quick grep for
"SFP" would have revealed the duplication.

--Sean

[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embed=
dedworld2024/Register/ew24517689>