Received-SPF: pass (google.com: domain of linux-kernel+bounces-100856-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.85 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.85; helo=repost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <3bfc0393-70bb-4120-abfb-530eaaa88b25@seco.com>
Date: Tue, 12 Mar 2024 18:13:02 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/2] nvmem: add new NXP QorIQ eFuse driver
Content-Language: en-US
From: Sean Anderson <sean.anderson@seco.com>
To: Richard Alpe <richard@bit42.se>, srinivas.kandagatla@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 niklas.soderlund+renesas@ragnatech.se, Michael Walle <michael@walle.cc>
References: <20230410082051.2948510-1-richard@bit42.se>
 <20230410082051.2948510-2-richard@bit42.se>
 <7fc69bf7-4f89-41c0-a800-6e7d450d8b20@seco.com>
In-Reply-To: <7fc69bf7-4f89-41c0-a800-6e7d450d8b20@seco.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 s1/sRoKZMCFjcB19WOo6DXNALh4ztyPWiNXrAsXjMS3JOQXlXGDYXflWBNzcBsHgwDvkc/JsfV2pgGcbbZ1Qp8fnwdF8Pp2m/o7JAUoLrSRAIcBhbfA9lHAh7bs+bhqxcj5j1QwhuxhhN4xQQyQOk1G1JKdRBev9Z7xHjeklp7TEpZPhZ7hjRmg4drLD1yW4YYeuZFi0tuePtUAIewYBjKvixm/QGUFr5dor8S8hwXoueGDxwDFkK3EpfT7xAkuM9jRs+2Qe+U91qbsOsEJJwAlfHeTxwGBSPI/Ou+tW4Ddwe/aHOn3oCtWpC3Kh4k0Hua29NUvYOxHaNofuMjHfa99WiDL7Ipb6RmDWnEC8KeOjqTpphUcKw/S9xun1TXUS3NzwTa9CMVQ0gCsdeyWswGeR2MF1d1Itq9UQ93/yAuO75k6xG5v/6gPj6df4g+OmTlWDEk/EWFm3ZXabm+Q40tCA9KG755ax+WYE7QacHvsX5PDRiDp3qRRqPg3j/IBEYsTn4reEXLGUVGNNPwg9/0d0oWy7qoWssaq/XWOBC/tXaq/0NQj4ZfOupceY7nQGeg0JYMHmRSGxsmm8BWKPIFgB12x0tUeMqZ0v1D94RvmlLmR+0x/p3rimfEouPQiAwOvytIR8YvekI+jkrsY8fH0jniMoVLIKuTBxWW04Km+CLXCHUMUB6h2OuaNmIstSdX2DaWVUpn/UWwqHOCq0T93sEOCLjgkdxwOQMaYmsrA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(52116005)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB8145
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AMS0EPF000001A1.eurprd05.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2a2119c2-3c2c-435a-7e02-08dc42e198ce
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BA9NC+5jGLbldb/KcCDTnVF/wzfJwtD74kQdUFZZBGwkyLzi5nAwfj6v/fEnA3LJMyszSFBrCIKAWK1Fbff7iyT7V8P1gvwz5eq9HsV1eNH8c6/YrFxrszpD9Yun6oYl1WloWA/FKQDiPSqYimaqQOeGEDypNkT3FjVCitDpBWE0/Gj4QnRqP/3H/oevoj6Cwt1lmfjfzEL0Dc6zlNTaG1XrC39Jiu9fBGEqbo9T8k6aLhcj38F3kj3ilBSPRskp7WdN+Czi2L9ZBFJQLBtxhVt5NmJSRCFKwSwZp8A0yeByyQmllW9bO7AXnC01uIPj3lsENc2WRdgaEqTAnPQjZRJ2NjbRAqduvLWr/YXxFWaSFn8xgyeoTELCRNfYMs/OxN1JuQXC55UikvJ6rT87ltw4fEwUljhAktkV+tzf+RXkMv8U2Iq5yS/JVxroPGy9ww5S2bz2qZblXt2Ndw87OFn32kSK4WQ/hgeywsO4FUTMSO/Fc8yQM9S3I0PVv8yf/fC1guVdgVJoG9PQoxlp/Fflhh99O9MadU3pxuwDjJUVgt9nj9xC7Z7oWOS7Luo+R9VOkDxpxxl3EQtkbvbrNsgUNF66RJ5T/+ctZ1HfSpT4Mogn/uHshPPHZkUDJUblE0aeaL++sMNccU1cClfW9bNvCbbdCCb3x8kISY1th+vzj4ocj7ooIOzrWokEeJEvqCIR+Z3ffGUeBzVurtFC1dIk3yVEZKPOuLEHR+8l7JndDKVydJKQ9pB1yUB+SBEw
X-Forefront-Antispam-Report:
	CIP:20.160.56.85;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(82310400014)(376005)(36860700004)(1800799015);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 22:13:11.2917
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c44f5d77-f66b-42b0-a20d-08dc42e19ae2
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.85];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AMS0EPF000001A1.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7168

On 3/12/24 18:09, Sean Anderson wrote:
> On 4/10/23 04:20, Richard Alpe wrote:
>> Add SFP (Security Fuse Processor) read support for NXP (Freescale)
>> QorIQ series SOC's.
>>
>> This patch adds support for the T1023 SOC using the SFP offset from
>> the existing T1023 device tree. In theory this should also work for
>> T1024, T1014 and T1013 which uses the same SFP base offset.
>>
>> Signed-off-by: Richard Alpe <richard@bit42.se>
>
> This seems like a duplicate of layerscape-sfp.c. The hardware is
> (presumably) quite similar, with the T1024RM referencing the QorIQ Trust
> Architecture User Guide version 2.0, and the L1046 (e.g.) referencing
> version 2.1.
>
> I think this driver should be removed in favor of the older driver.
> There are some problematic bits: most notably no offset is applied by
> this driver, so all fuses have an offset of 0x200. So we will need to
> implement/document this only for the "fsl,t1023-sfp" compatible, which
> has already made its way into the T1023 devicetree...

Actually, it seems like the driver was added long after the compatible
was added to t1023si-post.dtsi, so maybe we can just change the semantics
of the nvmem cell offset.

--Sean

> This really should have been caught during review; a quick grep for
> "SFP" would have revealed the duplication.
>
> --Sean


[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embed=
dedworld2024/Register/ew24517689>