Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757191AbYAGUEV (ORCPT ); Mon, 7 Jan 2008 15:04:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753465AbYAGUEI (ORCPT ); Mon, 7 Jan 2008 15:04:08 -0500 Received: from relay2.sgi.com ([192.48.171.30]:47302 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752372AbYAGUEH (ORCPT ); Mon, 7 Jan 2008 15:04:07 -0500 Date: Mon, 7 Jan 2008 12:04:06 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Dhaval Giani cc: Andrew Morton , htejun@gmail.com, Srivatsa Vaddagiri , Balbir Singh , maneesh@linux.vnet.ibm.com, lkml , linux-mm@kvack.org Subject: Re: 2.6.22-stable causes oomkiller to be invoked In-Reply-To: Message-ID: References: <20071217045904.GB31386@linux.vnet.ibm.com> <20071217120720.e078194b.akpm@linux-foundation.org> <20071221044508.GA11996@linux.vnet.ibm.com> <20071228101109.GB5083@linux.vnet.ibm.com> <20080103035942.GB26166@linux.vnet.ibm.com> <20080103041606.GC26166@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 42 Here is the cleaned version of the patch. Dhaval is testing it. quicklists: Only consider memory that can be used with GFP_KERNEL Quicklists calculates the size of the quicklists based on the number of free pages. This must be the number of free pages that can be allocated with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and ZONE_MOVABLE which may lead the quicklists to become too large causing OOM. Signed-off-by: Christoph Lameter Index: linux-2.6/mm/quicklist.c =================================================================== --- linux-2.6.orig/mm/quicklist.c 2008-01-07 10:38:13.000000000 -0800 +++ linux-2.6/mm/quicklist.c 2008-01-07 10:38:44.000000000 -0800 @@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quickli static unsigned long max_pages(unsigned long min_pages) { unsigned long node_free_pages, max; + struct zone *zones = NODE_DATA(numa_node_id())->node_zones; + + node_free_pages = +#ifdef CONFIG_ZONE_DMA + zone_page_state(&zones[ZONE_DMA], NR_FREE_PAGES) + +#endif +#ifdef CONFIG_ZONE_DMA32 + zone_page_state(&zones[ZONE_DMA32], NR_FREE_PAGES) + +#endif + zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES); - node_free_pages = node_page_state(numa_node_id(), - NR_FREE_PAGES); max = node_free_pages / FRACTION_OF_NODE_MEM; return max(max, min_pages); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/