Received-SPF: pass (google.com: domain of linux-kernel+bounces-100911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 13 Mar 2024 00:13:13 +0100
From: Frederic Weisbecker <frederic@kernel.org>
To: Nicolas Saenz Julienne <nsaenz@amazon.com>
Cc: jalliste@amazon.co.uk, mhiramat@kernel.org, akpm@linux-foundation.org,
	pmladek@suse.com, rdunlap@infradead.org, tsi@tuyoix.net,
	nphamcs@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	pbonzini@redhat.com, seanjc@google.com, paulmck@kernel.org
Subject: Re: [RFC] cputime: Introduce option to force full dynticks
 accounting on NOHZ & NOHZ_IDLE CPUs
Message-ID: <ZfDhiakZWIYGSUTl@pavilion.home>
References: <20240219175735.33171-1-nsaenz@amazon.com>
 <CZR39LW50A9F.1DWG2FYJ3OZP8@amazon.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CZR39LW50A9F.1DWG2FYJ3OZP8@amazon.com>

Le Mon, Mar 11, 2024 at 05:15:26PM +0000, Nicolas Saenz Julienne a ?crit :
> Hi Frederic,
> 
> On Mon Feb 19, 2024 at 5:57 PM UTC, Nicolas Saenz Julienne wrote:
> > Under certain extreme conditions, the tick-based cputime accounting may
> > produce inaccurate data. For instance, guest CPU usage is sensitive to
> > interrupts firing right before the tick's expiration. This forces the
> > guest into kernel context, and has that time slice wrongly accounted as
> > system time. This issue is exacerbated if the interrupt source is in
> > sync with the tick, significantly skewing usage metrics towards system
> > time.
> >
> > On CPUs with full dynticks enabled, cputime accounting leverages the
> > context tracking subsystem to measure usage, and isn't susceptible to
> > this sort of race conditions. However, this imposes a bigger overhead,
> > including additional accounting and the extra dyntick tracking during
> > user<->kernel<->guest transitions (RmW + mb).
> >
> > So, in order to get the best of both worlds, introduce a cputime
> > configuration option that allows using the full dynticks accounting
> > scheme on NOHZ & NOHZ_IDLE CPUs, while avoiding the expensive
> > user<->kernel<->guest dyntick transitions.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenz@amazon.com>
> > Signed-off-by: Jack Allister <jalliste@amazon.co.uk>
> > ---
> 
> Would you be opposed to introducing a config option like this? Any
> alternatives you might have in mind?

I'm not opposed to the idea no. It is not the first time I hear about people
using generic virt Cputime accounting for precise stime/utime measurements on
benchmarks. But let me sit down and have a look at your patch. Once I find
my way through performance regression reports and rcutorture splats anyway...

Thanks!