Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1398564lql; Tue, 12 Mar 2024 16:42:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVMXQHzTazWenjvggQFv3zSFY+pK1CDJ5C68ixB46gqnG6ZK4g2JjAPoXt9XapRKNRtYObB1Ia773b0vDlSV1iBB0K/CNd3C2pspaoWQg== X-Google-Smtp-Source: AGHT+IHEeTTX/lcp8L7r34uyVoTOxNV4KJw2Kgly0QCkTGApIHx/y1VIp1qKXycMsuYQdltZdAUS X-Received: by 2002:a05:6a20:7d9d:b0:1a1:491e:8aba with SMTP id v29-20020a056a207d9d00b001a1491e8abamr1457144pzj.22.1710286954693; Tue, 12 Mar 2024 16:42:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710286954; cv=pass; d=google.com; s=arc-20160816; b=MACKncZ8vFnKEgZZXnalbaqrZT+JcW1a6zWPWmfh7VAca2rKpB8HrMPavEjHigGXkn 29+f+ymO00TLFIOoYY/ywt83bou3wJeuDvqGUSS2ePzQf9/fl2YZXkdffO+d5EfqZSJr u21Dt5JVqJd/+oPcK9JbSE8DHCcdrLdbhlf26y4Es4O97RzY+xAGh6tkR1XSlp3jrnEK cDU1sCJUvriqO0a4jA2dxy+SpuHwcB7D7y/rQJ8ZjBLpfywOwtmHkOwXLAs3ExC/56Zi J9+Bjf+DDo1vu70mLdBEVNa+qqbOrDZKYw4SYL4aZFaX4nR12XKQFoO0/kjpnylKrO3i o44g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=wkNpxsHKIj3ITIwanDS8j2E08NoOhU6t3oRVH/9xOPA=; fh=XGjcH96xaYgo1uxkZe2+NehycjRZsqwvqGJiSHrAYcg=; b=jPbvnuEJB714JDQX9P96cQIlJQ9WfU/NUUkLb3L3Xa2Aul5UZJa3zmXFQEZbLuteCc xhNyH2VPxuRfHP3Y9npE66eXWjByxtKYcNbGYgtbknsONCD1G3fPWDYuWDwH8pcwkgEl f3fXf0Xfc2MKil+f0EgL5Jc/QK3z9EVcDOv3tsg61qaDfHbNdyrGAfqKxoH+tYEHErtT +nvA9N8B1F1OBp9+UaTpkmb+N08RmgqQP4fuik6x9Ruu8GyG88SFOMNnTQz3pJuwJxiB k57Jmh2FQbLi8WhOQE0COM0CbaoZXjY4q/FRW/rqPLoxwNxxt2cmURNfQ5Z+hu1lTtJw ZiQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WRGMJLFF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100927-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cm23-20020a056a00339700b006e6b9e2bd0csi39881pfb.161.2024.03.12.16.42.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 16:42:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-100927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WRGMJLFF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-100927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-100927-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 903792823CD for ; Tue, 12 Mar 2024 23:42:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29EB74AEC7; Tue, 12 Mar 2024 23:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WRGMJLFF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A3004779C; Tue, 12 Mar 2024 23:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710286943; cv=none; b=CaggXcyTBG6KRTTeX45Vf9VHIaFbh9RyQ6l08oYlfhztdpfbncF62BdDkkJrYXYUEudpJGVe5Z1ppu94oQ6M8num5NH+HlzrfRAeM3KhlMXXytPbraTXFUH70jt99ZxYAbkq/TwLBm4e2/uzed10oWgwJWsEZ+fYUeJrlnpelR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710286943; c=relaxed/simple; bh=05A/YBD+rxHHpBthb4+S+Ak7pHZr1GBzLlmla4nXVNI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AMXFZp+Z149p6kfrLvY9WkGT3b8vRaSZ4ZW4HkXwwn6NHrfSOLcCghRi60RxflOaa8kwa7eQNZLWPIDuI0i0xqVICDIUaKUMe433zQKB22aaRFRqS0mrgUdVl/+sFSbrcpMlu8W2EWFjh5/bBxnbvU+T5q577+OoKdzUOEjeAg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WRGMJLFF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73C77C433F1; Tue, 12 Mar 2024 23:42:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710286942; bh=05A/YBD+rxHHpBthb4+S+Ak7pHZr1GBzLlmla4nXVNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WRGMJLFFOQJLSoqERFYLaPswoGKHmCUfQ6TcGzkU52htuvbVI+u72CioLu2qrtAdX o8KlDlBON6/nyO+gN2MjCLkwhTBRk7v8pp1l95DoFbRaYt+kkjmEhXY9uuOGpmFvhQ KQ9940j/auy1AgriACE212Eig8Ol29Jz9VQQq8tHudS9LISZ7XjB9TEz9oPBe/3LBB EtIJ/7ktz8uN3tvjYqh3P7oEc7J/FhElqo2GDLfrrl0D9fIzYEpwE/vDb7g/Ywjx5z 3dxf9pnvmc9xaXS8r04eTB/vAyhtMLzbVXx71DX/LTGpClFQ43ZJUSEP0fx4e6Zu0R xKt2Ru8RGN8LA== Date: Tue, 12 Mar 2024 16:42:21 -0700 From: Jakub Kicinski To: Ignat Korchagin Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com Subject: Re: [PATCH net v2 0/2] net: veth: ability to toggle GRO and XDP independently Message-ID: <20240312164221.5bf92fd0@kernel.org> In-Reply-To: <20240312160551.73184-1-ignat@cloudflare.com> References: <20240312160551.73184-1-ignat@cloudflare.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 12 Mar 2024 16:05:49 +0000 Ignat Korchagin wrote: > It is rather confusing that GRO is automatically enabled, when an XDP program > is attached to a veth interface. Moreover, it is not possible to disable GRO > on a veth, if an XDP program is attached (which might be desirable in some use > cases). > > Make GRO and XDP independent for a veth interface. Looks like the udpgro_fwd.sh test also needs tweakin' https://netdev-3.bots.linux.dev/vmksft-net/results/504620/17-udpgro-fwd-sh/stdout -- pw-bot: cr