Received-SPF: pass (google.com: domain of linux-kernel+bounces-100950-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Andi Kleen <ak@linux.intel.com>
To: weilin.wang@intel.com
Cc: Namhyung Kim <namhyung@kernel.org>,  Ian Rogers <irogers@google.com>,
  Arnaldo Carvalho de Melo <acme@kernel.org>,  Peter Zijlstra
 <peterz@infradead.org>,  Ingo Molnar <mingo@redhat.com>,  Alexander
 Shishkin <alexander.shishkin@linux.intel.com>,  Jiri Olsa
 <jolsa@kernel.org>,  Adrian Hunter <adrian.hunter@intel.com>,  Kan Liang
 <kan.liang@linux.intel.com>,  linux-perf-users@vger.kernel.org,
  linux-kernel@vger.kernel.org,  Perry Taylor <perry.taylor@intel.com>,
  Samantha Alt <samantha.alt@intel.com>,  Caleb Biggers
 <caleb.biggers@intel.com>
Subject: Re: [RFC PATCH v4 1/6] perf stat: Parse and find tpebs events when
 parsing metrics to prepare for perf record sampling
In-Reply-To: <20240312234921.812685-2-weilin.wang@intel.com> (weilin wang's
	message of "Tue, 12 Mar 2024 19:49:16 -0400")
References: <20240312234921.812685-1-weilin.wang@intel.com>
	<20240312234921.812685-2-weilin.wang@intel.com>
Date: Tue, 12 Mar 2024 16:58:22 -0700
Message-ID: <87plvzm28x.fsf@linux.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

weilin.wang@intel.com writes:
> +
> +			new_event->tpebs_name = strdup(id);
> +			*p = '\0';
> +			name = malloc(strlen(id) + 2);
> +			if (!name)
> +				return -ENOMEM;
> +
> +			at = strchr(id, '@');
> +			if (at != NULL) {
> +				*at = '/';
> +				at = strchr(id, '@');
> +				*at = '/';
> +				strcpy(name, id);
> +				strcat(name, "p");
> +			} else {
> +				strcpy(name, id);
> +				strcat(name, ":p");


This seems like a buffer overflow because :p is 3 bytes including 0,
but you only allocate + 2.
You should really use safe string primitives, then you would have
noticed the truncation.

-Andi