Received-SPF: pass (google.com: domain of linux-kernel+bounces-100963-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Wang, Weilin" <weilin.wang@intel.com>
To: Andi Kleen <ak@linux.intel.com>
CC: Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>, Peter Zijlstra
	<peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Alexander Shishkin
	<alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, "Hunter,
 Adrian" <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>,
	"linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Taylor,
 Perry" <perry.taylor@intel.com>, "Alt, Samantha" <samantha.alt@intel.com>,
	"Biggers, Caleb" <caleb.biggers@intel.com>
Subject: RE: [RFC PATCH v4 1/6] perf stat: Parse and find tpebs events when
 parsing metrics to prepare for perf record sampling
Thread-Topic: [RFC PATCH v4 1/6] perf stat: Parse and find tpebs events when
 parsing metrics to prepare for perf record sampling
Thread-Index: AQHadNf1fqMifoMxgk2kK+XRspdLP7E0yK6KgAAH8dA=
Date: Wed, 13 Mar 2024 00:27:45 +0000
Message-ID: <CO6PR11MB56356C8B9E938EBF39524C1EEE2A2@CO6PR11MB5635.namprd11.prod.outlook.com>
References: <20240312234921.812685-1-weilin.wang@intel.com>
	<20240312234921.812685-2-weilin.wang@intel.com>
 <87plvzm28x.fsf@linux.intel.com>
In-Reply-To: <87plvzm28x.fsf@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0wKcLdxArGFheKWMdaODuo6kBds69RfdaE7rzwhyW6it84Wloqf76HjJoYKZ?=
 =?us-ascii?Q?uU97pwcWpX60Nu0p3atTlJAGFCPS0pgk5rnA0PC71hUjGWGHh67tipyB5SQ7?=
 =?us-ascii?Q?djzccGjT/CU5Tyj9O2CFK5ToCyezzE54nX65kuip/VFfqVJRgipWgDBijY2I?=
 =?us-ascii?Q?bfg0L1D2a/RCs8A0GTCHaQEAdvNez+6dukXhVaLWFBjdXjN+fPVFp4+NXZQR?=
 =?us-ascii?Q?ozaE1nrLa3xqfWYs+J/XHxDjad+aT87nsUTJ9K1JX8STmGrQWv7Mrfz9qf3w?=
 =?us-ascii?Q?sZ4uqcPmYuvOtm0aUtf1QYE97Y76KqQMbA0QA2FFwUYAm0UpcgGAdAzCMZW5?=
 =?us-ascii?Q?6T94m4j3x43Ko/WSroCMpe0rZZXExEjRPSMJM/NHvvP+gcrIGMknV0J0O4vT?=
 =?us-ascii?Q?LWwOQqwiDMH4eZNqc+2VNAazVWOKwDHuhGt0wkOH4EWSqNtYnu7TbdREV4xC?=
 =?us-ascii?Q?YOcXp3ouFmX8QBdMXD7vaWrjKOdTUmoGUHsUTLLwAcd/E6CTrekqQFj8JSXF?=
 =?us-ascii?Q?Bd9zT3wvueOhxmcUEq/CvW2/5B1Erqb4Vh36iZVm1hmbW3IIJLNvh8Fo7Fs2?=
 =?us-ascii?Q?GUNC4V+YW/ZiI9ez2IYK5LI3LH2iMYBZOOxZGBJIaxFcaHuwLHcaJdLlQ+hw?=
 =?us-ascii?Q?iFb+G+lMHI8oCibmCYY3C3du/XqxGp4SG9dk7qxLPAdJWAcJscWI7DOt/yLT?=
 =?us-ascii?Q?b4+AXt+StmR993GlAYp6YJdIzict12BWpffRXnLidqRvIlhWSMVN1yXDUnnr?=
 =?us-ascii?Q?2xVMhAMxMBbDbq/HXyosnrH+a5z5iJV1zi6rBDE9WKR8i0H/StF+e0GSWaT4?=
 =?us-ascii?Q?iLRABwLZobMlrKPQaGePzSDl1pe8SP9pgY88zbYlHGNcwmKSPmaqixSQ31Gw?=
 =?us-ascii?Q?Rteh0gdZJ9e2E4ktJaROjbwozS6XORpgGN26R0vBAE+yiypbe+fxUCeLmDwH?=
 =?us-ascii?Q?cuVf26/KSuIQbmdQUL6cECK42fgmRZOI0Pkvs8d4f4M25PtmLUoirX1ikAwd?=
 =?us-ascii?Q?IVSsO58nPTvebYJT/Vbje+gVXZZRLmwe9DDyAcg6qEVS6FaoagMd4OuVNHwV?=
 =?us-ascii?Q?S0KXzinzAhnU35BXiA5AUlWxP+E1d0rOhF+e8hh+TW0P5pBLcoqAjfBLPJMo?=
 =?us-ascii?Q?ahAbe0SyM+uYFlxYUN/UU5bmkRrperw/tUFf361Y8oYTxJo4ZRbZEwpj37EI?=
 =?us-ascii?Q?YLGBcmhF2PdHi6VnE4/yPQgnNc0Ulxv1eqE3UgeW/VMk1RZurS0l4oTeLBHt?=
 =?us-ascii?Q?MVmy3z7wB/zncokB7+pcZoNSA/eCWF/CJ/O8X6FLDoIiFoDCiEe3XsGL65GA?=
 =?us-ascii?Q?Yt9mPxc49SymmjdSnUgAzRasgLYDTQOO0B6A3fNvZpfeabLm70Q232Lf9k3+?=
 =?us-ascii?Q?9zt+NHB0mNJ9vJZPBQLoBP2WVuKIkEb2W/W2RRplC4hRO31GcaLWv9bZ5V/2?=
 =?us-ascii?Q?Pg94QXBNgpWUds6eEM6Zcmr2AcxbxrQU9b/eKnvFdK6Ja94LnBH86aE6UcqR?=
 =?us-ascii?Q?i/NGTZ96oqDd+3gnQYoatATPPtGOGR+gS5s5zHGoLCdAW/avVRzEt9JCtaXE?=
 =?us-ascii?Q?qcGghGmXvK+ORis9sVvMs39aFjht4E1SQRVCvUsW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5635.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1b11d9a-71dc-4c2a-0e90-08dc42f4679d
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 00:27:45.7218
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rtr28u3SP18UG5sqT+yFY3n21Saf6Qh7ObjX1EOEd6ysF3pjUJNQ40XuqOrg8VjJrT8QlrO6sXFWJTT6TqKY7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8755
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Andi Kleen <ak@linux.intel.com>
> Sent: Tuesday, March 12, 2024 4:58 PM
> To: Wang, Weilin <weilin.wang@intel.com>
> Cc: Namhyung Kim <namhyung@kernel.org>; Ian Rogers
> <irogers@google.com>; Arnaldo Carvalho de Melo <acme@kernel.org>; Peter
> Zijlstra <peterz@infradead.org>; Ingo Molnar <mingo@redhat.com>;
> Alexander Shishkin <alexander.shishkin@linux.intel.com>; Jiri Olsa
> <jolsa@kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Kan Liang
> <kan.liang@linux.intel.com>; linux-perf-users@vger.kernel.org; linux-
> kernel@vger.kernel.org; Taylor, Perry <perry.taylor@intel.com>; Alt, Sama=
ntha
> <samantha.alt@intel.com>; Biggers, Caleb <caleb.biggers@intel.com>
> Subject: Re: [RFC PATCH v4 1/6] perf stat: Parse and find tpebs events wh=
en
> parsing metrics to prepare for perf record sampling
>=20
> weilin.wang@intel.com writes:
> > +
> > +			new_event->tpebs_name =3D strdup(id);
> > +			*p =3D '\0';
> > +			name =3D malloc(strlen(id) + 2);
> > +			if (!name)
> > +				return -ENOMEM;
> > +
> > +			at =3D strchr(id, '@');
> > +			if (at !=3D NULL) {
> > +				*at =3D '/';
> > +				at =3D strchr(id, '@');
> > +				*at =3D '/';
> > +				strcpy(name, id);
> > +				strcat(name, "p");
> > +			} else {
> > +				strcpy(name, id);
> > +				strcat(name, ":p");
>=20
>=20
> This seems like a buffer overflow because :p is 3 bytes including 0,
> but you only allocate + 2.
> You should really use safe string primitives, then you would have
> noticed the truncation.
>=20

I will double check and update this part.

Thanks,
Weilin

> -Andi