Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758577AbYAGUhW (ORCPT ); Mon, 7 Jan 2008 15:37:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755174AbYAGUhK (ORCPT ); Mon, 7 Jan 2008 15:37:10 -0500 Received: from dns2.vpop.net ([216.193.240.3]:2743 "EHLO thorin.vpop.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbYAGUhJ (ORCPT ); Mon, 7 Jan 2008 15:37:09 -0500 X-Greylist: delayed 1954 seconds by postgrey-1.27 at vger.kernel.org; Mon, 07 Jan 2008 15:37:09 EST Subject: Re: [PATCH] DS1WM: decouple host IRQ and INTR active state settings. From: Matt Reimer To: Philipp Zabel Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov , Szabolcs Gyurko In-Reply-To: <1199627174.28826.11.camel@localhost.localdomain> References: <1199627174.28826.11.camel@localhost.localdomain> Content-Type: text/plain Organization: VPOP Technologies, Inc Date: Mon, 07 Jan 2008 12:04:03 -0800 Message-Id: <1199736243.26310.41.camel@bilbo.vpop.net> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 19 On Sun, 2008-01-06 at 14:46 +0100, Philipp Zabel wrote: > The DS1WM driver incorrectly infers the IAS bit (1-wire interrupt active > high) from IRQ settings. There are devices that have IAS=0 but still need > the IRQ to trigger on a rising edge. With this patch, machines with DS1WM > that need IAS=1 have to set .active_high=1 in the ds1wm_platform_data. > > Signed-off-by: Philipp Zabel Looks good to me. Signed-off-by: Matt Reimer Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/