Received-SPF: pass (google.com: domain of linux-kernel+bounces-100984-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Andi Kleen <ak@linux.intel.com>
To: "Wang, Weilin" <weilin.wang@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>,  Ian Rogers <irogers@google.com>,
  Arnaldo Carvalho de Melo <acme@kernel.org>,  Peter Zijlstra
 <peterz@infradead.org>,  Ingo Molnar <mingo@redhat.com>,  Alexander
 Shishkin <alexander.shishkin@linux.intel.com>,  Jiri Olsa
 <jolsa@kernel.org>,  "Hunter, Adrian" <adrian.hunter@intel.com>,  Kan
 Liang <kan.liang@linux.intel.com>,  "linux-perf-users@vger.kernel.org"
 <linux-perf-users@vger.kernel.org>,  "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>,  "Taylor, Perry" <perry.taylor@intel.com>,
  "Alt, Samantha" <samantha.alt@intel.com>,  "Biggers, Caleb"
 <caleb.biggers@intel.com>
Subject: Re: [RFC PATCH v4 2/6] perf stat: Fork and launch perf record when
 perf stat needs to get retire latency value for a metric.
In-Reply-To: <CO6PR11MB56356A213DBE53535E9D802BEE2A2@CO6PR11MB5635.namprd11.prod.outlook.com>
	(Weilin Wang's message of "Wed, 13 Mar 2024 00:26:26 +0000")
References: <20240312234921.812685-1-weilin.wang@intel.com>
	<20240312234921.812685-3-weilin.wang@intel.com>
	<87le6nm20o.fsf@linux.intel.com>
	<CO6PR11MB56356A213DBE53535E9D802BEE2A2@CO6PR11MB5635.namprd11.prod.outlook.com>
Date: Tue, 12 Mar 2024 17:56:04 -0700
Message-ID: <87edcflzkr.fsf@linux.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

"Wang, Weilin" <weilin.wang@intel.com> writes:

>> -----Original Message-----
>> From: Andi Kleen <ak@linux.intel.com>
>> Sent: Tuesday, March 12, 2024 5:03 PM
>> To: Wang, Weilin <weilin.wang@intel.com>
>> Cc: Namhyung Kim <namhyung@kernel.org>; Ian Rogers
>> <irogers@google.com>; Arnaldo Carvalho de Melo <acme@kernel.org>; Peter
>> Zijlstra <peterz@infradead.org>; Ingo Molnar <mingo@redhat.com>;
>> Alexander Shishkin <alexander.shishkin@linux.intel.com>; Jiri Olsa
>> <jolsa@kernel.org>; Hunter, Adrian <adrian.hunter@intel.com>; Kan Liang
>> <kan.liang@linux.intel.com>; linux-perf-users@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Taylor, Perry <perry.taylor@intel.com>; Alt, Samantha
>> <samantha.alt@intel.com>; Biggers, Caleb <caleb.biggers@intel.com>
>> Subject: Re: [RFC PATCH v4 2/6] perf stat: Fork and launch perf record when
>> perf stat needs to get retire latency value for a metric.
>> 
>> weilin.wang@intel.com writes:
>> 
>> > From: Weilin Wang <weilin.wang@intel.com>
>> >
>> > When retire_latency value is used in a metric formula, perf stat would fork a
>> > perf record process with "-e" and "-W" options. Perf record will collect
>> > required retire_latency values in parallel while perf stat is collecting
>> > counting values.
>> 
>> How does that work when the workload is specified on the command line?
>> The workload would run twice? That is very inefficient and may not
>> work if it's a large workload.
>> 
>> The perf tool infrastructure is imho not up to the task of such
>> parallel collection.
>> 
>> Also it won't work for very long collections because you will get a
>> very large perf.data. Better to use a pipeline.
>> 
>> I think it would be better if you made it a separate operation that can
>> generate a file that is then consumed by perf stat. This is also more efficient
>> because often the calibration is only needed once. And it's all under
>> user control so no nasty surprises.
>> 
>
> Workload runs only once with perf stat. Perf record is forked by perf stat and run
> in parallel with perf stat. Perf stat will send perf record a signal to terminate after 
> perf stat stops collecting count value.

I don't understand how the perf record filters on the workload created by
the perf stat. At a minimum you would need -p to connect to the pid
of the parent, but IIRC -p doesnt follow children, so if it forked
it wouldn't work.

I think your approach may only work with -a, but perhaps I'm missing
something (-a is often not usable due to restrictions)

Also if perf stat runs in interval mode and you only get the data
at the end how would that work?

iirc i wrestled with all these questions for toplev (which has a
similar feature) and in the end i concluded doing it automatically
has far too many problems.

-Andi