Received-SPF: pass (google.com: domain of linux-kernel+bounces-101064-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 12 Mar 2024 23:07:47 -0400
From: Frank Li <Frank.li@nxp.com>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"peter.chen@kernel.org" <peter.chen@kernel.org>,
	Jun Li <jun.li@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v8 05/10] dt-bindings: usb: ci-hdrc-usb2-imx:
 add restrictions for reg, interrupts, clock and clock-names properties
Message-ID: <ZfEYg1BVTVMGAUJX@lizhi-Precision-Tower-5810>
References: <20240312091703.1220649-1-xu.yang_2@nxp.com>
 <20240312091703.1220649-5-xu.yang_2@nxp.com>
 <20240312145035.GA2204647-robh@kernel.org>
 <DU2PR04MB8822976F9F052E18D7951FA48C2A2@DU2PR04MB8822.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DU2PR04MB8822976F9F052E18D7951FA48C2A2@DU2PR04MB8822.eurprd04.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cdFVkxvAeRw8vMZFHtsc4xAMArMGALauZxe8sR/pabG3BVrvwUVvWaX2Lk5O?=
 =?us-ascii?Q?R90GWXHhKcYlnpgiLu1lmLz7UZtyJxQ4rGnTcK+cHJAGkKOI1P045/WS/2yV?=
 =?us-ascii?Q?bj54n326Mn6zfOwy98TwmGRtehiuxMIygP30am5IvjrjDjaEUMCni8EK9Bi5?=
 =?us-ascii?Q?gpLikAJ+OuSDn7NIX43XGLI5IQKBtMZ4BovyQ7nAPijdxIZsclfsimJP/mJm?=
 =?us-ascii?Q?Qc2HnFPNggQ+EfVMbPMiZynnRZGBBJnLNN70acsrieSgqB0u2vMlylNm/qsT?=
 =?us-ascii?Q?oK59FcVp0gbuGTdjVHuHyYMHkgfj/HVRpf8+YkdViOAOhPGzaqTiNXeI+iNo?=
 =?us-ascii?Q?Zhe0XycXvvtxWcn8RRfiPx/mkA2OEvbP8FErHj/3x2QnuZet8efUQm2c9Q/N?=
 =?us-ascii?Q?HFbHdi0UmWFJu38cXTifC7aZsFz0DsE7d1xrMZ37sTglTXFDnrM7yMaxx9Y+?=
 =?us-ascii?Q?j031aacIUXI2040iH8zoc5H1BhbqXWn32i+ZR9MWT+qaxGdzT+8jRhBoa6uY?=
 =?us-ascii?Q?BAZnP3UJEzJyLYr/Dtvoi/xGRLQralqfBNgRffudd16aJMOfhDKzIYjeWsm5?=
 =?us-ascii?Q?iaMIlkqbT7QJSsOPzh1lZ/ONXsx7MqC1jCbaiKYi7VqSlnp4iv+PR6DUPiHz?=
 =?us-ascii?Q?j+wXTQGHr1pKIvOwLNiE2yJTu4qvbgkflYtTdSqRzZ0LLMA36lVyCgIttXOI?=
 =?us-ascii?Q?u9jT1gfZygsRZXmo/43xpV69LxuL6QBWdRKET6jgKANpF5A1GZu4Ga09MDpE?=
 =?us-ascii?Q?QEzEhf6xGiFhiOtH/knNH86Ba0LV9DIUm6BxTJHyyyotJmeADvvdUIXFi7h/?=
 =?us-ascii?Q?9nXK9XTA88AAdv01iu8ZfmWpWnUk56gOigZyEIvhFRdCpBs7GX4lT4urc6n5?=
 =?us-ascii?Q?XpBvsUzBKvgcdGcqUGzU3rDqlnwZvxrBKW31e/Bc9elv/4vqkqeCLewV8Alx?=
 =?us-ascii?Q?Gh+/ELw120Z3bNZkTa/Qcfu/r7P+1zNCM52fao7F3v5YmVTWZUQY2xdwxHKr?=
 =?us-ascii?Q?pqY/EI29ZxJzJfBaGcjeBD9TnbIECoeeJMv1ebRBVW583OLUfKtuZshDlmK5?=
 =?us-ascii?Q?FWfhdG13QUQ5tKcx6Uz7afp6hcTYTIKUrcEDKnwpkEluNSm+S2WzzGZoQWlF?=
 =?us-ascii?Q?oKGJIIEG4Anw0aUZh2+pp5W07RNRrfFHomz/qBYC/amTbuV2+SVJwMm61iGQ?=
 =?us-ascii?Q?6SysnL100zjPwGCPtnMuSkt9JJi+cVFakuq6IdaFsYkzaz0/WDTQDdxE5YE2?=
 =?us-ascii?Q?2fUFNDcgcIQJ64QgRw7sIAzWFFoCUyv3wXcyBROJ6PXEElk5lOEY3xa6rhYC?=
 =?us-ascii?Q?33BV5Rz+DRPSRgF10npP4Er2U2027goyr/I8iO8u2sd04UoJ7iqcRqW0/eDt?=
 =?us-ascii?Q?HsAm25lvdPRunfDp3m+9kVlb6JymdWwuK7L1Zzz4HaR47Ajfugku5op6wSAs?=
 =?us-ascii?Q?+TuD09FJrTIqQJ98jnBxm5sI+V4MahaMH29YeAMMmSoUmlCkJ+X3ayQ1GDGj?=
 =?us-ascii?Q?QyfljjqDtDRQHkER/LSEL1WPvwdlTW54z1Ab4aZ5741AMW1dnpsgK4Hq5tkJ?=
 =?us-ascii?Q?eqsZP1bNmkvgTQgNaX/ZWTrstZOXXqUzoXLFOsXI?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ef1b783-9229-4de1-5ceb-08dc430ac877
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 03:07:57.3140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mzAK4Uhb2okolClas4YUmYp/4HAIf6OFxb0JqfQb7DE8sL3qrtQfN/H/v5tX2LumYINlUGnq5f8kNWfBF+RV6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8523

On Wed, Mar 13, 2024 at 02:48:00AM +0000, Xu Yang wrote:
> 
> > 
> > On Tue, Mar 12, 2024 at 05:16:58PM +0800, Xu Yang wrote:
> > > Add restrictions for reg, interrupts, clock and clock-names properties
> > > for imx Socs.
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v4:
> > >  - new patch since v3's discussion
> > >  - split the reg, interrupts, clock and clock-names properties into
> > >    common part and device-specific
> > > Changes in v5:
> > >  - keep common property unchanged
> > >  - make if-then more readable
> > >  - remove non imx part
> > > Changes in v6:
> > >  - new patch based on ci-hdrc-usb2-imx.yaml
> > > Changes in v7:
> > >  - no changes
> > > Changes in v8:
> > >  - remove if:else:if:else:if:else block
> > > ---
> > >  .../bindings/usb/chipidea,usb2-imx.yaml       | 80 +++++++++++++++++++
> > >  1 file changed, 80 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > > index cdbb224e9f68..fb1c378dfe88 100644
> > > --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > > @@ -49,6 +49,12 @@ properties:
> > >            - const: fsl,imx6ul-usb
> > >            - const: fsl,imx27-usb
> > >
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  interrupts:
> > > +    maxItems: 1
> > > +
> > >    clocks:
> > >      minItems: 1
> > >      maxItems: 3
> > > @@ -144,6 +150,80 @@ allOf:
> > >              - const: idle
> > >              - const: active
> > >
> > > +  # imx27 Soc needs three clocks
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          const: fsl,imx27-usb
> > > +    then:
> > > +      properties:
> > > +        clocks:
> > > +          minItems: 3
> > > +          maxItems: 3
> > 
> > The max is already 3, so drop maxItems.
> 
> Okay.
> 
> > 
> > > +        clock-names:
> > > +          items:
> > > +            - const: ipg
> > > +            - const: ahb
> > > +            - const: per
> > > +
> > > +  # imx25 and imx35 Soc need three clocks
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            enum:
> > > +              - fsl,imx25-usb
> > > +              - fsl,imx35-usb
> > > +    then:
> > > +      properties:
> > > +        clocks:
> > > +          minItems: 3
> > > +          maxItems: 3
> > 
> > Same here.
> 
> Okay.
> 
> > 
> > > +        clock-names:
> > > +          items:
> > > +            - const: ipg
> > > +            - const: ahb
> > > +            - const: per
> > > +
> > > +  # imx7d Soc need one clock
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          items:
> > > +            - const: fsl,imx7d-usb
> > > +            - const: fsl,imx27-usb
> > > +    then:
> > > +      properties:
> > > +        clocks:
> > > +          maxItems: 1
> > > +        clock-names:
> > > +          maxItems: 1
> > 
> > What's the name?
> 
> Can I not specify the name since the macro definition for USB
> controller clock in clock.h is recognizable and the driver doesn't
> get this clock by name rather index?

If clock-names is not required for fsl,imx7d-usb, 

clock-names: false

If driver use index to get clock, why need clock-names at other platform?
I supposed these should be the same for all chips.

Frank

> 
> Thanks,
> Xu Yang
>