Received-SPF: pass (google.com: domain of linux-kernel+bounces-101074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank Li <frank.li@nxp.com>
CC: Rob Herring <robh@kernel.org>, "gregkh@linuxfoundation.org"
	<gregkh@linuxfoundation.org>, "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "conor+dt@kernel.org" <conor+dt@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de"
	<kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>, "peter.chen@kernel.org"
	<peter.chen@kernel.org>, Jun Li <jun.li@nxp.com>, "linux-usb@vger.kernel.org"
	<linux-usb@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v8 05/10] dt-bindings: usb: ci-hdrc-usb2-imx:
 add restrictions for reg, interrupts, clock and clock-names properties
Thread-Topic: [EXT] Re: [PATCH v8 05/10] dt-bindings: usb: ci-hdrc-usb2-imx:
 add restrictions for reg, interrupts, clock and clock-names properties
Thread-Index: AQHadF4T9fa4/JJRF0KTO2HRURFsjLE0MIuAgAC6gbCAABN3gIAAAmKw
Date: Wed, 13 Mar 2024 03:26:29 +0000
Message-ID:
 <DU2PR04MB8822EBCB6C77F2055D2CF0FD8C2A2@DU2PR04MB8822.eurprd04.prod.outlook.com>
References: <20240312091703.1220649-1-xu.yang_2@nxp.com>
 <20240312091703.1220649-5-xu.yang_2@nxp.com>
 <20240312145035.GA2204647-robh@kernel.org>
 <DU2PR04MB8822976F9F052E18D7951FA48C2A2@DU2PR04MB8822.eurprd04.prod.outlook.com>
 <ZfEYg1BVTVMGAUJX@lizhi-Precision-Tower-5810>
In-Reply-To: <ZfEYg1BVTVMGAUJX@lizhi-Precision-Tower-5810>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ix4S9gIMdtyGwpx02I7uFNlZoa3qMvtpmrIiJQFLap74m7ZIfv8wjfIn6c8U?=
 =?us-ascii?Q?Xm4oJxaUQ1SW5oEeNuyoJivEqme73lLva9d1vz8SlYLwrs16ckGeq6xAMXhH?=
 =?us-ascii?Q?ntZxVM/2JgBTvcHeIa3aWyiXuGwOonn9PEPbPxrhTiZpqVdA8gqO+RC3V1Ni?=
 =?us-ascii?Q?qrroFxtqZwN8oOZIqqis99ibxP/YKIZ38DelMOZzM5C+VxFJWidHlom06gwq?=
 =?us-ascii?Q?jRLcdiv8TZu+Ve3Bp3cZSJuN7bssCDZfpjRbucg2SmzBAIcMvKyAhQrrzAmN?=
 =?us-ascii?Q?2XTzJuxVj1epW00xGGhv4Sztv+FyG7oSKxqMTJSFF0ArlFT31jzfXJ1ZX6Zm?=
 =?us-ascii?Q?boJkA2pi1Z5xmvJ0xHQTgDBavzip/n9YkvipZYIzYOlwx+sBHkwqdUC/pj/I?=
 =?us-ascii?Q?WEFNbEWXUz0Tae7CqQJuLT0pUr4jSAMVi7v+wD50jBrRCoGDgdShF3zs1899?=
 =?us-ascii?Q?IE5NEMnz+WVuzS7SAMSehp7iT5UQpNlF2vDcpPAiqphi4DaTXXha5n/Ktjwq?=
 =?us-ascii?Q?hSZsaYg5gQzr76OgicNpxImOktXGY/ZaUZJTXL2CF0+LmiMm/tb58hzYmztS?=
 =?us-ascii?Q?puUfKW12Yni+1SKuGEvOaUz69mDPHAF1EDaXZK3K3MbuvGQ7Ojn/AmAdPtj/?=
 =?us-ascii?Q?br6q5xE2JZn06CnwvdmdQb2oWqM8CZXV1VbUFKLkkIYAl10mj0quT0GT5/g4?=
 =?us-ascii?Q?IkvhBI45NWs7RJN3Crf3RTHkhYNDi74xkweLBgmPukqg6/d4zcTzaT4HGbkN?=
 =?us-ascii?Q?Hw3UXqRin+9PeOkM8LDdaaJSk4o+c81JNG+Evvt84etv1LIbF5kxQqEUrhQ2?=
 =?us-ascii?Q?cByKge5ze5+RotSvGm2bCekg60rriz8sn0f6GbsQ0EfCHqV54PYQy981+upD?=
 =?us-ascii?Q?cgP3G93iBOJUVU2qWaTomdn626fa4LPXDql9RV4owbcTjAIkeENPG3mK5VuA?=
 =?us-ascii?Q?9IDkewAfRUGseZ5sdRvtdIlgES9tPO0jl47CZrK81dZGVnXHpV6VaH3bXlC8?=
 =?us-ascii?Q?fWjOI1/N+G/8MvnAbiL9Gy1HaBgxC2Zi7qU7Zea25UzJ9cgeOK0+jJ5SxZF0?=
 =?us-ascii?Q?sVqOAwF9qj6Da8/nq0vfDFqKWChNCsHi6SktJcPOcs2aUcKsJf9cSSKh2TF2?=
 =?us-ascii?Q?Rkk/de/BAolg0ZF2Rn9SCmXn3aq5l9xOnLpv8xHE/i3a99eFWec37Byp+wnD?=
 =?us-ascii?Q?F2SKYIwhDiv0/t8lG07nVWlUGMxfJZ6uUvxCKRyEaxCQwGJhd6WUEm8NTpXf?=
 =?us-ascii?Q?QCm5sMSF0JqXM9yQeW7IRmD5SB5gqoBq4D8zdUrkHnCdKS3xq0V4oOT6YvIZ?=
 =?us-ascii?Q?1EfT0RN++N80OcUA+MKCP8Fu7HgOo/AqZZE65esR8/Xy4VDK0rOeVfQjiGEi?=
 =?us-ascii?Q?XpjW3iI3l2JBOJ4nmA0hJkOgDjQw6AoxOUzhV0PvrYjc7PLteMfz2PzAO8ib?=
 =?us-ascii?Q?5kG+YJybK5nzIR/TzgDeuZteQPk5S/G1lDCTfRdjdR/LIZAiQXuPO5SEd642?=
 =?us-ascii?Q?CXccnTSzoxA7twkKVyb0s+Ql2R3czEy5RhelM1/acYnkigXemHhx1TF8I1DE?=
 =?us-ascii?Q?rjP3shUYMN4nVO1XpoA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a53d6ea0-6a03-4c7d-e613-08dc430d5f46
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 03:26:29.1803
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uKoqiD3wPcJwDVaZQBlVxb7746oxo/2U5YMOfx/BEI0fggZHgz89jwxXHcziJsSRWric5xJPUNg/Ysp3Sm/IyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8012


>=20
> On Wed, Mar 13, 2024 at 02:48:00AM +0000, Xu Yang wrote:
> >
> > >
> > > On Tue, Mar 12, 2024 at 05:16:58PM +0800, Xu Yang wrote:
> > > > Add restrictions for reg, interrupts, clock and clock-names propert=
ies
> > > > for imx Socs.
> > > >
> > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > >
> > > > ---
> > > > Changes in v4:
> > > >  - new patch since v3's discussion
> > > >  - split the reg, interrupts, clock and clock-names properties into
> > > >    common part and device-specific
> > > > Changes in v5:
> > > >  - keep common property unchanged
> > > >  - make if-then more readable
> > > >  - remove non imx part
> > > > Changes in v6:
> > > >  - new patch based on ci-hdrc-usb2-imx.yaml
> > > > Changes in v7:
> > > >  - no changes
> > > > Changes in v8:
> > > >  - remove if:else:if:else:if:else block
> > > > ---
> > > >  .../bindings/usb/chipidea,usb2-imx.yaml       | 80 +++++++++++++++=
++++
> > > >  1 file changed, 80 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-im=
x.yaml
> > > b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > > > index cdbb224e9f68..fb1c378dfe88 100644
> > > > --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > > > +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml
> > > > @@ -49,6 +49,12 @@ properties:
> > > >            - const: fsl,imx6ul-usb
> > > >            - const: fsl,imx27-usb
> > > >
> > > > +  reg:
> > > > +    maxItems: 1
> > > > +
> > > > +  interrupts:
> > > > +    maxItems: 1
> > > > +
> > > >    clocks:
> > > >      minItems: 1
> > > >      maxItems: 3
> > > > @@ -144,6 +150,80 @@ allOf:
> > > >              - const: idle
> > > >              - const: active
> > > >
> > > > +  # imx27 Soc needs three clocks
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          const: fsl,imx27-usb
> > > > +    then:
> > > > +      properties:
> > > > +        clocks:
> > > > +          minItems: 3
> > > > +          maxItems: 3
> > >
> > > The max is already 3, so drop maxItems.
> >
> > Okay.
> >
> > >
> > > > +        clock-names:
> > > > +          items:
> > > > +            - const: ipg
> > > > +            - const: ahb
> > > > +            - const: per
> > > > +
> > > > +  # imx25 and imx35 Soc need three clocks
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            enum:
> > > > +              - fsl,imx25-usb
> > > > +              - fsl,imx35-usb
> > > > +    then:
> > > > +      properties:
> > > > +        clocks:
> > > > +          minItems: 3
> > > > +          maxItems: 3
> > >
> > > Same here.
> >
> > Okay.
> >
> > >
> > > > +        clock-names:
> > > > +          items:
> > > > +            - const: ipg
> > > > +            - const: ahb
> > > > +            - const: per
> > > > +
> > > > +  # imx7d Soc need one clock
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          items:
> > > > +            - const: fsl,imx7d-usb
> > > > +            - const: fsl,imx27-usb
> > > > +    then:
> > > > +      properties:
> > > > +        clocks:
> > > > +          maxItems: 1
> > > > +        clock-names:
> > > > +          maxItems: 1
> > >
> > > What's the name?
> >
> > Can I not specify the name since the macro definition for USB
> > controller clock in clock.h is recognizable and the driver doesn't
> > get this clock by name rather index?
>=20
> If clock-names is not required for fsl,imx7d-usb,
>=20
> clock-names: false

Set it to false make sense to me.

>=20
> If driver use index to get clock, why need clock-names at other platform?
> I supposed these should be the same for all chips.

Yes, they are same. I add clock-names because some dts already have
clock-names in the usb node.=20
If I set it to false, I should remove clock-names from these platforms in
next version.

Thanks,
Xu Yang