Received-SPF: pass (google.com: domain of linux-kernel+bounces-101081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240312-gcc-plugins-gmp-v1-0-c5e082437b9e@linutronix.de>
 <20240312-gcc-plugins-gmp-v1-2-c5e082437b9e@linutronix.de> <202403121452.701C91AF6E@keescook>
In-Reply-To: <202403121452.701C91AF6E@keescook>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Wed, 13 Mar 2024 12:47:59 +0900
Message-ID: <CAK7LNAQ=aSqUUStN_M8QVqeS9R1QVM5CPq7=kzpY0z060XJFDA@mail.gmail.com>
Subject: Re: [PATCH 2/2] gcc-plugins: disable plugins when gmp.h is unavailable
To: Kees Cook <keescook@chromium.org>
Cc: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>, 
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-kbuild@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 6:53=E2=80=AFAM Kees Cook <keescook@chromium.org> w=
rote:
>
> On Tue, Mar 12, 2024 at 04:03:30PM +0100, Thomas Wei=C3=9Fschuh wrote:
> > The header gmp.h is meant to be picked up from the host system.
> >
> > When it is unavailable the plugin build fails:
> >
> > In file included from ../crosstools/gcc-13.2.0-nolibc/i386-linux/bin/..=
/lib/gcc/i386-linux/13.2.0/plugin/include/gcc-plugin.h:28,
> >                  from ../scripts/gcc-plugins/gcc-common.h:7,
> >                  from ../scripts/gcc-plugins/stackleak_plugin.c:30:
> > ../crosstools/gcc-13.2.0-nolibc/i386-linux/bin/../lib/gcc/i386-linux/13=
2.0/plugin/include/system.h:703:10: fatal error: gmp.h: No such file or di=
rectory
> >   703 | #include <gmp.h>
> >       |          ^~~~~~~
> >
> > Signed-off-by: Thomas Wei=C3=9Fschuh <thomas.weissschuh@linutronix.de>
> > ---
> >  scripts/gcc-plugins/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/gcc-plugins/Kconfig b/scripts/gcc-plugins/Kconfig
> > index e383cda05367..a664fb5cdde5 100644
> > --- a/scripts/gcc-plugins/Kconfig
> > +++ b/scripts/gcc-plugins/Kconfig
> > @@ -10,6 +10,7 @@ menuconfig GCC_PLUGINS
> >       depends on HAVE_GCC_PLUGINS
> >       depends on CC_IS_GCC
> >       depends on $(success,test -e $(shell,$(CC) -print-file-name=3Dplu=
gin)/include/plugin-version.h)
> > +     depends on $(host-cc-option,-include gmp.h)
>
> Why does the prior depends not fail? That's where plugin detection is
> happening.
>
> --
> Kees Cook
>


This patch set should be rejected.


It was already discussed in the past.
Just install a proper package, then gcc-plugin will work.

https://lore.kernel.org/all/CAHk-=3DwjjiYjCp61gdAMpDOsUBU-A2hFFKJoVx5VAC7yV=
4K6WYg@mail.gmail.com/


--=20
Best Regards
Masahiro Yamada