Received-SPF: pass (google.com: domain of linux-kernel+bounces-101123-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <0971ac51-f823-4338-ba95-3ceced9d2a1c@quicinc.com>
Date: Wed, 13 Mar 2024 11:05:27 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI
 mode
Content-Language: en-US
To: Andi Shyti <andi.shyti@kernel.org>
CC: <konrad.dybcio@linaro.org>, <andersson@kernel.org>, <vkoul@kernel.org>,
        <wsa@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-i2c@vger.kernel.org>, <quic_vdadhani@quicinc.com>,
        Stephen Rothwell
	<sfr@canb.auug.org.au>
References: <20240307205539.217204-1-quic_msavaliy@quicinc.com>
 <a5oiihch2yqsosq337hogqzd3r4ldgfrzub4m6kofheh2k3qjv@wxageydv4q37>
From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
In-Reply-To: <a5oiihch2yqsosq337hogqzd3r4ldgfrzub4m6kofheh2k3qjv@wxageydv4q37>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andi, Wolfram,

On 3/12/2024 4:19 PM, Andi Shyti wrote:
> Hi Mukesh,
> 
>> +	status = FIELD_GET(I2C_DMA_TX_IRQ_MASK, i2c_res->status);
> 
> This fails here:
> 
> drivers/i2c/busses/i2c-qcom-geni.c: In function 'i2c_gpi_cb_result':
> drivers/i2c/busses/i2c-qcom-geni.c:493:18: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
>    493 |         status = FIELD_GET(I2C_DMA_TX_IRQ_MASK, i2c_res->status);
>        |                  ^~~~~~~~~
> cc1: all warnings being treated as errors
> 
> I will remove this patch from the i2c/i2c-host and we will need
> to wait for the next merge window to get this through.
> 
> Please submit v4 with the Cc list recommended by Wolfram.
>Submitted V4 patch. Let me wait for the dmaengine maintainers to sig off 
too. Sorry for the trouble.

> Thanks,
> Andi
>