Received-SPF: pass (google.com: domain of linux-kernel+bounces-101230-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240313054409.8073-1-zhi.mao@mediatek.com>
In-Reply-To: <20240313054409.8073-1-zhi.mao@mediatek.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 13 Mar 2024 10:52:39 +0200
Message-ID: <CAHp75VeHVJpiaCTdQHWQocE9PFLsGhu+a2TP7VSV34i02v-ksA@mail.gmail.com>
Subject: Re: [PATCH 0/2] media: i2c: Add support for GC05A2 sensor
To: Zhi Mao <zhi.mao@mediatek.com>
Cc: mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, 
	sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, 
	shengnan.wang@mediatek.com, yaya.chang@mediatek.com, 
	Project_Global_Chrome_Upstream_Group@mediatek.com, yunkec@chromium.org, 
	conor+dt@kernel.org, matthias.bgg@gmail.com, 
	angelogioacchino.delregno@collabora.com, jacopo.mondi@ideasonboard.com, 
	10572168@qq.com, hverkuil-cisco@xs4all.nl, heiko@sntech.de, 
	jernej.skrabec@gmail.com, macromorgan@hotmail.com, linus.walleij@linaro.org, 
	hdegoede@redhat.com, tomi.valkeinen@ideasonboard.com, 
	gerald.loacker@wolfvision.net, bingbu.cao@intel.com, 
	dan.scally@ideasonboard.com, linux-media@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 7:54=E2=80=AFAM Zhi Mao <zhi.mao@mediatek.com> wrot=
e:
>
> This series adds YAML DT binding and V4L2 sub-device driver for Galaxycor=
e's
> GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2 image =
data
> interface and the I2C control bus.
>
> The driver is implemented with V4L2 framework.
>  - Async registered as a V4L2 sub-device.
>  - As the first component of camera system including Seninf, ISP pipeline=
.
>  - A media entity that provides one source pad in common.
>  - Used in camera features on ChromeOS application.
>
> Also this driver supports following features:
>  - manual exposure and analog gain control support
>  - vertical blanking control support
>  - test pattern support
>  - media controller support
>  - runtime PM support
>  - support resolution: 2592x1944@30fps, 1280x720@60fps

Not even going to do a thorough review as one should learn on the
previous reviews. Most of the comments that I had given to another
driver submission are applicable here. So, waiting for v2 with all
applicable being addressed.

--=20
With Best Regards,
Andy Shevchenko