Received-SPF: pass (google.com: domain of linux-kernel+bounces-101238-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 13 Mar 2024 10:00:56 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>, 
	Masahiro Yamada <masahiroy@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, 
	Nicolas Schier <nicolas@fjasle.eu>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, 
	Linux Next Mailing List <linux-next@vger.kernel.org>, linux-kbuild@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the mm tree
Message-ID: <psaj3nztnhcxiwjnie3bbpsn7efcsxp3yx3mh54uello22773v@fw5qpqs4gh2i>
References: <20240313150728.12e20208@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2zmul7e526qlrp5s"
Content-Disposition: inline
In-Reply-To: <20240313150728.12e20208@canb.auug.org.au>


--2zmul7e526qlrp5s
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 03:07:28PM +1100, Stephen Rothwell wrote:
> Hi all,
>=20
> After merging the mm tree, today's linux-next build (powerpc allyesconfig)
> produced this warning:
>=20
> Use of uninitialized value $ENV{"abs_srctree"} in concatenation (.) or st=
ring at /home/sfr/next/next/lib/build_OID_registry line 38.
>=20
> Introduced by commit
>=20
>   325f7b0aaea6 ("lib/build_OID_registry: Don't mention the full path of t=
he script in output")
>=20
> from the mm-nonmm-unstable branch of the mm tree.

Actually the warning doesn't happen on 325f7b0aaea6. The commit is only
problematic in combination with commit

	e2bad142bb3d ("kbuild: unexport abs_srctree and abs_objtree")

=2E This commit suggests to use $(abspath ) or $(realpath ) instead, but I
fail to apply this suggestion here.

Obviously

diff --git a/Makefile b/Makefile
index 5e09b53b4850..f73a73a125e0 100644
--- a/Makefile
+++ b/Makefile
@@ -39,7 +39,7 @@ __all:
 # prepare rule.
=20
 this-makefile :=3D $(lastword $(MAKEFILE_LIST))
-abs_srctree :=3D $(realpath $(dir $(this-makefile)))
+export abs_srctree :=3D $(realpath $(dir $(this-makefile)))
 abs_objtree :=3D $(CURDIR)
=20
 ifneq ($(sub_make_done),1)

would help.

Any ideas how to properly handle that? Would the export be ok?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--2zmul7e526qlrp5s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXxa0cACgkQj4D7WH0S
/k4L0wgAtFXvi2SKrUZSJkChbQc1i9RRgfE3LyGWBx4rp7IFLOOG1uy8DLMZU9RV
neRZjELj/yIOMwudxBzN//rSvt1Fyg1uwo1F7UEZp2F6AxDoBdH98lCTPTdebALP
8E/rbz4sNjtoadzN+4DascK4hlZSbKCDXkk8YPgR/K/uugB+izgJ1P22tcLu5HIP
rR75ToEKmb6tBHa9lILH5o5uoOtZN/8PjcWZjevhFpQIFQmJLnitnJRQjoyrZDEE
I5f4QBUgL9uwi/FCJVv5TF5CONmqkumagjJ9OaszUxuYEcxW+ANWQAwvzTDH+MTW
6vy9QAnixJkgJV8qKZ6bOYGaST3N+A==
=HkV0
-----END PGP SIGNATURE-----

--2zmul7e526qlrp5s--