Received-SPF: pass (google.com: domain of linux-kernel+bounces-101330-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 13 Mar 2024 11:15:30 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC: <linux-kselftest@vger.kernel.org>, Reinette Chatre
	<reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, Fenghua Yu <fenghua.yu@intel.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/13] selftests/resctrl: Add ->init() callback into
 resctrl_val_param
Message-ID: <zxrd5yzgtbet3d42c77ifgu5t2guyhwbz76zhk7zhrp6hnamrb@pl72dxisxax6>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com>
 <20240311135230.7007-9-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240311135230.7007-9-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?uIwNe/V/wiYRLKCJBgphlQACX9kWMP/sEH8Bt/2yJPzQa8/Jw4ze2lQJDq?=
 =?iso-8859-1?Q?ZLQMMp0+f6E/tN7P0ciKxeVH60g0xvzhGMwrOuQC2fms6Gppd0juDN2Q3t?=
 =?iso-8859-1?Q?LJti0sl7FLsNEpNAyu87ifNyv1RQrMEOLGfRONMdDAI3lCU6EEfLNc9DFZ?=
 =?iso-8859-1?Q?h8O8eEUcVHdN8exvV9Flt4wnw9j7f2l7RpT8unO15DpGxXYOQ2d3T47DYO?=
 =?iso-8859-1?Q?23O4flP0wGmuSHFIoCdO0M38BgqEc0W6lK/cbEDeh90PgNVurLMWw6hkqX?=
 =?iso-8859-1?Q?ivye/BQLvaR18wAi/ouiI2Wa+LUiHEjxbvyLvws1ZUcjLc1nrBldZZoRwO?=
 =?iso-8859-1?Q?JCgH0c7CPS9zZOcMQVHJLfDRC7mHGxEwkaU5OK9v9il1fNWKolUIN2wyBw?=
 =?iso-8859-1?Q?sn+tVrF7gvemIiZfwmOUaOoLrbaL38/JXmsTUzCwi/M5zICMn/FSnDO4kK?=
 =?iso-8859-1?Q?bu4bnR0jWhW0VQ5Wc+s4YloSW90AV25SnH0eKf9//h5YS4+3NtE/ArHo/K?=
 =?iso-8859-1?Q?pkXwL+cg6xfXfmqlGYoBkZYWxu+08OthaXzj+FxlMPm6uHQiNyPvXVXVyZ?=
 =?iso-8859-1?Q?0rf6dWIkG1VJ/IqayrOMDXBdPY6WfPDQgZ3BI29VyLXrH2uVpuXejf6ETC?=
 =?iso-8859-1?Q?jHcz7QlX8FFsfwy3DZWASkaX3eJy82Y1X0wXqT5OB6U5eRaTMJwIhExeIu?=
 =?iso-8859-1?Q?ihGfuT2RSXwJzd96U4EtQPzga9bz/gqvn7E522SWca5P5Kc0Ly4xsTa9TF?=
 =?iso-8859-1?Q?vUsscQHts3aXApnyodUHJndg7/1p8WNPdKHX5ovbz+ycCkmMdanX3LLsQ9?=
 =?iso-8859-1?Q?UXMK/y0x+RcF2I5xaOStc0BVmZIb8dRY7M1Glb2iRtjBWGYpjYyaGGSiJE?=
 =?iso-8859-1?Q?tLIdsIy9u6KOFXZfDoNTL4FsbJAXe9I1ElDKJ3rkqgQjX0o4HNYW1zA8RM?=
 =?iso-8859-1?Q?ynvvSfjAP/v65sNekKpyiVXxRgG1NdhTUuENg2sO49ONtMjoNjGIPwSFLr?=
 =?iso-8859-1?Q?R3Ca723gPnscBu2uDV6MVs3t+xpmpNb6BuNJfLHf076BsvaEropp88TbCh?=
 =?iso-8859-1?Q?Y0pSpg82lJHzlOAuUE/84hWSgszEgK82VXUlczP0dZIkJTONl/+/VoI+tN?=
 =?iso-8859-1?Q?717c19ith+mJIMIGSQ3+WxiSj/L6CZafU+CYVApuULKJ07qLRworW2gIhf?=
 =?iso-8859-1?Q?664mVYoaxj2NK/liWXOzbjrqUkaj6sfvJ34njaWfmeg/3cv1f0wMi0J/ov?=
 =?iso-8859-1?Q?KkFZJgk/8pSLcEM97GD3neM0atIUE6fpEn1HhkMb4Wh6WPr6xGjwO4gqqY?=
 =?iso-8859-1?Q?heLa8SXEUqqcmru9Z+zpACfEh0gQc5IL2+xHnxWO84VTzQHWnuL9qbCdCM?=
 =?iso-8859-1?Q?BOZuz6GZUg/CyEanIrhSe9yZxlcslSovsgMRv/vLi8X9ChK/S6nWOe56Ua?=
 =?iso-8859-1?Q?pMxNYCFddDurM3SKndxGXLpKGyAEyTE/HC8P4qIINAtPJ1a74kFjXkdYi8?=
 =?iso-8859-1?Q?mQk65D6YAa7mFGiY8G1n8QEGDpH8xtJmtgn27XoZAQgXFflew3H+KZ0yjC?=
 =?iso-8859-1?Q?WCLaOEj4ot+ZQUMgMFkNswzXbpShKQpsAe9eD1YZkyN/ZUSxLIO7T2m1Az?=
 =?iso-8859-1?Q?t+V8bgOTYN017fLrEh014wQv+u1qeWH/04CB3ZD4qnN+nxwNX0h9s1AzRh?=
 =?iso-8859-1?Q?mo9N4DP3mvGKHHAQcZY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce51d96-9354-45a1-55b2-08dc4346893e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 10:15:41.0551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lc+ma8lIHSgshUNgi1W06I9NSz9WW9+MMjpzb6JAmj8gInZrEOSbe6pdMHW8D+onjhrf0E4offvDwFgXFkZ/wO6XiLo3pFcLf2Bw37brkS8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6405
X-OriginatorOrg: intel.com

Hi,

On 2024-03-11 at 15:52:25 +0200, Ilpo J?rvinen wrote:
>diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
>index 241c0b129b58..e79eca9346f3 100644
>--- a/tools/testing/selftests/resctrl/cmt_test.c
>+++ b/tools/testing/selftests/resctrl/cmt_test.c
>@@ -16,6 +16,17 @@
> #define MAX_DIFF		2000000
> #define MAX_DIFF_PERCENT	15
> 
>+#define CON_MON_LCC_OCCUP_PATH		\
>+	"%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/llc_occupancy"
>+
>+static int set_cmt_path(const struct resctrl_val_param *param, int domain_id)
>+{
>+	sprintf(llc_occup_path,	CON_MON_LCC_OCCUP_PATH,	RESCTRL_PATH,
>+		param->ctrlgrp, param->mongrp, domain_id);
>+
>+	return 0;
>+}
>+

Is there an option to make this function (and the set_mbm_path()) global through
the resctrl.h?

I'd like to use it in my SNC series [1] for looping over different nodes and
that requires changing the paths during the measure phase of the tests and that
part is currently in cache.c:measure_llc_resctrl().

Or would you suggest some other way of changing these paths in cache?

-- 
Kind regards
Maciej Wiecz?r-Retman