Received-SPF: pass (google.com: domain of linux-kernel+bounces-101347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 13 Mar 2024 11:26:58 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Reinette Chatre
	<reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>,
	<tony.luck@intel.com>, "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 3/4] selftests/resctrl: SNC support for MBM
Message-ID: <jue4sarmmgp7i2vtx2kc5xmngp7oav6nihijvj4pkgpf5swz3k@mapj4w3vnq3m>
References: <cover.1709721159.git.maciej.wieczor-retman@intel.com>
 <def02de22a4747ed56ddc28f334e55872ba95f13.1709721159.git.maciej.wieczor-retman@intel.com>
 <37bd082c-a187-43de-892b-c5fa32a8b3f2@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <37bd082c-a187-43de-892b-c5fa32a8b3f2@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Pw8KlkJIQb1qzohZFQW9Ztct9RiaFJ6Ik2KmJk/gdazHj+r+kS1Zhew3Sf?=
 =?iso-8859-1?Q?Weav1658S8PmrWzjZZEa0tCFUxW9WzaxmW9ctgPP+eeaphjoLMTRkpJtqk?=
 =?iso-8859-1?Q?8S8Jqd5/7tJcs+MXOjE2Qi0/7UpS2YzfsBUDgRZjEa4I3ZpFXfOphJpXGZ?=
 =?iso-8859-1?Q?0jpoBHnYs+Bu0nagyrtNYYRpAYEzKtGCaXMMFFHFq0ocA4EP1oQSitbu1F?=
 =?iso-8859-1?Q?lZbjvQsfiAWt3QS+vqOy5Kw8pJq5cuYF3u7XZeH8Q2mMmTsbsSBVYupe2q?=
 =?iso-8859-1?Q?DlHjb3033bWn4tDl2ZL4nNLztqbE1enpgTahrLJBq8AthupOdDz//v/yVZ?=
 =?iso-8859-1?Q?95E35eEGomvbNo6sT7Xzme16owW8H1yiWBAovA0f3LuXVcjxQ4Ge2M06T7?=
 =?iso-8859-1?Q?NeRtJ3qP/jBeXD6ys5JouWLzTJqnaOB1mF+01miImuRduXd9mzhEe5FrD0?=
 =?iso-8859-1?Q?tEVGedfqMMVJiW8/ydzl0RnK4bSMOFd0bhk0N7CTQd4x7YeBfHGn6C4xqP?=
 =?iso-8859-1?Q?Dd8UCIA/iZEvSb5qRzdJ2WOr2sWV6SHqnZIzXd9fUzDHz8W+HkD6b/go2L?=
 =?iso-8859-1?Q?jXtIueAVtZ+a2azNIWwkRRaWqQ4sA8OyTECCqVEXT8UPb0mOxJ++KzZUwL?=
 =?iso-8859-1?Q?UDqw/5A1Q28F7dGG9Cqx3xfykCOj6N2o3aqOj2IOFlM8Sw2HiqfZ5+IZfe?=
 =?iso-8859-1?Q?MmavqUdPZ7rAT6zDQC3xkMEWtE0JevPU9oC7UCVhHegWOfnjpZk8V77t56?=
 =?iso-8859-1?Q?QqrCp8+HG4e1jtTYAfDAS1Qgh9DRUjWCJjPTiaIJ8UTCWlAbXz8rkOxJuf?=
 =?iso-8859-1?Q?R6MpWfT5VYA4CS7h5Ssnyeeyr35MilFSJdT0PmejmsvN57RKcX7v+37/L4?=
 =?iso-8859-1?Q?pbh5cy72Pzov5N+vJIA/1vPBf0aEo8WB1g3QVf2/w6xTdvvoibsupZ6uHq?=
 =?iso-8859-1?Q?2CEpOOVuTadybGWXRnpS+0qcqNo7Sj6DcvXSd3IUWrA7b8n6q3JM7MEE8g?=
 =?iso-8859-1?Q?GP+6XWQQFe6gaPYsyemB4lYhDPImVCxbpUT4/Frz3eZgV9QoYk8/aq0Avz?=
 =?iso-8859-1?Q?T8umNDViaHAIxGNiSeFV7Fc1A6G4BHA/mpofpHo25ICjWmVt/QuGhMbEf1?=
 =?iso-8859-1?Q?P0n9Px9gFiNO7GMQgjHFMuJM54vHdEZR2ss4bKebufC0gD25chQ5bounJh?=
 =?iso-8859-1?Q?FzZKZ98CI2FqDNBXA1TE/AtHbmslBy+eO/DpfDrvvwF/QZDoftEzeMB0QH?=
 =?iso-8859-1?Q?KmrcOg3YO8bR0LMttP3gzUHh7sMWRjp4gI075ldDSDKF4FOe/B6X8y4F/C?=
 =?iso-8859-1?Q?qprx9V7/MEYoUkb//n/7FO9GxWYRE9MOgcMsxJKER1Mi3HajBfnKZvirDV?=
 =?iso-8859-1?Q?6yych6+uhXzJO9Fdf8NuGvYmHYJT300fe8HGFZcDz7rv0r+zQj2hHXlcFN?=
 =?iso-8859-1?Q?0SHN9RyAPEsFvi9USi9ffB6L1RRWfL82YBJHqUVtBZtQGG16dKXO9Ljzcb?=
 =?iso-8859-1?Q?TD1qSLo//nqDY0M28e43n5inUwAvL48hBwPuCrPu9jNqo46OimXA9qg3H3?=
 =?iso-8859-1?Q?+WeICT7lo34Mic6p4COz4WI7TyOoKUJv9EHWo8GTNMivIUb2e8X9M/pPPA?=
 =?iso-8859-1?Q?IYiXjy8NjRrEYLoA2W8cjCjpMRWZ5pDvMNNc+Sx0U8vJDFsd2NqUVS9hjj?=
 =?iso-8859-1?Q?gM02o+9HjVfJtooL9RM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: da64014b-c2ba-44cc-1dbc-08dc434823b9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 10:27:09.7194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4fgvql4/aTg8Sq20LZygtEQY0RSmI3Ln+BDkgcWxvGjpGm3wSGW/YSYQtUKyCJyqzEvk+Q0lwXaikHDvacjf9Tp2xs9K0CdnhuKvTb6YIek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6395
X-OriginatorOrg: intel.com

On 2024-03-08 at 16:07:05 +0200, Ilpo J?rvinen wrote:
>On Wed, 6 Mar 2024, Maciej Wieczor-Retman wrote:
>> @@ -697,12 +700,16 @@ int resctrl_val(const struct resctrl_test *test,
>>  		struct resctrl_val_param *param)
>>  {
>>  	char *resctrl_val = param->resctrl_val;
>> -	unsigned long bw_resc_start = 0;
>>  	int res_id, ret = 0, pipefd[2];
>> +	unsigned long *bw_resc_start;
>>  	struct sigaction sigact;
>>  	char pipe_message = 0;
>>  	union sigval value;
>>  
>> +	bw_resc_start = calloc(snc_ways(), sizeof(unsigned long));
>
>While correct, this seems a bit overkill given is MAX_SNC = 4, not 
>something large or unbounded.
>
>This patch would be be much simpler on top of my resctrl_val() cleanup 
>patches because bw_resc_start is only local to the measurement function.

You're right, the series will get a lot simpler rebased onto yours. I'll try out
some different approaches and comment any relevant points under your thread [1].

[1] https://lore.kernel.org/all/20240311135230.7007-1-ilpo.jarvinen@linux.intel.com/

>
>-- 
> i.

-- 
Kind regards
Maciej Wiecz?r-Retman