Received-SPF: pass (google.com: domain of linux-kernel+bounces-101351-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 13 Mar 2024 11:28:19 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC: <linux-kselftest@vger.kernel.org>, Reinette Chatre
	<reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, Fenghua Yu <fenghua.yu@intel.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/13] selftests/resctrl: Add ->init() callback into
 resctrl_val_param
Message-ID: <vzluzxmks6bqfszwoib72ufbanxucxk5xzilavp3wrwoh7fqxh@rugv6wcptofu>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com>
 <20240311135230.7007-9-ilpo.jarvinen@linux.intel.com>
 <zxrd5yzgtbet3d42c77ifgu5t2guyhwbz76zhk7zhrp6hnamrb@pl72dxisxax6>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <zxrd5yzgtbet3d42c77ifgu5t2guyhwbz76zhk7zhrp6hnamrb@pl72dxisxax6>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?5mqAf8fJgSse74xu48DmfBmqaRNHPRs4D5/zv9DAebHdBebLH4htBM6PTt?=
 =?iso-8859-1?Q?MsKRIykBmhHcCvaJ5jXbpB+c9r5VHbPy02UGJK03UdNMDj9GNcaJ4z+VUN?=
 =?iso-8859-1?Q?X7VFAMyABZ96R2Tj8KFGZ6na4QU1KrvIJQ6AjeVkkMvzrOCg5iM0INaKoV?=
 =?iso-8859-1?Q?jvH7shcwUHXOJ9E/ZVFgZNO5P8XiFobQOskvkuU6C5bhMpb817I6wn1RMG?=
 =?iso-8859-1?Q?jbQDm4YVxfX/La0GBuMZzCqxEAaSlNhSHa+WUvkN1PUX+bL2TUT4mlX5UW?=
 =?iso-8859-1?Q?SM5ImHl80wNDyx6Bih2jFDSAdYKSx8LreBfAZYJ3s8w7lv0XPdq9hK5uKP?=
 =?iso-8859-1?Q?TsjtFtQBl8tImZ5TXTyExcX4nC4xH2nTGPrTsZsENomAOxeCk6Q/WbNTtK?=
 =?iso-8859-1?Q?LSPpxGGAGPTkvX08UYor2SdxDbdQO33AxMGmBOxq6KIzOB0/WySRA5Sdby?=
 =?iso-8859-1?Q?P8MW4ZyBNULjyRD+S8XLo7f6JdnrZBBSAtDpNxBo5T5U8d2ISjxafii6UD?=
 =?iso-8859-1?Q?A7/kHI+PC4uYXX8knJpXNDl7vlE+AKdoIT7DQdmzVYXyORuaium7/7a+kk?=
 =?iso-8859-1?Q?5T0V1ChAYkkoF3Fx9gu+JbmSldlXqDyklDrB+kHQH31Gi0JXOMHQWVfTZX?=
 =?iso-8859-1?Q?0kTJbDSulUyEOyZlYcjMgbcY6ZIkXyOkdvAYSJKedd478TgrOQjONKJbCe?=
 =?iso-8859-1?Q?8LoxeB2ACVI7tb6r3F2xRbzmXa6G1bTZSI+ZL0xQnvxpEvjktNefAEs5rn?=
 =?iso-8859-1?Q?mNn3FwLWrQCZ21lOGHFqT7BPCJRbruD4wzO5ZuiaqXS3Q/VY2zBLdE1i4l?=
 =?iso-8859-1?Q?SySPx1MBj2UIdCZaX88ICM0FTdnMRVnv6K5UTP62zpyt38xn+3gmkNZerl?=
 =?iso-8859-1?Q?aLN02sfkEDtUU1npn5TCK1OxAaBjRIKQYrcNmXR44nuNFABDJCYDH3WiFw?=
 =?iso-8859-1?Q?3XqrRrDkvap4jzdN/YyP5IypGbXI5sCHTiZ8AdZLwqDCDGv+q4OQA7zbQO?=
 =?iso-8859-1?Q?O1fBlbFfXVzCOh27mWPDvUvOGDYm341vfJeEBbbOkv5DvcGNxBGrqB3vCe?=
 =?iso-8859-1?Q?0/1rGvy7JD/rNEkRgkqiCmLWWyf9SNtB+J7LaJG8Y5MB71MLITSYHGfvZc?=
 =?iso-8859-1?Q?psE+KsHZNv9qfI7uBnamI3uGWS3cYJYAY1fr7QwGw6TYwYv5SXh2QDmtXw?=
 =?iso-8859-1?Q?LtqyROb0jsZv4Df47tJkyqAnjOEDfSXhGmUxpj/8bep2YWJ+w649gJnNFD?=
 =?iso-8859-1?Q?lD7l9Ucqic1eVop/NRPk/pZZ2wHk3t5v7mpEh6ZLAw2pwEwYJ7KlOsGB9M?=
 =?iso-8859-1?Q?hO7csvPSQs36fhEj+2pLC52ULIJgsDu+SoQS1c9ncD/TRPzNSdsyus452m?=
 =?iso-8859-1?Q?k69WpnTf9LTyWxvyFsrwq0ZmGl4xCfqgPghPzNpLkDOYnLotCJuBQdP0bT?=
 =?iso-8859-1?Q?SLYh0GtT0AErYtufVBxPo8QTEMj6Y1bv1q/bJjgfV6NI3MwROnjmlqSQ+p?=
 =?iso-8859-1?Q?e4dJsYC+Mjy4pRiJLEyUwyprDYRkGjpSmNEshvhUR+qKUrHZojVFfpQ/Eh?=
 =?iso-8859-1?Q?OUFsWKKBqmYYjBpK92vnu6nr9vtEHXGQdpV8d0kk/HydiIwoDNXHeePi4E?=
 =?iso-8859-1?Q?gzQF+gXVGaYNLKiOSIWYQU7U2D5RXqIFpQnEMjZviE1LZaZmp4QIXdJZom?=
 =?iso-8859-1?Q?ev6PnbAan/eIuk2t6rE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 86f2c51a-93b8-44e8-cb31-08dc434853f5
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6239.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 10:28:31.5278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oSel23LJAAYbL9nUO8JaID5hcT+ClKMZyGg1KAUZrwIykZMz8rqkkIJtE8+DFDDqdrVbQU9uZNsmIcfF4Q3ZzwgrgxctM1n799mZFcmCKGI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6395
X-OriginatorOrg: intel.com

On 2024-03-13 at 11:15:30 +0100, Maciej Wieczor-Retman wrote:
>Hi,
>
>On 2024-03-11 at 15:52:25 +0200, Ilpo J?rvinen wrote:
>>diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
>>index 241c0b129b58..e79eca9346f3 100644
>>--- a/tools/testing/selftests/resctrl/cmt_test.c
>>+++ b/tools/testing/selftests/resctrl/cmt_test.c
>>@@ -16,6 +16,17 @@
>> #define MAX_DIFF		2000000
>> #define MAX_DIFF_PERCENT	15
>> 
>>+#define CON_MON_LCC_OCCUP_PATH		\
>>+	"%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/llc_occupancy"
>>+
>>+static int set_cmt_path(const struct resctrl_val_param *param, int domain_id)
>>+{
>>+	sprintf(llc_occup_path,	CON_MON_LCC_OCCUP_PATH,	RESCTRL_PATH,
>>+		param->ctrlgrp, param->mongrp, domain_id);
>>+
>>+	return 0;
>>+}
>>+
>
>Is there an option to make this function (and the set_mbm_path()) global through
>the resctrl.h?
>
>I'd like to use it in my SNC series [1] for looping over different nodes and
>that requires changing the paths during the measure phase of the tests and that
>part is currently in cache.c:measure_llc_resctrl().
>
>Or would you suggest some other way of changing these paths in cache?
>

+forgot to add the link :b

[1] https://lore.kernel.org/all/cover.1709721159.git.maciej.wieczor-retman@intel.com/

-- 
Kind regards
Maciej Wiecz?r-Retman