Received-SPF: pass (google.com: domain of linux-kernel+bounces-101368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 13 Mar 2024 11:43:54 +0100
From: Michal Kubiak <michal.kubiak@intel.com>
To: Duanqiang Wen <duanqiangwen@net-swift.com>
CC: <netdev@vger.kernel.org>, <mengyuanlou@net-swift.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <maciej.fijalkowski@intel.com>, <andrew@lunn.ch>,
	<wangxiongfeng2@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: txgbe: fix clk_name exceed MAX_DEV_ID limits
Message-ID: <ZfGDai79gJ2IGA1O@localhost.localdomain>
References: <20240313080634.459523-1-duanqiangwen@net-swift.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240313080634.459523-1-duanqiangwen@net-swift.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OeTedRERXgGtTQQszC2p90dgorM2wGBKEbRRp3wp1YVGgiTcjAwnoWJPstRZ?=
 =?us-ascii?Q?HD7TEkGBFthnkayreoNonLfaUT15LeLmBpoh5A28IwFzo0XMm3B5lmbrMr2i?=
 =?us-ascii?Q?CpEpgJFQ4EMwAkxUQKDW3IdAwHgk6UOp7dwH6jAHElyBpDuZBWfFVlHWNFsn?=
 =?us-ascii?Q?YnpFrWL1cqXzHXASOHdvN5SINBEoGBCm9o5zsYIPqiPO20mf85VXdNSgNia2?=
 =?us-ascii?Q?a1q9DCABNY5oYCgG2zdVagxKHo7hOpVkBm0EYA/10o7/rs10IjHX0rwOiA6A?=
 =?us-ascii?Q?wRL8Npz+H8+Z165+zVcGnrJa+jT3HxcCvKFM2w/AcOazdRqOIIU/RvlMURYP?=
 =?us-ascii?Q?0B+a7zlb2izX8gLv2/tWEqs5zcNM6+oMYHwZXB6Wxm+PjcMCDWUgeCv6yFlP?=
 =?us-ascii?Q?w+nzjRYdl363d51570Cq2dw2Vy46M389Oaxcb7bj+VyqbI0Ie9sOfFjeevgO?=
 =?us-ascii?Q?kgeX4FmQAtDn0YwvCiTZ9e7aus6ICjOR4GTY5DbS7mUqZVdUtAe13xNPBTOu?=
 =?us-ascii?Q?+7yBzPyZHwIN8M/sVyN82kKjyzqsBVBTpejnf2/GmWGSnuLpwyD9JT0xq/Dv?=
 =?us-ascii?Q?CRQmP03VfAW6H9od53gDE4nPqwZW588sFeuADKtBOmxbhGMRk46yQemD1CLH?=
 =?us-ascii?Q?FQdpjSxrpRssr1Ju0IMkl0L5JcG2PgHBJt9eyTHs+7X1A+c/Gt4vBMrbI1Fg?=
 =?us-ascii?Q?APdDe87+bT1YKl0A71C8LKJTLVlZTcwr2iI5awcaHyCy65UGP++CbNkMT6D/?=
 =?us-ascii?Q?9TfLm9JMs9KNJ0jZH/KB3mA6v/pP2yB79LL7PxAZkQCyobniSEpC6kl8jJYJ?=
 =?us-ascii?Q?jBKg/wAfmeYzmUyStBwGbRov5r94bYPaWijcLeDVH9T2c3OBPF/z2tcoCXec?=
 =?us-ascii?Q?OoWYhC5llfnOQtnwqomKQTi5KrKHjbO4+OFy75e850M0eNTAouSEA0rZYamf?=
 =?us-ascii?Q?U7Z5LPwo9JqrY93Q5QA7MvsqZQjra9xIu6ul/Fi/ZRB1a7mOGdwlFpKKAthA?=
 =?us-ascii?Q?X9ljIY9dJPjz9fqMQvMtPei5epQjnn4y3mGVGCAuRDQZ88yttR9bPnKW3Jl4?=
 =?us-ascii?Q?lc0ntJ/G0BtJ6GpPn7NxXZ+RC6EcCqxIAf2jeGj86etT/MLvOuUBkyLY3BIN?=
 =?us-ascii?Q?9RJ7SmudQeco3Vx3U3TniEgns4yH2+q0M7c72tdW6AJeCtJw9hihiekGPovu?=
 =?us-ascii?Q?dGkvfwhnwgTc44Wvssje3Q4A6+z4EKF1s5/hdQaY7b7BVN/u/WOPlRn2ihYs?=
 =?us-ascii?Q?N1O6YFerI03CLyUbwpRCVyuogXNjw1rvMFs/V1AjU1C1JjPOxUTDaiWfNCcW?=
 =?us-ascii?Q?mEVtcMTEXOIp5iav1JGUidf3EvGbW/0PjCLQQ6jpfLyMmhptOTsi7Lu/+hcG?=
 =?us-ascii?Q?OLWmsig4DrnrpQc5wJFfkmAL5tdRsmQVx8K/qItHvjl/Ppm+ZSkdVLgiIv5i?=
 =?us-ascii?Q?rXa0ZUAHK0t6BgFHEYhJwZW7cVdggVVIcIrUEcoEPM6iUFKYSV+ZmI33oWB3?=
 =?us-ascii?Q?pBfc6qAWQRG4jwVnRk+vfPWHaOF8Qxhw2hf06ZnUpegyH7HrT27Fwavmwmr9?=
 =?us-ascii?Q?k1gjBHYiqdN36eg90LcMS6ad9oLX4anuY3mk5sqf968HKy3sSUn5+EfRSCit?=
 =?us-ascii?Q?Qw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 697ee2fb-9452-4f21-12f8-08dc434a8077
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 10:44:04.2992
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UvkmExg5XSlVtxDgpVhHfkjTUwFPOTth3LvY7KGNvserA35Ipvjqx9DB4FdY3s7GqxAaH8baP76+JlfvByy2FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8158
X-OriginatorOrg: intel.com

On Wed, Mar 13, 2024 at 04:06:34PM +0800, Duanqiang Wen wrote:
> txgbe register clk which name is i2c_designware.pci_dev_id(),
> clk_name will be stored in clk_lookup_alloc. If PCIe bus number
> is larger than 0x39, clk_name size will be larger than 20 bytes.
> It exceeds clk_lookup_alloc MAX_DEV_ID limits. So the driver
> shortened clk_name.
> 
> Fixes: b63f20485e43 ("net: txgbe: Register fixed rate clock")
> Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com>
> ---
>  drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> index 93295916b1d2..5b5d5e4310d1 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
> @@ -571,7 +571,7 @@ static int txgbe_clock_register(struct txgbe *txgbe)
>  	char clk_name[32];
>  	struct clk *clk;
>  
> -	snprintf(clk_name, sizeof(clk_name), "i2c_designware.%d",
> +	snprintf(clk_name, sizeof(clk_name), "i2c_dw.%d",
>  		 pci_dev_id(pdev));
>  
>  	clk = clk_register_fixed_rate(NULL, clk_name, NULL, 0, 156250000);
> -- 
> 2.27.0
> 
> 


I believe the patch is targeted to the "net" tree?
If so, the fix looks OK to me.


Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>