Received-SPF: pass (google.com: domain of linux-kernel+bounces-101426-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240313091259.1413854-1-ppandit@redhat.com> <0a1aa580-50b2-4657-8308-94bffb194aea@moroto.mountain>
In-Reply-To: <0a1aa580-50b2-4657-8308-94bffb194aea@moroto.mountain>
From: Prasad Pandit <ppandit@redhat.com>
Date: Wed, 13 Mar 2024 16:44:09 +0530
Message-ID: <CAE8KmOzcD+__7xdC7tegbHO9HEP48s7=reA4j-tvqVDwzHr+8Q@mail.gmail.com>
Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, 
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, 
	rjui@broadcom.com, sbranden@broadcom.com, linux-staging@lists.linux.dev, 
	linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 
	Prasad Pandit <pjp@fedoraproject.org>
Content-Type: text/plain; charset="UTF-8"

Hi,

On Wed, 13 Mar 2024 at 15:47, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> Why does this make a difference?  Is it just because it's annoying to
> cat a file that doesn't have a newline at the end?

* It's not just #PetPeeve. I'm trying to fix parsing errors reported
by the config-kernel tool[1], so that users can view all CONFIG
attributes without errors.

> I checked, and it's not a checkpatch warning.  Perhaps it should be though.
> KTODO: make checkpatch.pl warn about files that don't end in a newline

* I'll take a look at checkpatch.pl.

> subject but he's on vacation...  s/Kconifg/Kconfig/
> Just fix the subject and add a line to the commit message and I'll ack the patch.

* Okay, will send a revised patch.

Thank you.
---
  - Prasad
[1] https://github.com/pjps/config-kernel