Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1657806lql; Wed, 13 Mar 2024 04:54:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWO4lcOkS6tkHiC7hzvywtjovNkSnJjohOobtOjYsVkGR5rTZFk/0A2nRmVDehvrdpWQM32QUm1yxmTtj4akEUu5PWjbEVpgXrSLGwugg== X-Google-Smtp-Source: AGHT+IHw7D4J8N2Icjpijmz/nuCNm8196x5hgaS7DgrvxNjKmiQpx5Bl6CAha+iMnMZ1rm/lC04M X-Received: by 2002:a17:906:c20f:b0:a46:6433:536c with SMTP id d15-20020a170906c20f00b00a466433536cmr377343ejz.13.1710330845246; Wed, 13 Mar 2024 04:54:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710330845; cv=pass; d=google.com; s=arc-20160816; b=a2PwdW0y7OslywEEhME8EEUMrFay2FRGt76xv9AmXU5Us3zp6NzFwdCmSYuKSjItAS +wIt/sT6//Bhca2v/L3k2zVbPhAWJ2gJE/tTfVvLm2oCTqpzd/nReGbz64lOYp1GstM/ fPhEy4XyPCY2OO3572ZvN2++9oo+eLKnY7QZn4TUbDydr3vQWUX9N25xPVqHaOy299z/ Z2FsPTnoEIkcW6onf6x+/lLvYd+KjQjDHM+wJCMf85/ddxFFn5xlCQJBj3csZkjvzs2Y moH6s1BaCJqtdcFzcu+8qSrWFCX6mk0NslnBjdheJBTU5WHf6D64zscGZKaKChgwIHSg hheA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ewxFmA1gMurqYMDR124wjxE1wehEAqBleVZNQFFIZcc=; fh=B2If3ZLsHnhlVbXjm5e27y2bhJEemVV0LaIZhxA7/rc=; b=V9Dyanv3MpY6Nzi8qYrXUWw5aEc9Ht4y1L6pTFVs/AUQ3QCR384aoiGWS7DDJTVEfn F+cOW1m8gMknkUx+BFlhuG7BQCTv58apeTuUTb20h1jVePcQ0cDErADy6Z90Y3WHzRHb O5XcordtUs537mnzUSVcCG8729MoluVKeXnnc9UwMior6s8WyuGUNSdcVPjE4QUmDLtb IUmYalEVZCgzk6KVBGgYsuBICUWKKTw3nxi23tCdVoUaHCguOmgsXMjj4CwNIvagvXsI SfEvizQQtyPY1xcqFBSZhZ0d0ecJ5CXBoT253bis/JqxWIqhzNT5aknxALNBJgVxqv0c 2ISg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eGsun923; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-101450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g14-20020a1709061c8e00b00a463cc579a3si1801472ejh.30.2024.03.13.04.54.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 04:54:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-101450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eGsun923; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-101450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F1F8F1F23E44 for ; Wed, 13 Mar 2024 11:54:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D156405E6; Wed, 13 Mar 2024 11:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eGsun923" Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3403FE2E for ; Wed, 13 Mar 2024 11:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710330838; cv=none; b=sFw3lC3VzokN62GOV852kPnWw9mqwGVVSXAySOEwOil4RehBK3CkEKHUa6bPLUmlo0tKZi8vJeH9FzYXvOsZkHWtoavXisjVXOi0XnhxHj7U2viD1Xfy2PTDQRBq3PMHwO4hzZ9L7Afqlg9Qz+xASQff5ATWue7XusG7jsyMFt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710330838; c=relaxed/simple; bh=xIq1Cxt6Ky1vqIZb7f65O3yalptD2xDs8qqjYFp1+30=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cCGJZeXUXaJzbJgvJ5v53Ha4+vf+KEeAuwKiSgTf3pLzNeY9X3cSGE0HznxId0GUV0hWxUtSaOZEwwV1kCNWemgPTQNQIfGz1yGDDxAhoVo/Ju33w7rr46tZt0DyX1rN8F+Bf+yIsJXLAbmyevhu+kbytMEb2DLhzUU1KYMoCFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eGsun923; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-56878bb1abdso1986873a12.1 for ; Wed, 13 Mar 2024 04:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710330835; x=1710935635; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ewxFmA1gMurqYMDR124wjxE1wehEAqBleVZNQFFIZcc=; b=eGsun923FZ540v19rLujn/AG7Vw0mYm19ENd0Eo71iJVyJXbVpSDBoiRHA8e80qYyg cAfQgoQpGh4S03pK8zHCLi2orEC0RKguwQQxjXSd12pNGnn3F5PMsli9MKgMeniqLHir J+3km7ZnroJ9jrK3tUa481NOm40135mBopHSSuDpg3SxrserWrBMNOoDLn4AN77JBoeD EfmipEYlt+yzSMZiqFRtzRZjFzPBC70ZWbH2vdPHROzxBkSAM4oPhZ3inaFgaGf2Swct gRknU+uvetxgEmnU/lzwYJ776V6Jxy5liK74zLQBNGGpFXxhCAXD+cz1J7T2xxlIWkxX +kYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710330835; x=1710935635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ewxFmA1gMurqYMDR124wjxE1wehEAqBleVZNQFFIZcc=; b=sHD7KW7MJs5DoZwPiY/mrDBSU9l1ZJPFm8qnOwJMWbcyXDh9xrB4cCo2t5c72pBMRM NVN+sQkJEUXBRJxE4bWNBOcENLbomfeJpQIPHU9jI7cyxdF/9zjeQs/LLeZWjtp4aDKj rkonhB3jZ5SFYsxe6/5U1VnpO4h98IB9zA9BEjLSMSqo8q2LFfgESfKDjRKgC+XAXj+W dfvRgm2Lh2oZe0+5NwahX3yUg3mGcH+ihWGeNL9rNjHTDDEcE0PWUMicsxtDhb2ab63n MBHFLPqipXlRnUV6G0fhx0Iy0hOfO7EjU9hzZReSvHRfduCv76pQcg9NKr71gM85z3H0 fFuw== X-Forwarded-Encrypted: i=1; AJvYcCVtndnp56g76GlU+f0lg9hNSpaY+dCCiYW+FSLBvMzmt8Ap71CzuerFfWtyuNNbqJLkJL0gRAGJ58w4GanLQ0B9yMAvmr7i5O4dgAJC X-Gm-Message-State: AOJu0YzObEBHILm9nbWAPeqTb6f+kEwXgc5vEVXDatauPydRc3t3Axbd iL4TOqSBNiwRyEMrIazLnzdhs6lhLiEtQtOYkkbo2SWz2BCuqjbCh5Rj49Wh9bo= X-Received: by 2002:a50:9e48:0:b0:566:ab45:e6c5 with SMTP id z66-20020a509e48000000b00566ab45e6c5mr3240410ede.28.1710330831292; Wed, 13 Mar 2024 04:53:51 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id fg3-20020a056402548300b0056889f3cedfsm393582edb.55.2024.03.13.04.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 04:53:51 -0700 (PDT) Date: Wed, 13 Mar 2024 14:53:47 +0300 From: Dan Carpenter To: Prasad Pandit Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, rjui@broadcom.com, sbranden@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Prasad Pandit Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg Message-ID: <3fcb3702-5af2-4b9f-a362-4f08ee626b14@moroto.mountain> References: <20240313091259.1413854-1-ppandit@redhat.com> <0a1aa580-50b2-4657-8308-94bffb194aea@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 13, 2024 at 04:44:09PM +0530, Prasad Pandit wrote: > Hi, > > On Wed, 13 Mar 2024 at 15:47, Dan Carpenter wrote: > > Why does this make a difference? Is it just because it's annoying to > > cat a file that doesn't have a newline at the end? > > * It's not just #PetPeeve. I'm trying to fix parsing errors reported > by the config-kernel tool[1], so that users can view all CONFIG > attributes without errors. Huh. The seems like a very nice program. I've wanted a way to enable config items from command line for a long time. I wasn't able to get it enable the CONFIG_NO_HZ_FULL. ~/config-kernel/configk -e NO_HZ_FULL -c .config . I'm going Ack your patch because adding a newline is the correct thing but you should probably also change configk to handle that. > > > I checked, and it's not a checkpatch warning. Perhaps it should be though. > > KTODO: make checkpatch.pl warn about files that don't end in a newline > > * I'll take a look at checkpatch.pl. It's not required. The KTODO is just a shared todo list and anyone can add stuff to todo list or do it, but it's not mandatory at all. regards, dan carpenter