Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1683989lql; Wed, 13 Mar 2024 05:37:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW3tjRaLYGqozY0ji356dwRcyx2axpaYOggnqYoLtDWVJ3pTlwvSGJJAmNXr0NNa/S85bCtDrDa02R/EbOCX0kOLJ2JArJMORKjkMMqZQ== X-Google-Smtp-Source: AGHT+IGVqnEI1AWZsdpsKowtdhyzYUglzvrv5WNCvw72aOSafMoBwBcamQt6Mg9QTnXeXQhgsCSe X-Received: by 2002:a17:906:f9d1:b0:a46:3792:204 with SMTP id lj17-20020a170906f9d100b00a4637920204mr2257017ejb.10.1710333472057; Wed, 13 Mar 2024 05:37:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710333472; cv=pass; d=google.com; s=arc-20160816; b=i8mHX7a+4GsuSBC7WRl5M4icYmXsX1dkzfxBdePwD3biYcMX5dolu8jfyQ95lkr1l7 Jol2JcqQ8ze8UvwUXbeRlb0uG7x1wFnK2BtDLaCKoYuuv2JUaqGH9FJ8QqE8801r/ALj NOue6IjfuLy4Z60Q9vtNB/45RsR8w9YwSjg7CsRJVf7qrURjNcc5VgtsPl5dHF+/YzwM ZAnQs3c8wS86TQPbgRdfh0yYB/EgeO0tvlMkJ5hajbSik7iYekX3lEHNWWQOV0TBSg0e 7l86zuvzCTtQaXv/Oe9dQwoedcywfFdD0ahpUJr3tTeoM0kv0+gOPZKe7J+6T0IQQ3S2 09Vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=bipwNNYQZsUwmH59oT8QYK6cVW89ev95iLM0rdBUuqM=; fh=ZKFaUi3wxGSnCjhYIVDK2d43ljYkl7719hFEVMEWu9Q=; b=vHTwJkSNdB/sfFvPcLedFzWA9+Iex3Bk6mZkeyj+HdtPMcyoBaiuTi6rhSN8I9wxIQ vKrXlRHTwL9a+Fj5didFKq37n3SzM348zjaJOc2IKtZ0wgTZ57cMe5dCZaJiwSSXsjWJ N53uASKA+YA+IsacAJhrMBSLCWRapKvJd+U54GAfn4ROl9Lmg1M/p5cz4Bhb011tgiRS LbigeUhOQ02cX3i0kQzosjjZy/1wX4cE4HsZjQzbTfAnTjzB2akncwRVCiMUrv22T0fM cLn9nkDy0UovflVgcaWdzdSUz6T68s8xnl18QDO2rOnsnryPbQDj+plrLfm2cMcsw91c 6yNw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=fInGw5xX; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-101480-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101480-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id el10-20020a056402360a00b0056851734d66si3332481edb.410.2024.03.13.05.37.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 05:37:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-101480-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=fInGw5xX; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-101480-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101480-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9C2171F21EA2 for ; Wed, 13 Mar 2024 12:37:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D56066AD6; Wed, 13 Mar 2024 12:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fInGw5xX" Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD383A59 for ; Wed, 13 Mar 2024 12:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710333464; cv=none; b=aeh4mg8V3arS7cYn9TKJmbYemK/jAvF8NWycLyE5tHLrNjTDgDXDgWhIIQ69apn2FrUuKEtXNXf76fUTQPJgEIr2Axze2NoH3jq41o6mCe1lVlF38J2E01m+02iJ/MjPFZPtzq87GVRthWKexbf2PyeG04ShvD/qigzQD37it+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710333464; c=relaxed/simple; bh=cJmBnz6k0xIESxKWJRuBLNMa0QNfz2uY9clGq3EDUVQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Cmq4k/2OsIq9jGp4B6SmYwLcTMmfM5l9tHbEuUxDLskdkwk4GNDqDJ8FwvshdmMoyYdP3aU6iDDC5OL6Hs0DRsncZV5vkJYJ8hcKmDHGI4KP6bTJqr0iaSuGq5YuTmf8Ancpj7bYa10pLJiIQ18ipOxNMiDZldyEFFygTtXtQrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fInGw5xX; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710333460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bipwNNYQZsUwmH59oT8QYK6cVW89ev95iLM0rdBUuqM=; b=fInGw5xXVTRYJ1qjuUcNkBZiJMycCkBRBhXx9nLHcUrmkIyYQAXiWt77q/o2jE7/HsKtfU zxAk8ChyOT0lSOrc22twwnsNf9opCDC1P33gcN2WBxo/2zBgcTP88YEsPxr1EsH5o9nJVl UvC7Yq0BAY5XTja+ceTh3rsLC3Aogvo= From: Luis Henriques To: David Howells Cc: Jarkko Sakkinen , Eric Biggers , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] keys: update key quotas in key_put() In-Reply-To: <87il33f24c.fsf@suse.de> (Luis Henriques's message of "Mon, 05 Feb 2024 13:54:11 +0000") References: <20240130101344.28936-1-lhenriques@suse.de> <3007646.1707134664@warthog.procyon.org.uk> <87il33f24c.fsf@suse.de> Date: Wed, 13 Mar 2024 12:37:38 +0000 Message-ID: <87msr2qpd9.fsf@brahms.olymp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Luis Henriques writes: > David Howells writes: > >> Luis Henriques wrote: >> >>> Delaying key quotas update when key's refcount reaches 0 in key_put() h= as >>> been causing some issues in fscrypt testing, specifically in fstest >>> generic/581. This commit fixes this test flakiness by dealing with the >>> quotas immediately, and leaving all the other clean-ups to the key garb= age >>> collector. >> >> Okay, I'll accept this. >> > > That's awesome, thanks a lot David. And, as Eric requested, I'll send out > shortly a follow-up fscrypt-specific patch, which will make generic/581 > fstest finally pass. Ping. Looks like this fell through the cracks...? I took a quick look at some git trees ('jarkko' and 'dhowells') but couldn't see this patch anywhere. Cheers, --=20 Lu=C3=ADs