Received-SPF: pass (google.com: domain of linux-kernel+bounces-101567-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 13 Mar 2024 14:53:50 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC: <linux-kselftest@vger.kernel.org>, Reinette Chatre
	<reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, Fenghua Yu <fenghua.yu@intel.com>, LKML
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/13] selftests/resctrl: Add ->init() callback into
 resctrl_val_param
Message-ID: <7zhdrvbb2w2ytyhbr2pl22exkzktqhv4ykb5pht6wsefg3yfyz@72xhgz3uyawo>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com>
 <20240311135230.7007-9-ilpo.jarvinen@linux.intel.com>
 <zxrd5yzgtbet3d42c77ifgu5t2guyhwbz76zhk7zhrp6hnamrb@pl72dxisxax6>
 <vzluzxmks6bqfszwoib72ufbanxucxk5xzilavp3wrwoh7fqxh@rugv6wcptofu>
 <511bb602-e29d-0a2c-3076-81fdd5a5955f@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <511bb602-e29d-0a2c-3076-81fdd5a5955f@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?4WlFfTbTUz0m7rOvderSiGgZIRXeXA+21HetuoYjNqH6Yw4N5tiXqf+dFm?=
 =?iso-8859-1?Q?XQlFJnhqLDx0cuS/4ptHXVp/Fp8D2n7qQFTdZF23il3dlMjQ7zfb7j/Mva?=
 =?iso-8859-1?Q?JKOQdaRupPAO5ivivKk2vBOtPE9o03ZzcJv7cQRpJGNlGZBKZDqeZUuObq?=
 =?iso-8859-1?Q?8HLgGQxD4wf32pzZXuCaGpkwH0AmA9jHv15aZf+0q64yt9gk7bW062rdby?=
 =?iso-8859-1?Q?U4Cdlt1TJC4hCYNMRlF/auHCDFnFZKqezX/94vNNlcojqzK8X6kJi+0X6C?=
 =?iso-8859-1?Q?/SKWER3S4lDO3/Ipu+ACQ/nuHDg/qHIkOiHLsNU8IOzuWyqQWgUzdj47qX?=
 =?iso-8859-1?Q?w6l7Dvo5JTbo6WYpBM3y+gmJAwzLhXoNnfOEiMETU6amj9GtyQX7uQx5ct?=
 =?iso-8859-1?Q?Bx51OmWV8APqZcUuWYZfPzeDc97dZDOxvglLm/Fzzxbz77wNFl+41cJMb7?=
 =?iso-8859-1?Q?B15IC7KoClBnnSZ65hU/yeiH4c7jP1tpNLcn7tLF9P5rI18nFj7XtPNZYj?=
 =?iso-8859-1?Q?p5oFfiIzoZgNmIi+BLrH4etwMCtuomK4WJBBLI/X92GrOnOiJS514ln5PH?=
 =?iso-8859-1?Q?ieHrikqb1eJTBnW1Fm3KE03/3frdUITei6qRR3l1ywyPIB3DvDiZzpv/4s?=
 =?iso-8859-1?Q?CscBAH5bUYDW7eZVP0nUPxsDjUClA9b8BIxluPT/5veLccr+iU6YxQAAqY?=
 =?iso-8859-1?Q?k58b3i0Hnj46j2Ews+JsfUmKFmKYTpsVBkLUurkqSM/WFfcp7OlTYcmLCx?=
 =?iso-8859-1?Q?jgk9aOWbIqiKk409jn2PYQsTGr8j3iagPb79CwcdqN2KJGI7fv3NSsIIFL?=
 =?iso-8859-1?Q?7Gtbd8PmHqR/FjzMw9xf+jcDxVKg2SCmp49wQvo35Ly8aytjKVX7tJ77tO?=
 =?iso-8859-1?Q?Vb+rTCFU7yaGr2f1ZLyxyzXa1HLg0G/z/B8Tb4Jdh7nfluGOuTE/KzUvAn?=
 =?iso-8859-1?Q?WJ4KbsiafVPmB45g9rFKSJNno6nqvuq3SIe+pKalHmK5xPJa8QAJXYm0/z?=
 =?iso-8859-1?Q?PBhoa9fIA0WhIGtDQdIxVyNMTfvX30toh7C88nvhPk7iSygCVIRPVzG7p2?=
 =?iso-8859-1?Q?Km4MWwMGrx/RGB3iqX0Epp8VrLIw+MI6sEXOXWBT2c/zw83ilEo+qKTSm7?=
 =?iso-8859-1?Q?LAnXszla9z7Pnx+p/v2khFnfh2oDbSnA93aVXP23/pr0ht3mlf3c5T4J4t?=
 =?iso-8859-1?Q?N90o+ABgJOE2Qc5rkemV40Wogh1l9GcWcPzvfNqHPL/4m1NGa8LwrDcITc?=
 =?iso-8859-1?Q?67btitp0KYABqrEqPPGe7okRhwRSfD3IQAuLdkZwp9VdYDuvySkxTlbGi0?=
 =?iso-8859-1?Q?kHonPCAHYlp7eXqX5OU52k34h5yQgZAmG89mQmJikudrqlpEd1Gb2xjuj6?=
 =?iso-8859-1?Q?sRMzSq2nD/lBm0oMATtzVs6vNwfn04fGxxiDfmEyU1io3G4kjQ7UHItUll?=
 =?iso-8859-1?Q?BU0ZWMBndj4t7nT0hoPuXU7oceHnhCQNK5j6ocPwjnUfwHIKLZu/0yF7zw?=
 =?iso-8859-1?Q?vtS0KwX0dtHOu6wxxgvm+k9Kg6OvPOXIUG+IyEzlQFbAtYEf1xOy0Q1pEn?=
 =?iso-8859-1?Q?ybNf+u4KN/uuGEjeGKEgT0tUBv7r/zJSlN7V9ohj8Yo2+UGu6VdRq+V6Fq?=
 =?iso-8859-1?Q?YEXFkODf2W5WP1W2c1AEsApKPaeWcXEwUxwZw0bx7wQ/3kQiJSmCAT+9o4?=
 =?iso-8859-1?Q?pNEZEEhHmzzUiOldtnw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d59b631-dc82-42c7-b4af-08dc43650956
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 13:54:00.8697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TQHwnYY4tWB4i3DN4VLR78rbmT11bREOiC55OYWJzHKpDxD7P5FHac8jVCfEx3yln5MR14ZvvwFEVgmhjN7zQpRRLu2tsiY4AHUe5EZFJbY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8448
X-OriginatorOrg: intel.com

On 2024-03-13 at 13:37:51 +0200, Ilpo J?rvinen wrote:
>On Wed, 13 Mar 2024, Maciej Wieczor-Retman wrote:
>> On 2024-03-13 at 11:15:30 +0100, Maciej Wieczor-Retman wrote:
>> >On 2024-03-11 at 15:52:25 +0200, Ilpo J?rvinen wrote:
>> >>diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
>> >>index 241c0b129b58..e79eca9346f3 100644
>> >>--- a/tools/testing/selftests/resctrl/cmt_test.c
>> >>+++ b/tools/testing/selftests/resctrl/cmt_test.c
>> >>@@ -16,6 +16,17 @@
>> >> #define MAX_DIFF		2000000
>> >> #define MAX_DIFF_PERCENT	15
>> >> 
>> >>+#define CON_MON_LCC_OCCUP_PATH		\
>> >>+	"%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/llc_occupancy"
>> >>+
>> >>+static int set_cmt_path(const struct resctrl_val_param *param, int domain_id)
>> >>+{
>> >>+	sprintf(llc_occup_path,	CON_MON_LCC_OCCUP_PATH,	RESCTRL_PATH,
>> >>+		param->ctrlgrp, param->mongrp, domain_id);
>> >>+
>> >>+	return 0;
>> >>+}
>> >>+
>> >
>> >Is there an option to make this function (and the set_mbm_path()) global through
>> >the resctrl.h?
>> >
>> >I'd like to use it in my SNC series [1] for looping over different nodes and
>> >that requires changing the paths during the measure phase of the tests and that
>> >part is currently in cache.c:measure_llc_resctrl().
>> >
>> >Or would you suggest some other way of changing these paths in cache?
>> >
>> 
>> +forgot to add the link :b
>> 
>> [1] https://lore.kernel.org/all/cover.1709721159.git.maciej.wieczor-retman@intel.com/
>
>Perhaps ->init() should just prepare an array of filenames to read from 
>to support SNC. That would keep the filename preparations out of the 
>measurement period.
>
>It feels slightly hacky to have an array of files but I cannot think of 
>anything else that would be cleaner and would not require creating the 
>filenames during the actual test.

So the array of names would be a part of "struct resctrl_val_param"?

It would have to be dynamically allocated too before running the tests.

I kinda agree, creating filenames during measurements messes the whole
separation idea between setup and measuring. And as you said there are like 4
nodes max so not much memory would be wasted there.

I can experiment with it and try to add it in my series - since it's much more
tied to SNC. Unless you see it'd better fit here then that's fine with me too.

>
>
>-- 
> i.


-- 
Kind regards
Maciej Wiecz?r-Retman