Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758699AbYAHAKV (ORCPT ); Mon, 7 Jan 2008 19:10:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754352AbYAHAKJ (ORCPT ); Mon, 7 Jan 2008 19:10:09 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:53341 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754187AbYAHAKI (ORCPT ); Mon, 7 Jan 2008 19:10:08 -0500 Date: Mon, 7 Jan 2008 16:09:51 -0800 From: Andrew Morton To: "H. Peter Anvin" Cc: david@fries.net, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] system timer: fix crash in <100Hz system timer Message-Id: <20080107160951.5b63d5dc.akpm@linux-foundation.org> In-Reply-To: <4782BAED.7060102@zytor.com> References: <20080105221653.GA10065@spacedout.fries.net> <20080107153650.0cb85eeb.akpm@linux-foundation.org> <4782BAED.7060102@zytor.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 32 On Mon, 07 Jan 2008 15:51:09 -0800 "H. Peter Anvin" wrote: > >> + do_div(x, HZ / USER_HZ); > >> + #endif > >> #else > >> /* > >> * There are better ways that don't overflow early, > > > > Alas, I get 100% rejects due to conflicting changes from Peter's > > avoid-overflows-in-kernel-timec.patch. > > > > Peter, did that patch propagate this failure, or might it have happily > > fixed it? > > > > My patch doesn't touch any of these functions, nor touches any code > within 70 lines of this patch -- the last line touched is line 478 -- > and doesn't touch linux/acct.h at all, so how could it cause a conflict? oop, sorry, it was the mime-mess-mangles-everything problem and I failed to spot it. > But no, it doesn't fix this particular problem, even if using a similar > technique might very well be a better way to do this kind of conversion. OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/