Subject: Re: [PATCH] DS1WM: decouple host IRQ and INTR active state
	settings.
From: Matt Reimer <mreimer@vpop.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Philipp Zabel <philipp.zabel@gmail.com>, linux-kernel@vger.kernel.org,
       johnpol@2ka.mipt.ru, szabolcs.gyurko@tlt.hu
In-Reply-To: <20080107151022.82901fcc.akpm@linux-foundation.org>
References: <1199627174.28826.11.camel@localhost.localdomain>
	 <20080107151022.82901fcc.akpm@linux-foundation.org>
Content-Type: text/plain
Organization: VPOP Technologies, Inc
Date: Mon, 07 Jan 2008 16:13:23 -0800
Message-Id: <1199751203.26310.64.camel@bilbo.vpop.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 23

On Mon, 2008-01-07 at 15:10 -0800, Andrew Morton wrote:
> On Sun, 06 Jan 2008 14:46:14 +0100
> Philipp Zabel <philipp.zabel@gmail.com> wrote:
> 
> > The DS1WM driver incorrectly infers the IAS bit (1-wire interrupt active
> > high) from IRQ settings. There are devices that have IAS=0 but still need
> > the IRQ to trigger on a rising edge. With this patch, machines with DS1WM
> > that need IAS=1 have to set .active_high=1 in the ds1wm_platform_data.

> But no drivers are converted to set ds1wm_platform_data.active_high.  Won't
> IORESOURCE_IRQ_HIGHEDGE devices be broken by this change?

Good point; I think you're right. I'd guess the other platforms that use
this driver are in the handhelds.org tree, but I've been out of the loop
a while. Philipp, is this the case?

Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/