Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1796920lql; Wed, 13 Mar 2024 08:24:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV6s23fAEj/Li7EJPTOICy6SJGgKhLGmCXD7SdYxL7ts5i8DXERajglts4/sA53pwovbCsFmT1JL9oYg9Zbh3Tg1xYGNh4tzPOgm0QjJQ== X-Google-Smtp-Source: AGHT+IEDqi28A1AfNl9vNOUHWL3mC29enRYedeGBpYaUZWio3hQczZPS5ZGJXSAJn+vWk2s/cyul X-Received: by 2002:a05:622a:1983:b0:42e:e097:ea98 with SMTP id u3-20020a05622a198300b0042ee097ea98mr4694147qtc.25.1710343462340; Wed, 13 Mar 2024 08:24:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710343462; cv=pass; d=google.com; s=arc-20160816; b=VxvQgWvloX0EhE8CTmCkPgk1gDr9QPY8U88PtPp82GXCGzWmAZBDpjwpRW3bRK5M/d 11Lt1E73SrNDH3rHR+aCPva2yWEvNSfK8xylFYH9ZeqB0Q6v4xGYmKSoNZpN7ibQkpvA qg2QgInDznC2JUU31i4/VTF1ZUrWMeQ37phqeyyY/8gONO/6JKMwHzjfsS9CfTjXOWsu nHgxhjxqUi2NUcib9XZR5ZNQ8U44gKrU1ymrcUJ00C5GL6BaoLyZHpnlbTo8ui/VftMG G/CFsAHStH0e+UBCI6VYQ0ljzYmHyJVQxjzIxK0Rki1zxR57wumMrlsA8eYC0qJZTbAw WZng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HwySBDppIHFt2ysh7QvtukIj8GXUdrmsCOcwJBJI6TI=; fh=fv3yXocv+E9M8Doi0e1XVXn6D90v6uqvULqiiQ2a/Ek=; b=CPMj56YKTjdTfC3mALyTkjBwysZTmnyhKii45VKZMnATNJ6SgTYUH0BodzFisglPPr WaJmiKSAtVRRV0qQV1KNxMVuduBO1GR9OvYxOUVTq2GBBX7LSF43UGyLXqfmB6YDGcps ZbFaFj7jjgWY0MpbXk39Va+hRnxGdx66zbuX4C1Mjkjw1gT5FFVB1PinS6BZr4t6eEoR l8TU7CRwj91EiV9FMfILwFlqY60g6Qc30WNBy56gthJ+ZY6NRfgT73881CwoOiiB7sWu /eLkHnvZ3IslPbSotcw9QKnoSQP26ojP9qq1cW/A4NMjh06VZppRHSzydVnMYVOvx1Fm lHvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=f08oAtky; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-101674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f18-20020ac859d2000000b0043092bcf459si1105391qtf.517.2024.03.13.08.24.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 08:24:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-101674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=f08oAtky; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-101674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 139291C22563 for ; Wed, 13 Mar 2024 15:24:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 901D946B83; Wed, 13 Mar 2024 15:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="f08oAtky" Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8859146425; Wed, 13 Mar 2024 15:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710343455; cv=none; b=jgEt4IWrOTNBIuOt5qEd0yCNg+SwDN5+Cb3CYHRDZwXIvHTInIKu1lwU9NXPKdL2hVbxlLkBuf1UpTW5qlF/pAG5PXMhtVZTQh/p2EIm2I3SRf/a9XV7wPhK1A3dQ96TU0j2i/7TyQHmQzTXGrmvCA1txRYVIB2U/HGZ2MUUDsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710343455; c=relaxed/simple; bh=zLmTYamDLg7r/N+uNsQ1UpNtH7QKvcEeuvYnyZUx54M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uaQsA1mbeR9pUlsc0FcXEBmNKPWXKP321DdsYfsoLG2yHZSxSHmUht/2UbDwE107VhWNGbHvLDdv+nGexMOxv0lQywKS5ZjKGGgqHM1+wxob/xum8RIsmALIeYlz4mUexHJKeWNl7qVSNNM8guSomzxzGIcnde+u2891P0sUoqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=f08oAtky; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42DEsIaf001099; Wed, 13 Mar 2024 15:24:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=HwySBDppIHFt2ysh7QvtukIj8GXUdrmsCOcwJBJI6TI=; b=f08oAtkyPNRWhv7N0xsFNfd9Us2f5MoNGPFQJU49ztTsCYV4M6q0T76yMiBPzWlYWFv8 f0qdNfGdxVXqHLmGCi8cLYzjXbdanLSSzAAxWCpt+67bQOylf5NBRsqryIuntfLKyhm8 kAahPMwaitPcIsWVjvu3MzoXNye96SX5Q/cp5Uf0IoKcE0TaWvrA8wQI4DYiSzXxRhQP 9++UoJdFOkQ3oVSoGGKWnvl+gweCrErFgXzYmlvsXZfDJLjnTF0yqaNTbyECN6dFne6E o0+MqCUiqOniVJAgTcxThbnMmQ7CSOEpR2gq58oemOIvkTA3qbz1NXPsS/r+dFIXrKCO Mg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wud2rj892-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 15:24:11 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42DELQYX013603; Wed, 13 Mar 2024 15:24:10 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ws4ake9r4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 15:24:10 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42DFO5JD38142330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 15:24:07 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2251120043; Wed, 13 Mar 2024 15:24:05 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E76D620040; Wed, 13 Mar 2024 15:24:04 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 13 Mar 2024 15:24:04 +0000 (GMT) Date: Wed, 13 Mar 2024 16:24:03 +0100 From: Heiko Carstens To: Vineeth Vijayan Cc: Andy Shevchenko , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Oberparleiter , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle Subject: Re: [PATCH v1 1/1] s390/cio: Use while (i--) pattern to clean up Message-ID: <20240313152403.7008-D-hca@linux.ibm.com> References: <20240222134501.236871-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: K4logmEkiQQUNRORr8CuWz5Y_CVckGN3 X-Proofpoint-GUID: K4logmEkiQQUNRORr8CuWz5Y_CVckGN3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 mlxlogscore=695 bulkscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403130116 On Wed, Mar 13, 2024 at 03:57:53PM +0100, Vineeth Vijayan wrote: > > > On 2/22/24 14:45, Andy Shevchenko wrote: > > Use more natural while (i--) patter > > typo: pattern > > to clean up allocated resources. > > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/s390/cio/ccwgroup.c | 4 ++-- > > drivers/s390/cio/chsc.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > Otherwise, looks sane to me. > Acked-by: Vineeth Vijayan Applied with typo fixed, thanks!