Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1804113lql; Wed, 13 Mar 2024 08:35:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRj4T2oeOOfvJKafKIAIy4cmQzq8x415jOseOE6gGucsVR8sVM4SZ0rOqtQpcyP83etOdK59BVEiK0s1MSlSqlHbwe1T1XjuEbOUbABw== X-Google-Smtp-Source: AGHT+IErHeKORnD0DEuoIemKTx8kvKfNUOIPI8pCcxrofSgucRDwS2sgF5hMrNwU13I/66KB6oPS X-Received: by 2002:a17:907:a781:b0:a46:134c:afe0 with SMTP id vx1-20020a170907a78100b00a46134cafe0mr8141214ejc.51.1710344106864; Wed, 13 Mar 2024 08:35:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710344106; cv=pass; d=google.com; s=arc-20160816; b=xRApG6Q5zRHeyHC6hP2hf8GgXS0gG5O5tsNg7Mk0IGCa9ozUZEi9T5dq0XshHe8rd8 cCnY+FI9fjnmT5SqXAyZwDxvdFoPiODvYToGvKhnxATebrPxxWHSuNny6gKj8j9y6+q3 MnN9/4Mufefnp7F5jMKD+96yHC+ONJG+O+9nDILMiKhW4SxYhAw53YnMACOOLpNb+ytz qqlBzHEsmZ6cy+ZLi9M2rmUlxYkfrMksYbkk9GKF2uqRl+iNug9xj03vN3gxj/Leovvl qEchutuaEdfQfLaORyUFqx4OAN5TtnCiNGBAEAJ3n4iHo645D7Ji4NwkV+ZCQ4D2XZcE X8oQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=l9cvzp3lW0m1YZ5W3jkdpgLKphK7A8IGC9eZO6fY6Zs=; fh=WHuJJ/IxE6y54S9JBpS+wMYgIgZRZWg05JeXrnBLD1Q=; b=fbkTzqDsKOhvNI8a8xBhvHfm9Grp9gU58C+hU3FISOzSR22GIz3zw7e7pk+AMkdlbz 4NckTqM9S47rwl0PoxgBEYo1QnnqMBae6smgeuwfz9pn3TmOisKZkQermF+jIF3LTEFa BsnUsS+IA1utp+WQUTl6jlx2PZqZbQy5BEW0zNVub5pWBtnDY/xc2j3OifaRXmz2l7YE jktE5ertJo7fZXbM2AVKkeVBtF05BkzKNHTGAlIcu0oZItBQtc0YZaYyhGtdAQCmCF7v D+Y+DtB9wSoL0btvJ0mt4bXp0smMYHNMSYZmwULqGvMm/8IJLFVI63oTV1aUCVP5B7yk Ypzw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-101684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id w9-20020a1709062f8900b00a449eed43e9si4471344eji.592.2024.03.13.08.35.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 08:35:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-101684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-101684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-101684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 953E31F21852 for ; Wed, 13 Mar 2024 15:35:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F7FC47A6A; Wed, 13 Mar 2024 15:34:53 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4CF7346436; Wed, 13 Mar 2024 15:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710344093; cv=none; b=GD/vEGleu00Nec6rQ08gg79XN5c1ddSTDynthzUWnV5l9iBYe9PZIBle4r0PQ91vNaeIQu+2Zx65BYcBAlc8HfkeMUnt7RBg8o79PA6LFzsNFyV0eFSC77hlu6vy49jSPR1xSOH71IHYNSU41qBlyQ4/7ZXPLVp1hcRx18mDV/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710344093; c=relaxed/simple; bh=C7nU4SN7cfBWO5pOM0SsB5sh9GBra6/N3Zhn61BhuEE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lea6xs6ekQPNdztHYqSibWm716Rm/5J5cCJTt/Hh2/5ZMPcwOjykSXGSH9FqpxMQueIM1uQozOANOcqCB/u6p2LK+AYY7ty7+uhgTvCVmYg4SKwkfbPHVtUy50DSnUO7iCeLqNS8P3av9ihwmr/Xug7403VpdR6kExYlG7MdbBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 354C11007; Wed, 13 Mar 2024 08:35:27 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 24A883F73F; Wed, 13 Mar 2024 08:34:47 -0700 (PDT) Date: Wed, 13 Mar 2024 15:34:44 +0000 From: Sudeep Holla To: David Woodhouse Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Mostafa Saleh , Jean-Philippe Brucker , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-pm@vger.kernel.org Subject: Re: [RFC PATCH 2/2] arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate Message-ID: References: <20240312135958.727765-1-dwmw2@infradead.org> <20240312135958.727765-3-dwmw2@infradead.org> <520ce28050c29cca754493f0595d4a64d45796ee.camel@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <520ce28050c29cca754493f0595d4a64d45796ee.camel@infradead.org> On Tue, Mar 12, 2024 at 04:36:05PM +0000, David Woodhouse wrote: > On Tue, 2024-03-12 at 15:57 +0000, Sudeep Holla wrote: > > Looked briefly at register_sys_off_handler and it should be OK to call > > it from psci_init_system_off2() below. Any particular reason for having > > separate initcall to do this ? We can even eliminate the need for > > psci_init_system_off2 if it can be called from there. What am I missing ? > > My first attempt did that. I don't think we can kmalloc that early: > That was was initial guess. But a quick hack on my setup and running it on the FVP model didn't complain. I think either I messed up or something else wrong, I must check on some h/w. Anyways sorry for the noise and thanks for the response. -- Regards, Sudeep