Received-SPF: pass (google.com: domain of linux-kernel+bounces-101713-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: multipart/signed;
 boundary=ec260765e73bac126ee51ca62d74f74f4bbd22afdb55110dde7cef8988ef;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Date: Wed, 13 Mar 2024 16:56:00 +0100
Message-Id: <CZSQTVDX6QR1.1K5UGJUNPLM0S@walle.cc>
To: "AceLan Kao" <acelan.kao@canonical.com>, "Tudor Ambarus"
 <tudor.ambarus@linaro.org>, "Pratyush Yadav" <pratyush@kernel.org>, "Miquel
 Raynal" <miquel.raynal@bootlin.com>, "Richard Weinberger" <richard@nod.at>,
 "Vignesh Raghavendra" <vigneshr@ti.com>, "Mika Westerberg"
 <mika.westerberg@linux.intel.com>, "Dhruva Gole" <d-gole@ti.com>,
 <linux-mtd@lists.infradead.org>, "Mark Brown" <broonie@kernel.org>, "Kamal
 Dasu" <kamal.dasu@broadcom.com>, =?utf-8?q?Jonathan_Neusch=C3=A4fer?=
 <j.neuschaefer@gmx.net>, "Mario Kicherer" <dev@kicherer.org>, "Chuanhong
 Guo" <gch981213@gmail.com>, <linux-spi@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP
 with -EOPNOTSUPP
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>
From: "Michael Walle" <michael@walle.cc>
References: <20231129064311.272422-1-acelan.kao@canonical.com>
In-Reply-To: <20231129064311.272422-1-acelan.kao@canonical.com>
Precedence: bulk

--ec260765e73bac126ee51ca62d74f74f4bbd22afdb55110dde7cef8988ef
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi,

I just had a quick look to see where Florians breakage could come
from and just noticed this:

> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 849ccfedbc72..e0b6715e5dfe 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -974,7 +974,7 @@ static int spinand_manufacturer_match(struct spinand_=
device *spinand,
>  		spinand->manufacturer =3D manufacturer;
>  		return 0;
>  	}
> -	return -ENOTSUPP;
> +	return -EOPNOTSUPP;
>  }
> =20
>  static int spinand_id_detect(struct spinand_device *spinand)

This seems to be random as no other spi-nand ENOTSUPP was converted
but just this. Is there a reason for this, AceLan?

-michael

--ec260765e73bac126ee51ca62d74f74f4bbd22afdb55110dde7cef8988ef
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIcEABYIAC8WIQQCnWSOYTtih6UXaxvNyh2jtWxG+wUCZfHMkBEcbWljaGFlbEB3
YWxsZS5jYwAKCRDNyh2jtWxG++m7APsGW7Jo4lpVFMx2pZX2ivdcG1PCQ8xeW1SQ
QsPWXO6HlgEA6GXGBiyJkT1rh+sJTBKn5D6J/jDGAcdt6SCLWtzR/wk=
=TR1q
-----END PGP SIGNATURE-----

--ec260765e73bac126ee51ca62d74f74f4bbd22afdb55110dde7cef8988ef--