Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1881660lql; Wed, 13 Mar 2024 10:39:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUtzWWe6zEo3jARGO1sOXnULzTRkLLyfoGbhDahoqhpc/fjuUvzloduDcJh/CBnx8BWOOLGRkfR8YWkwO7NdFwCZPbgPa4AqTml0xLTcg== X-Google-Smtp-Source: AGHT+IFcP4O9TtLCUYsjXX7FJ8MqogG3GOe7hi9D2ksWYfKcpGAmkuX1BR4d+x8oU3HPyWeZN+AN X-Received: by 2002:a17:902:ecc4:b0:1dc:df18:c5c0 with SMTP id a4-20020a170902ecc400b001dcdf18c5c0mr14351592plh.0.1710351595919; Wed, 13 Mar 2024 10:39:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710351595; cv=pass; d=google.com; s=arc-20160816; b=Ha2vdP5XyhEZGUcPYU9ygye2Hp9NQJc+t78hcwNDFh7oiXb5ONk51wxBQMbwOBrc/2 eh0l2czBpnfl9kcXohJ5jdDeQh1wQVqajfq4dyRxXH9153gb8mBFOTa9Mi9tHEoDLPS6 3zXoZBJjyTMkCffrFD1Z5/t2IIX+CQzSle/T9OzLPUM4HIh1NoIuRWEHhrVWH3bfJXhJ x8NyJbiM/+RaMBrjRU79zXUrAf/Hw/V9nHWgwEvptYhgAdEwEWb3JWYwNjGsHnGLlGoH MFRafSq7DvM69NDLDeOJ5K5Ilcq4MPwYMFcCBanCYhYc1sj3dZ4TSmOmbTvynXEGtQH4 D02g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/MDt/QGrR4SdYTqDo7OXp0cNBLD7rs8DvK1AkiHJdAM=; fh=iLtq4Gju/41YYkRaEJJtBLz6aKGahwe7O4PiWfTBtgw=; b=iSY6pKd9NE6G+hGPna93r5ak+PNVV4wGAStGRw2cN7Mwp2fTseqWbyke6GDOjABdNN yhi/Rr7eRoCyRvhSvB4GeoxygcxQqlZ2ayqzAVG0W4Psv1Z5NHAEu3Zf+0V6UB+TeWwp rFDTd4V23ZX/1gJpan8qi6DP1F5gPpnqTRoJl1qcL3eYEtRiviXZ+aTOc49v3nmNxOlM MLuAjfRhfb8wlIB/yMb0RNa3THbyEPxWiOU/swVdbNnSqng36wI4DaZ49FkcvheolTJn MeZ1nyoHgoYoRxR8p2gz//WMlXvo5lOAvVzjojjsBSjYhbbEIhSORToKskyl/VNZxdSB N38A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WV98qSgT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-102020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102020-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k16-20020a170902d59000b001ddc7f33e57si2657252plh.417.2024.03.13.10.39.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 10:39:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-102020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WV98qSgT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-102020-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102020-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 57249280F30 for ; Wed, 13 Mar 2024 17:39:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33054657A8; Wed, 13 Mar 2024 16:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WV98qSgT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF3452F7A; Wed, 13 Mar 2024 16:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710348252; cv=none; b=PkplIjy+RmvwSw7t3PAudZ06KliEl8lhSbdcaD4I0cpOsuG6oIbdOxlg5Bew4dbakUj3d8f50W1Qmlh8ksPkbLaRP6ycAcsnITH/0PoKYU0k9utGmYxnoI9wLDr1Qzcc9sNXrtfu7PK/KsGp+SfbVgn9dkzlgq188msHjCC88c4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710348252; c=relaxed/simple; bh=qyHUlnlZHD6ThMTuwTmYi7wuWxF1xwykBrdeqrhso6w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bTga8KkGzAp/aUIuyKGtHP78Cj0/2EkXX4dPBXqpQL49DM/WsJXDUq06ltyqnqGKGKuXbDObozPKzWm+/Y9jdQHUphL/6GOXCcmiHwMSvJRh8JBsOvywj5nsz6Zowi4pR9EFgp3G1KnebaeY6DiaQ3BZEs11K5Ny4ulzSIv5VYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WV98qSgT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 024D5C43394; Wed, 13 Mar 2024 16:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710348252; bh=qyHUlnlZHD6ThMTuwTmYi7wuWxF1xwykBrdeqrhso6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WV98qSgT5EpwS3zfY5PwjcpDPq11RqSagwtF1YponA3eRZk9SFceQRttsbz7yG3+L 35QszWJuKpvomTlNNIS/DU9qHG17AsuH2TPAfJ8TECI/P/uz/cTSz0UF/T8ofIQrTs BcM7w0jYXTTkUClUHwtobTUcopmsiuae6kPkd9HkXXaor/k3856VjsjIabzA4pCHPs i9J0p/9PYkmrJFuQWTgUaVqpGAfG0IGtJdT0wLcfj5WWl9KiEJWq6BagzFpNqfpfx5 sWMgg6PVGNhkS1pF1zQctg2QykHcezsZ2rJd0Ei0xCfIpsaSmEN473XFxLIneBu6PX sx1kYLW3vD3LA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rkRiG-0000000062B-06pu; Wed, 13 Mar 2024 17:44:20 +0100 From: Johan Hovold To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov Cc: Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Kuogee Hsieh , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 1/2] drm/msm/dp: fix runtime PM leak on disconnect Date: Wed, 13 Mar 2024 17:43:05 +0100 Message-ID: <20240313164306.23133-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240313164306.23133-1-johan+linaro@kernel.org> References: <20240313164306.23133-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to put the runtime PM usage count (and suspend) also when receiving a disconnect event while in the ST_MAINLINK_READY state. This specifically avoids leaking a runtime PM usage count on every disconnect with display servers that do not automatically enable external displays when receiving a hotplug notification. Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver") Cc: stable@vger.kernel.org # 6.8 Cc: Kuogee Hsieh Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 4c72124ffb5d..8e8cf531da45 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -655,6 +655,7 @@ static int dp_hpd_unplug_handle(struct dp_display_private *dp, u32 data) dp_display_host_phy_exit(dp); dp->hpd_state = ST_DISCONNECTED; dp_display_notify_disconnect(&dp->dp_display.pdev->dev); + pm_runtime_put_sync(&pdev->dev); mutex_unlock(&dp->event_mutex); return 0; } -- 2.43.2