Received-SPF: pass (google.com: domain of linux-kernel+bounces-102103-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240313091259.1413854-1-ppandit@redhat.com> <0a1aa580-50b2-4657-8308-94bffb194aea@moroto.mountain>
 <CAE8KmOzcD+__7xdC7tegbHO9HEP48s7=reA4j-tvqVDwzHr+8Q@mail.gmail.com> <3fcb3702-5af2-4b9f-a362-4f08ee626b14@moroto.mountain>
In-Reply-To: <3fcb3702-5af2-4b9f-a362-4f08ee626b14@moroto.mountain>
From: Prasad Pandit <ppandit@redhat.com>
Date: Wed, 13 Mar 2024 22:19:29 +0530
Message-ID: <CAE8KmOxEyCHbCt=7PZi_xAnCdc2H3mFYYxBJ9YAq6imGmH6aJw@mail.gmail.com>
Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, 
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, 
	rjui@broadcom.com, sbranden@broadcom.com, linux-staging@lists.linux.dev, 
	linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 
	Prasad Pandit <pjp@fedoraproject.org>
Content-Type: text/plain; charset="UTF-8"

Hello Dan,

On Wed, 13 Mar 2024 at 17:24, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> I wasn't able to get it to enable the CONFIG_NO_HZ_FULL.

* CONFIG_ prefix is not required.

> ~/config-kernel/configk -e NO_HZ_FULL  -c .config  .

* This command works. It writes informatory logs to stderr. It helps
to redirect stderr to a log file.
Enable option:
  NO_HZ_FULL
    NO_HZ_COMMON
      TICK_ONESHOT
    RCU_NOCB_CPU
    VIRT_CPU_ACCOUNTING_GEN
      VIRT_CPU_ACCOUNTING
      CONTEXT_TRACKING_USER
        CONTEXT_TRACKING
    IRQ_WORK
    CPU_ISOLATION

* To see enable/disable/toggle options in action, a command below
(without -c .config) could make it easier perhaps.

    $ ~/config-kernel/configk -e NO_HZ_FULL=[y/n/m]  <linux-directory>
 | less -r

> I'm going Ack your patch because adding a newline is the correct thing
> but you should probably also change configk to handle that.

* ie. Handle files not terminating with a newline? There are not as
many such files. Besides I agree having files terminate with a newline
is good. It makes all lines/records of consistent format, otherwise
the very last line/record becomes a special case.

Thank you.
---
  - Prasad