Received-SPF: pass (google.com: domain of linux-kernel+bounces-102110-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240312210233.1941599-1-andrii@kernel.org> <20240312210233.1941599-2-andrii@kernel.org>
 <20240313151507.GA25452@redhat.com>
In-Reply-To: <20240313151507.GA25452@redhat.com>
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date: Wed, 13 Mar 2024 09:52:56 -0700
Message-ID: <CAEf4BzbXew_qC4NaA7vtqS5fFwkh6Hw-uKLq3UDD7GjGAP6UeQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next 1/3] uprobes: encapsulate preparation of uprobe
 args buffer
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, linux-trace-kernel@vger.kernel.org, 
	rostedt@goodmis.org, mhiramat@kernel.org, bpf@vger.kernel.org, 
	mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 13, 2024 at 8:16=E2=80=AFAM Oleg Nesterov <oleg@redhat.com> wro=
te:
>
> LGTM, one nit below.
>
> On 03/12, Andrii Nakryiko wrote:
> >
> > +static struct uprobe_cpu_buffer *prepare_uprobe_buffer(struct trace_up=
robe *tu,
> > +                                                    struct pt_regs *re=
gs)
> > +{
> > +     struct uprobe_cpu_buffer *ucb;
> > +     int dsize, esize;
> > +
> > +     esize =3D SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
> > +     dsize =3D __get_data_size(&tu->tp, regs);
> > +
> > +     ucb =3D uprobe_buffer_get();
> > +     ucb->dsize =3D dsize;
> > +
> > +     store_trace_args(ucb->buf, &tu->tp, regs, esize, dsize);
> > +
> > +     return ucb;
> > +}
>
> OK, but note that every user of ->dsize adds tp.size. So I think you can
> simplify this code a bit more if you change prepare_uprobe_buffer() to do
>
>         ucb->dsize =3D tu->tp.size + dsize;
>
> and update the users.
>

makes sense, done

> Oleg.
>