Received-SPF: pass (google.com: domain of linux-kernel+bounces-101666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <544d7b9d-ef15-463f-a11c-9a3cca3a49ea@infradead.org>
Date: Wed, 13 Mar 2024 08:16:16 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] afs: Revert "afs: Hide silly-rename files from userspace"
To: David Howells <dhowells@redhat.com>,
 Marc Dionne <marc.dionne@auristor.com>,
 Markus Suvanto <markus.suvanto@gmail.com>
Cc: Jeffrey Altman <jaltman@auristor.com>,
 Christian Brauner <brauner@kernel.org>, linux-afs@lists.infradead.org,
 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <3085695.1710328121@warthog.procyon.org.uk>
Content-Language: en-US
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <3085695.1710328121@warthog.procyon.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/13/24 04:08, David Howells wrote:
>     
> This reverts commit 57e9d49c54528c49b8bffe6d99d782ea051ea534.
> 
> This undoes the hiding of .__afsXXXX silly-rename files.  The problem with
> hiding them is that rm can't then manually delete them.
> 
> This also reverts commit 5f7a07646655fb4108da527565dcdc80124b14c4 ("afs: Fix
> endless loop in directory parsing") as that's a bugfix for the above.
> 
> Fixes: 57e9d49c5452 ("afs: Hide silly-rename files from userspace")
> Reported-by: Markus Suvanto <markus.suvanto@gmail.com>
> Link: https://lists.infradead.org/pipermail/linux-afs/2024-February/008102html

Not Found

The requested URL was not found on this server.

> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Marc Dionne <marc.dionne@auristor.com>
> cc: linux-afs@lists.infradead.org
> ---
>  fs/afs/dir.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/fs/afs/dir.c b/fs/afs/dir.c
> index 8a67fc427e74..67afe68972d5 100644
> --- a/fs/afs/dir.c
> +++ b/fs/afs/dir.c
> @@ -474,16 +474,6 @@ static int afs_dir_iterate_block(struct afs_vnode *dvnode,
>  			continue;
>  		}
>  
> -		/* Don't expose silly rename entries to userspace. */
> -		if (nlen > 6 &&
> -		    dire->u.name[0] == '.' &&
> -		    ctx->actor != afs_lookup_filldir &&
> -		    ctx->actor != afs_lookup_one_filldir &&
> -		    memcmp(dire->u.name, ".__afs", 6) == 0) {
> -			ctx->pos = blkoff + next * sizeof(union afs_xdr_dirent);
> -			continue;
> -		}
> -
>  		/* found the next entry */
>  		if (!dir_emit(ctx, dire->u.name, nlen,
>  			      ntohl(dire->u.vnode),
> 
> 

-- 
#Randy