Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1928596lql; Wed, 13 Mar 2024 12:06:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU1USQJU9RjnQH3qejpJS8t3TdF85QooJPI7UAbkS3hyYCqg/Cyvv6bR02o2uE+WB3WC01Gxh9OYwjl6DlU3FYHYtAbu1lz4OMcSdQ+BQ== X-Google-Smtp-Source: AGHT+IEg9KI0MAieDrOZ3T7SwJyOgoqtdHiO7EgZmSwkAFeZJGuUa6pOFC4tr/oJku+h39XFZ06/ X-Received: by 2002:a0c:da06:0:b0:690:bcb5:86d1 with SMTP id x6-20020a0cda06000000b00690bcb586d1mr692288qvj.7.1710356817085; Wed, 13 Mar 2024 12:06:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710356817; cv=pass; d=google.com; s=arc-20160816; b=F5MImBrlij5N1EVhwJ1C6G3ULRNSALdX/kbKNso8WOTzu4lg3wWeSh6R24NORw9rYn ItVc9z5jmllTDqZ562QWfgJgYuNvnizYmiq8TcBXYq4k6WrT9NBuzS9LTy/YiKKLGHfY bfamW6Woi8lFiy0jDFIKzhS93QXb6omFdomsWENtd7YBlKJZ//CX+hzTGhqPq94Et0VU IpAJEZpUv16U3lStv5OgHLWwSzuHbI7JBPgI/KWzrJ2osY4o1lfcG+fQ1I3VVPLLPpCO K2qJ9L8+n3YDJIFefQZ5L4IJlVvD4tq4A0C7lUqN2K7Oz34h25165A+byav27g1YRxWz tQfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=v5wjPJyxlyZSgw7QRNfZacYjQP379B5XDAXYyxrHWgs=; fh=zOKWsasrIqwfDHu6YhjBkk4csH7ISciX6CSVUqyGq2M=; b=iSIx4nrYgncaNyQa62axfrbrtuadl1a5IHcpoLFLxexqU/7lvi6fVykakoQ9+6s1rU 16lSUgedWOY5QpGzFIDQ4d35MqzO0l+E7L/c9vCI3qKeaBS0BM1/RXdj8QZbI/as5idD lTxnyZ567DcjowQ4AYkNeO6CH+0dla+nx2x5ngUQ6xUSMGbhEFJYHTYb5PlbeLHnFk5C 2HwOMxkGvObafV3GhtXVaEmNHF7kyk51hIsMCX99o9oCwh+72q3x9+3NhDEaHLFy6WUC LATMtfyvw93YKr9ib/a6GnYnH7a0w0DLMrE9t9rXUj1UFScRI3Ylq3Vx6GCEum8QD5YV U46g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=jUHSSKEu; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-102340-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102340-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id z2-20020a056214040200b00690df88adcbsi5360264qvx.516.2024.03.13.12.06.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 12:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-102340-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=jUHSSKEu; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-102340-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102340-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 102A71C27B20 for ; Wed, 13 Mar 2024 19:05:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A8A96CDB3; Wed, 13 Mar 2024 18:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="jUHSSKEu" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5FA6087A; Wed, 13 Mar 2024 18:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710353830; cv=none; b=QiaBpo1ybKe3ws3iL7q+nRo94S81zzPkA8amfNdg7RYy7hYqbtVcdelMWqpXLOCY/Vzk7mjJURi2+fIOskB50jEiPTrsZvYQlWLm0x+EQx+s3Bl8kXxgKZjEcS9XY+wGDpQu+Dn3UUqzf/G1Rp0cafx4qVGPNlY1D9sel1FPJWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710353830; c=relaxed/simple; bh=lJ/3lSowUjOAXc/R3q4VoL3CPOs5whatKhHPsl1wyS0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Pce9ulMPNVyhbgPu1HmiWM/G4OIS1Z/Ckxv6tONsRcZZGv4gGeQ14lNx9dKNqgrdboMILLnDP3FMkNx1831Kvnl8rxOhCd/PMqxZTiesp7MUHbZMZv6IdE9vOTMzd1yjeXam0DlQPelUdUIRGRbbhz12m2M7OYkVzzMZ4jFRRSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=jUHSSKEu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42DHQSY8032501; Wed, 13 Mar 2024 18:16:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=v5wjPJyxlyZSgw7QRNfZacYjQP379B5XDAXYyxrHWgs=; b=jU HSSKEujd5ST8b01tUiDMG1O7g5X2v+xnubLImtNi7WfDCndpJ5rXjKVhTJ+OmFFE 3oUCfmRtyIFaMEUymVBNI0axtLJsKfJB/sGvxwFGBwSlYL5CiocXEkYP+TI0j0HW cwgAHrwih4tZ2Slt2ONptz25D73MeRycR6yzKt99i3s7YKnv1TIH1TcsDdDvNXYc iQ7v3UpLs84C+iPP1ioVWwnuq7kLFrYxY7YV9qcznp5wgQ3DMrdCKoMRE5fbsFXu 4Ll1QwCIo35W2siD5vYMWjzHjb+3i8gUnxUQpA8R6QnUB2/fFhjYWnKslKlmhVUf wpb8qauhpeF2Y/NQsZQQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wu9xas35m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 18:16:56 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42DIGsBQ004907 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 18:16:55 GMT Received: from [10.110.70.168] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 13 Mar 2024 11:16:50 -0700 Message-ID: <2020929f-c9a5-1209-78cb-ca75db44a432@quicinc.com> Date: Wed, 13 Mar 2024 11:16:48 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] drm/msm/dp: fix runtime PM leak on connect failure Content-Language: en-US To: Johan Hovold , Rob Clark , Dmitry Baryshkov CC: Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" , Kuogee Hsieh , "Bjorn Andersson" , , , , , References: <20240313164306.23133-1-johan+linaro@kernel.org> <20240313164306.23133-3-johan+linaro@kernel.org> From: Abhinav Kumar In-Reply-To: <20240313164306.23133-3-johan+linaro@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: BNNegcXJxongtAGZIx1lIDE54NIYGZW8 X-Proofpoint-GUID: BNNegcXJxongtAGZIx1lIDE54NIYGZW8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403130138 On 3/13/2024 9:43 AM, Johan Hovold wrote: > Make sure to balance the runtime PM usage counter (and suspend) before > returning on connect failures (e.g. DPCD read failures after a spurious > connect event or if link training fails). > > Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver") > Cc: stable@vger.kernel.org # 6.8 > Cc: Kuogee Hsieh > Signed-off-by: Johan Hovold Reviewed-by: Abhinav Kumar