Received-SPF: pass (google.com: domain of linux-kernel+bounces-102410-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d190daec-a7e8-4a88-9b96-e3610e9fc3b2@oracle.com>
Date: Wed, 13 Mar 2024 15:14:18 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 09/15] admin-guide/hw-vuln: Correct prctl() argument
 description
Content-Language: en-US
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>, Peter Zijlstra <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Jonathan Corbet <corbet@lwn.net>
Cc: Suleiman Souhlal <suleiman@google.com>,
        Youssef Esmat <youssefesmat@google.com>,
        Steven Rostedt
 <rostedt@goodmis.org>,
        David Vernet <void@manifault.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        joseph.salisbury@canonical.com,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall
 <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Luca Abeni <luca.abeni@santannapisa.it>,
        Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
        Vineeth Pillai <vineeth@bitbyteword.org>,
        Shuah Khan <skhan@linuxfoundation.org>, Phil Auld <pauld@redhat.com>,
        linux-doc@vger.kernel.org
References: <20240313012451.1693807-1-joel@joelfernandes.org>
 <20240313012451.1693807-10-joel@joelfernandes.org>
From: Chris Hyser <chris.hyser@oracle.com>
In-Reply-To: <20240313012451.1693807-10-joel@joelfernandes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SWNGMUpNUjI1cnVnZzFlVktHQnB6Mm5HSTJuT1VLNFB4UGc5VXcweVNYRlJs?=
 =?utf-8?B?Vm5MZkw1V0tiTk1XSEpkaXppUllGNDI1eEp2dWwxR3Z0Z1BSMVp6akxzTUxQ?=
 =?utf-8?B?d25vR0hYcVJBMm9xODB5VGpmRUM0WG1qWnowRDFoODJWSlZ1ZGpNcWJydzNs?=
 =?utf-8?B?eTBPWVRTcVlIeUpYT3FwRy8xdGhDcjJ5S2cyWHF1U0RDWTJYSDkrbGw3d1FM?=
 =?utf-8?B?Z2tacFAwdnpoTEdZU0twWXEwa1pwa2UrakltbnNHcWZZSGFmakh2L1dSVDZS?=
 =?utf-8?B?clZuc20vdzFFZE11VjFzaGVMSEh2ekhKWko2ZGI3cmxTQTR5R1FDUjQ2dGh2?=
 =?utf-8?B?MVJSUzVMUmRKVEFxMi8rNmQyY3FnemdJL29vSXBOcWE4VFpaYWtORVhEaDl2?=
 =?utf-8?B?SlhTOVdNempXY3IrYjl0bjFDdmNabWNKdXpLMXM2S25GUVQ5VUozNmtpS3U0?=
 =?utf-8?B?NDQ0WjBNaUkyOTIzcEdkS1ZBeS9vbUhqOUJOTHA0UTBROTF0VDErU3hvWWh4?=
 =?utf-8?B?cnk0SHVYSDZrUk5JcCtSVSt2ektHWFVZZjlBZlRaVVUrMkpRZ01lVitzSktH?=
 =?utf-8?B?QnpEMnlCdXNZbXhJSWRuWnRHRmZxMW5ZZ29RM2NyNXhaQ2xjbWRENTNDcjdx?=
 =?utf-8?B?KzRoY3JlS3NzNktIWXN6Mmx2VFNvTjdTS3kyY3djVUF5Ym5BdUpUbFVuTUVQ?=
 =?utf-8?B?NkNrSTNyYlJHTVFsTHA3UHNLYlJ2dUdpTTh2Z0svNWYxSS9odkdhTGYwa1Y3?=
 =?utf-8?B?dW53cjRQSkVMenlVWG1ycWNGVFdjbFp3VEJnSGxTL0xCdnl3ckV1ZXlzNWdM?=
 =?utf-8?B?ZlorNmFualU0RVpQRjM1bWdHSGFxZlpPUnZPckViRU9PUzhNbDEzUVpUbzZV?=
 =?utf-8?B?UFVkTW1WbmE2cWFUbm9uc3B0MnVyQXpJeUFlNHd0elQ4S2RxU0dVWS9Td05r?=
 =?utf-8?B?eklaK2Jkd1dBUnhRRVlrZG1Wdlljc20rRDc2VHJ4VW0xREJOa1lYd3dwQ2U0?=
 =?utf-8?B?ek5OQTZNRUNWWjBQTGJhQkxIMk9NSU5YbWF1MTE4Sk92bzlObnFvZ1N4cU5v?=
 =?utf-8?B?Z0ZuU2dQdGdwNHhBUGUzaDB3ZStwdXkzTGY3NFlqTnpieUJLanA2YjNsaExM?=
 =?utf-8?B?M2YwWERRMlZoRmtaS1p2ZXliT0duU0MxTlJ2K0oxelhUZ1FDaXY0dVM1UE9N?=
 =?utf-8?B?VEdzRGZGYUhjUzEwNnFLT1NNUFB4UUtaTnplNlRJc2syalFsY0ZOci91aUd0?=
 =?utf-8?B?RzlDbFl5aloxcGgxclc1TVZxbXB1YklXUGNlQ1luQXR1NklWbjdWR1NUZ1Bp?=
 =?utf-8?B?VitaZVdYYkgwMldtZGU1SXNSOVF3dWdJeXpkQVVOT2liMDRLY2E3L1hjTEZ1?=
 =?utf-8?B?aS8wckZpRXdhMVEzTU5ZUzhyZWd4dENpNFJwRFZ3amZMV1BzU3Yza1VUeFFp?=
 =?utf-8?B?UGhpa0h3U09vVHVUbXp5Z2JFNjFVRkJmLzFtVkhwTFp4YUl1ZU5yd3VqNlBl?=
 =?utf-8?B?MGdXMnJjS01Pb1ozNXpiTDBaN3ZFc0F0c0RkQ2ljY1NjS2p4WE5mQ2ZocW5S?=
 =?utf-8?B?c1FkcHk2bzR6WUYyeHdaRmNabndmeEhESEczT3RlWGN0UERzRGNrSTVsNnVR?=
 =?utf-8?B?OFYzbDQvK3JzUXJwaWQ5ZHlkV0dmNmFVZmtuc1ZrbE1idmZTejNBSzdaYy8x?=
 =?utf-8?B?NDR3Wi9WSzI0dHFoN1hHNGVyOWJqM3kwNTc5Q2ZlcnVPRW13TGVxbUNTU1R6?=
 =?utf-8?B?UHpwQjVIMnFrVUVnQ1ZBaUZBbVNKZklhdGNOUDV5OW9DTDdzVnFuRUl5RVVC?=
 =?utf-8?B?VysvSXg1WVRaOG8wUWljWFJlZHcwaU9WQ1JOcU50MG12VUZGN1dwbEdNNk5n?=
 =?utf-8?B?MUdRRldwbXc1V0tLK09iZVdTN1BtZEk5a0VQTkF5d1pzOThPREcxbkFHRmFq?=
 =?utf-8?B?NWRwMDNLN2VVbmI4cndDOHhOUlpPTWFXUThCSmJSSG52SWxhcjIwZFc2TGpv?=
 =?utf-8?B?cFpKbkJTQm44SjhBeERMZGxsazQrZTZpdlYwbTkzK3ZTR3VhcEhMck1lRHpZ?=
 =?utf-8?B?aklLRHpqWENZbS9ycnVSbCsxVkYyNTI2RzZTOWhuM3ZjZFdDcmlCU3A2UTFx?=
 =?utf-8?B?Zmp0OHR3bnFUNzlwQlZnMFVJdHpnNzdzMW1MUGNHQWZJaGh5Vk9iV0pwNVpI?=
 =?utf-8?B?RUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	SvdANdO7dfzhaw2QjNYvHwvjnnH7I0EA/Br60WOY1OmCwc3kDiXiIEaO5nY1kLUN3ceG7ULWkskZliWVD8HTd7dLx92t0cKeB7XAyAw4TOoDccfqLDQBU+rNUg7OKp/LdjtXf9MSKFa/vYEtKksRDGmfsJbT20C2MfZNO+bgwQ1NNR8Q54whSeXeZJySCDnad1Az+x8h1RCtYxKvnnopmdilEzcsFpOaBo6nSQaeAELbFdH4w28Q6n3DQqPLjYQNE1/1H0UXln8a0QstkvbO4mWF4KQ+0PsYSroIAStIDqo9PowyMXX9Y+pSA2+m/FOufUyJfLzh8qmqduxptWqHG83DjOrE/ED9cfv0b09mdzlRCVf3hfodWx/Vgfw+wTqre+CMlpH2DtZEvH7kS87xgLqJIPvI3/mL8/mtoXx62TOmLj0BjSBbuKb2oRIXN2VnM+WcTxgm5JDSOK71YGJ1WplSmNoX10ga+fLcHirZJI3Zla7d4SYtfCSvFQ+VK9QqC6Nz5YgQ5ZZM+umNBQ7BozrgxOtW0T6x5SQF/M/B0FdufQo6yr1oBoSnOt/BN4wBVd/FGG7hsEKfqjak4TM3CA4K2J8jBBOxq3YZ66XIyng=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1dec080-a06c-4556-83ef-08dc4391cb1b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 19:14:23.7752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kZTJaL1O9/eLAK5MA99yPZ+ZO8XSimeSNV7jDH4sPhZv8Y0WV+fLEY8DooHaT63/f5J2xLFNJBgP5Z2R8CRIGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4627
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403130148
X-Proofpoint-ORIG-GUID: uIjY2-L9xD9YMFEuN2jeYUvIwc-iMTg6
X-Proofpoint-GUID: uIjY2-L9xD9YMFEuN2jeYUvIwc-iMTg6


On 3/12/24 21:24, Joel Fernandes (Google) wrote:
> Correct the description for arg4 which appears to be outdated.

Technically, the constants referenced in the documentation are still 
defined in prctl.h, and there are BUILD_BUG_ON() checks to ensure they 
match their PIDTYPE_ equivalents. I would presume these should be left 
in as it is technically a defined interface and user code could break.


> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
>   Documentation/admin-guide/hw-vuln/core-scheduling.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/hw-vuln/core-scheduling.rst b/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> index cf1eeefdfc32..338d639a8127 100644
> --- a/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> +++ b/Documentation/admin-guide/hw-vuln/core-scheduling.rst
> @@ -62,8 +62,8 @@ arg3:
>   
>   arg4:
>       ``pid_type`` for which the operation applies. It is one of
> -    ``PR_SCHED_CORE_SCOPE_``-prefixed macro constants.  For example, if arg4
> -    is ``PR_SCHED_CORE_SCOPE_THREAD_GROUP``, then the operation of this command
> +    ``PIDTIME_``-prefixed macro constants.  For example, if arg4
Presumably you mean PIDTYPE_ here? Otherwise looks good and in 
retrospect this is probably what should have been done in the first place.
> +    is ``PIDTYPE_TGID``, then the operation of this command
>       will be performed for all tasks in the task group of ``pid``.
>   
>   arg5:


Reviewed-by: Chris Hyser <chris.hyser@oracle.com>