Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp1952238lql; Wed, 13 Mar 2024 12:52:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXhA45N8waNpbws6/LtCGQXkLccZwE1iUqrVq1/88JATEkbGl96asYGsQvReal4wPxRXEwgXbxb+HP/Stm/gSyeWkDRWp955fUBg9QnSQ== X-Google-Smtp-Source: AGHT+IGvWwfcyxQzSlDBmpUzsTWXBxW7Lg9EBJK8/PUdvuzxKcB+Wu1rTdR8GzLB7hh1iME3eAiK X-Received: by 2002:a17:902:bc8b:b0:1dc:2f30:e0dc with SMTP id bb11-20020a170902bc8b00b001dc2f30e0dcmr10227888plb.36.1710359542226; Wed, 13 Mar 2024 12:52:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710359542; cv=pass; d=google.com; s=arc-20160816; b=t6zkyLfJPvrLcDao/iIj4TgBHjBLGB5r2VLOuzJyhi7ar13vlEZtrzxl/tWOtDYAdc eMRrAMmLyAcxjEk+48GHvE26iraST9/nB1Y19tANGhgIAT9cFj4a1uwtGgMR8wXAqVwr Jtc0OU699nf30mjqkRef7fKaYjh3IfB0JeEckFmzSm2RMoGlc8o54IWdoQ7DESL79l8P L+mLUTJ9osg1PyDi/Rq23rKi/mYI1hZQAF+4CViBabbiqb8m24jDyyeAgejTLnQRjLjp hyGZYw+QB1NvBWf57l2n+WxXMIuPaZ3kfz5u34LeSQT+kW61I3kHAa0Cl46MQPx5d8Mu 8xSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KjmiZg3EAJQ/7RoTwqomd7rnaA5S0FajGsdfSKsK+LI=; fh=EAoiHeShrMXBqmvTgy0RUoWlKrU2VjXxwem2hY2ka1E=; b=U/JNByFI+lAwV8RP726g9R4YxkOWlcCM8o7T5jVAy+4Vd7kxCEDD0+dP6flYWJCxgn UZOXXZJPgQO4CVPon0hGx/F81b+XN7K0lNhoCzAp3dPdQ5U5dvdmXOHGKw40WEGZd1zB XaQPejSjxNeUb5smpp67GXE5Yg1+OMievTXjAYUzQxJAVNpyzBbuo8wKPDC6hmE7WnhQ x/ER/OsHEpk1fStJDvrphM3RBEs+DtDc6gs1jl7B7baRXINynug24hv5likea4yjk8GB 3GShYQ5z0OJ07IGhvlEj16Mqoxt+o92D0l8byfcjx2fzjGzVotdmxfpYvR9M4yIZ7dYz Bz8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Wteln205; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-102452-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e13-20020a170903240d00b001dd97ce4a74si7350722plo.114.2024.03.13.12.52.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 12:52:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-102452-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Wteln205; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-102452-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E267428A432 for ; Wed, 13 Mar 2024 19:52:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AB2FD4C630; Wed, 13 Mar 2024 19:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Wteln205" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333FB50243; Wed, 13 Mar 2024 19:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710359533; cv=none; b=ocodyFSPJgsoQ7gYZPsQm+azqSyQGV4h/tDZlQ+dBtwkrzdaDj9QoRCS9VUl1znT/eWH3Y/sDoVr9RvG08SevMgQ8EA1WGvG+t09ObmwkpGZg10LG2oKQKCd/ZP2ZKrzb0+wdk++CRhvRMiIcj3wje3KEy/Nh8okn4WbqS1FIXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710359533; c=relaxed/simple; bh=2ZkDECGgCzxUfGsarTHx62/lL7Cs0OVqL8S2PP9gs3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OTcDIRFdbx26PCmKyPDhimGqbZEJhG3dPWtpJ1aECy9ZRIVGQfT0WdCdu/bW89X56SKFcfL3w4Ov8ctxgdXLezBr0AloujAOTFDYx4YIW01xfuVBSY4AuiGlFfsLsV+mGMpCQVxWlQrcpvneaffEORawdmKEfgRFRY2ZJqks5hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Wteln205; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=KjmiZg3EAJQ/7RoTwqomd7rnaA5S0FajGsdfSKsK+LI=; b=Wteln2055cbwnePEQiiE5RkPGW BGbP4EIngHKXaoxI2XDXI/AfSmQx6qs8O616KuIqy8gKlkHGUB7U8r9PjGauF/bwK7+Fi+ukaC55R eezoS5aL2c+RFePjdDoM/a1oqCKjeQiXyVZa6WMazXaSNOR6CxBp+D9BxsP5NipvgLhg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rkUeY-00AGIU-0m; Wed, 13 Mar 2024 20:52:42 +0100 Date: Wed, 13 Mar 2024 20:52:42 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Ronnie.Kunin@microchip.com, Raju.Lakkaraju@microchip.com, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, Bryan.Whitehead@microchip.com, richardcochran@gmail.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences Message-ID: <725e8182-50de-4469-9f87-fa58179f8922@lunn.ch> References: <20240226080934.46003-1-Raju.Lakkaraju@microchip.com> <20240226080934.46003-4-Raju.Lakkaraju@microchip.com> <78d7e538-9fa0-490e-bcfb-0a5943ad80c9@lunn.ch> <3e84e1c9-f680-47fa-aa59-615ce57b65da@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e84e1c9-f680-47fa-aa59-615ce57b65da@gmail.com> So i think we need to agree on best practices for new drivers and document what that is, probably in both the ethtool man page and include/uapi/linux/ethtool.h * WAKE_MAGIC on its own is O.K. * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL. * Each driver needs to enforce this, due to backwards compatibility. Some may decide not to. Can we agree on this? Andrew