Received-SPF: pass (google.com: domain of linux-kernel+bounces-102471-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0eab402d-f18f-4831-0be3-2ecaea40a62d@oracle.com>
Date: Wed, 13 Mar 2024 16:06:11 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 10/15] sched: Fix build error in "sched/rt: Remove
 default bandwidth control"
Content-Language: en-US
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>,
        Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira
 <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>
Cc: Suleiman Souhlal <suleiman@google.com>,
        Youssef Esmat <youssefesmat@google.com>,
        David Vernet <void@manifault.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Paul E . McKenney"
 <paulmck@kernel.org>,
        joseph.salisbury@canonical.com,
        Luca Abeni <luca.abeni@santannapisa.it>,
        Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
        Vineeth Pillai <vineeth@bitbyteword.org>,
        Shuah Khan <skhan@linuxfoundation.org>, Phil Auld <pauld@redhat.com>
References: <20240313012451.1693807-1-joel@joelfernandes.org>
 <20240313012451.1693807-11-joel@joelfernandes.org>
From: Chris Hyser <chris.hyser@oracle.com>
In-Reply-To: <20240313012451.1693807-11-joel@joelfernandes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RVVRT0lNSHJhenZmeWhnL0hnemdyQ3Q0Z1NvV0dBVC9vNXU5Tm5qVWVDYUth?=
 =?utf-8?B?SnY0L0d5Y1QxK1lacndCdXRYNlNzUTZkVElraUMyMlZLMWNNemZjT0VzWDk4?=
 =?utf-8?B?Q1gwYk5sVHY0OHpJVW9va1hLZ1IzZ2VyL0ZCLzB5SFlQK1kwV1RrcWs5QXhR?=
 =?utf-8?B?UHJMb3ZFZG92ai9EcjRWNEVxYlRkLzg3WHBMWHNKRjh2dzVBamo2OVJ5bURz?=
 =?utf-8?B?UmlJR0RwT29hak1VQ1VNaTl0TmR2bmNsT1pIeGc0ektXM0hNazFuck5zZ3Az?=
 =?utf-8?B?ZEhMV09QZ29hSTkyQ1RXTkk4ai9WZnJDRzhDNHRyUHpENTdLS0x1d1MzM2RK?=
 =?utf-8?B?V2F1UDVLR0RLSVVaUmVhNjdObHFhN2xNOXB4VnN5eHJpTGZTUytvMmdSUzcr?=
 =?utf-8?B?RGpmdEczSFVxb3ltT2w3dDdIUUJFUDhxa2F3VjJkdm1MaFJFSHY0RXB4RW5u?=
 =?utf-8?B?Z0dWblhydG1Eak1ERDVJZkJLMU1iVEFWbUxoUWxac1k2b1poT1BFbHhGOS9L?=
 =?utf-8?B?WVRuT3ZqVFkxbmpvT2t2bGlIVU5KSTF6bFNqYXF4QmlIK3lZNkJxaXgvMVBK?=
 =?utf-8?B?akYra2RlemwyTlJueDlWVVhjL1ZhS0hrOGNPWEhJUkxzMDgyK0lqcUJqdCtt?=
 =?utf-8?B?c0ZrdlNTRVZGc0ovYnJQa0tESncrNW8xNXhsRk94RjJaNUV1eU5QcVRWSlAv?=
 =?utf-8?B?d2pzNWJpa0pBblpGMmxzQUladFB0a1R1S2dBL0M3Y1RoTlRhRmtRK05peVlT?=
 =?utf-8?B?azQ5bkpmK2hXaGNyejU2VUFTQkR6TFFWWWhlTUtuZ2tLdG1jMWFPbFgrZmdy?=
 =?utf-8?B?YmE0WWg1T3hjKzM5RlA3VFUxQzVJUXRFZXJqSW4weUE2d0Mza0l4SkdzNG5y?=
 =?utf-8?B?RHlTNWRpTUJRbTRZcHUxUzFvRGs1Z2VkanhWeGdkejdjTDlKczF3ZWFRSkxO?=
 =?utf-8?B?c0wvTXIwNUNtY0ZRNFdoNGtFb1RpUW9WTnJic1I1eXVTbE1kaXlnY2RnVlY3?=
 =?utf-8?B?b1ZvMnJYdEhmMUpncnd5TFQwUld1dUVIVG5WYkg0dFZOMHdid0I1NjRaNlYw?=
 =?utf-8?B?SFI5alVDMUNBYUFEd0JrcklFUEtOVTZQK0xQYkhQMncrd1lrdDdVUXBadTcy?=
 =?utf-8?B?K3NjblBDaVowWEdoKzFwZ1pRcjA2YU1xQ2VUam8xdy95RXFTUzRQY2ZES0Vm?=
 =?utf-8?B?V3U5SmJJSDBESVpURHNUSkVkU3dkRmpQR2taMmM3RkVxR04xeStIQTh3YnEw?=
 =?utf-8?B?UDJBeGdlc09jWmRidjBUTzZNRS9sVjEyV0dQZW1KV2NWSlRMdGRMWGRBd3NC?=
 =?utf-8?B?Z2FYR01HQ2R2VWcyZVVqbWFDRVZDd0Y5dnJZWjJWR09LNlVJdjQzbGR5d3hD?=
 =?utf-8?B?V3JYZ2VZNlJYaXZKcDJQMGI3aDNFVFVOeW0vVGdlWGNEYVZ4Qk1EVlJKdGFy?=
 =?utf-8?B?eEF0cytSR21PSXBYNEUzTlJvZ00wREZ1a1Zhd01xRE9mRGF0YXBaRmR6ZFJ6?=
 =?utf-8?B?L2RiSUg0cmh1eGc5Nk5rNTlKb2JWUDlza0d4Q1puSE8rZEIzOVNtY2VCVTBF?=
 =?utf-8?B?elpoeEIyaDBzK2dMNndUVlJpQzVIOGpxTnU4WlFlK2tLY0lLV25NZnA2QTFY?=
 =?utf-8?B?RXp5NkJvandpZE5VWmtCa2dNMDFSVEhFRC9EZGhGbnFVb1Y5ZkpONW1iVWVE?=
 =?utf-8?B?Y2h0MEZLR2hZZlM4Q2VvUUczT2w1U3NPQVljNzJmQXpMa0MrdzFhd3BVWFJC?=
 =?utf-8?B?SCtjTytHUVJQRzJURzRxS004WGlqeWRuNVJPYUgvWmZEajJuaXNvNm9nRTVT?=
 =?utf-8?B?eTRGTlVRYnFRTjUrL0VsZFdtTkdZdWFSQ05EUTY3c2Y2S3B0WFdKclVMelJh?=
 =?utf-8?B?N1ZSbjBJelFLRXU2d2h4ZjRZekhhb09PNXJJM2IzZ3ZlVDJ0M3RIOXFNNEcw?=
 =?utf-8?B?OFg3eDhEVEdMMyt2cjZjaXAxb0RGd2tlQ2JrYU1nWnhsVE9Sc1pheFZ1Sjd6?=
 =?utf-8?B?Tm5EbkNaa3V1TTVaV2NzSCtYMkVVbGJ2RWJjVGZDK0dNdXhGbCt2ejgvQUtP?=
 =?utf-8?B?cHJheW12UTVhamVrMGNvUHBPcjV2YUQ1blZ5Ykc4empheFkwVFhPWVVoNGpk?=
 =?utf-8?B?R25uak1LMWU5OWNUaFhndjB4WE50NDRoQUlVdzJpUEhPUG1DY2thaVVZQTc0?=
 =?utf-8?B?RFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	lFPYVnX2z8NT3ktpGLhNXmSwiB17Ixr/Fv5ldD4p4ZA8QioPwL+vz5ZQ2VI2tP3VmPMp0MkdoTNSd5s/3FQg/D0QDHujItSN+ANRnXKsS7IcN19pXynbkKaVA+veNQZToLXq5pq0UiUazjdqB8IHD/7hKk8gje1neQYbThfXWfVcMsOspb8q+rZvU5pNPe71TvpYALsfWGrkWRyhMNStxbqueWYTt0GITt5Mn4mjBnW18FRo/dtIqznQtREqbhGeGDIQIcAHS8YJSj9QBriW200sXfMRLiP7FlWWvYMNO3rfZ0AqW6ayM3RLgRaWhKDIAljhRl06PPfT45FgQgRI05VF4aCNMAO2WKDYoPeJRVIrm/rzUVWX94I5wEdyx297B5y6SmXaPoYtQnts1MDX5UhUw6/8swtIBU6jawnYCQu7ExETlcIKI909ZS/5W/IS06rMvFjc68Y8VEZUsqtc/fVgdOgIUSa/qcqKabDbLCImDY/eXIqZAV6ARKbc8ICRFWCnQCi3/RblN5+B/yOQ9jwmjxdkA5k8vIPmj+QJlYHc9HcbD/RG6JBuZWVH6GxctKo7m/dm2JUwaAA+8ZP3ZY90smnRvSCGFJw9eYXdU/c=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c83410ba-5b69-4034-b6cc-08dc43990a39
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 20:06:16.2251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3NdqvUW3e2kY8w4TYH/seqlU7Op6NrcU9tJmDiERaaZMgf0iWpVJeRA0NXZXuqn28rrBcKDG3gl3bZi62yTgnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4759
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403130155
X-Proofpoint-GUID: P9II9HG4gaxu9PeTXeIAgfBj8znIjDu8
X-Proofpoint-ORIG-GUID: P9II9HG4gaxu9PeTXeIAgfBj8znIjDu8


On 3/12/24 21:24, Joel Fernandes (Google) wrote:
> This fixes a build error introduced by  "sched/rt: Remove default
> bandwidth control". The issue happens because a function is unused
> when !CONFIG_SMP. It could be squashed into the original patch.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>


Reviewed-by: Chris Hyser <chris.hyser@oracle.com>


> ---
>   kernel/sched/rt.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 37bee56a70f7..d3065fe35c61 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -964,8 +964,10 @@ struct rt_rq *sched_rt_period_rt_rq(struct rt_bandwidth *rt_b, int cpu)
>   	return &cpu_rq(cpu)->rt;
>   }
>   
> +#ifdef CONFIG_SMP
>   static void __enable_runtime(struct rq *rq) { }
>   static void __disable_runtime(struct rq *rq) { }
> +#endif
>   
>   #endif /* CONFIG_RT_GROUP_SCHED */
>