Received-SPF: pass (google.com: domain of linux-kernel+bounces-102495-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: <Ronnie.Kunin@microchip.com>
To: <andrew@lunn.ch>, <f.fainelli@gmail.com>
CC: <Raju.Lakkaraju@microchip.com>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
	<Bryan.Whitehead@microchip.com>, <richardcochran@gmail.com>,
	<UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net 3/3] net: lan743x: Address problems with wake option
 flags configuration sequences
Thread-Topic: [PATCH net 3/3] net: lan743x: Address problems with wake option
 flags configuration sequences
Thread-Index: AQHaaIt9/9VvJ3PDJ0OgsYtGoeCEQLErcdiAgAIgIYCAAJu7MIAGjQ6AgAAJaUCAACyOAIABPjUAgAAJNRA=
Date: Wed, 13 Mar 2024 20:34:10 +0000
Message-ID: <PH8PR11MB79651B5E3C949D95043AA446952A2@PH8PR11MB7965.namprd11.prod.outlook.com>
References: <20240226080934.46003-1-Raju.Lakkaraju@microchip.com>
 <20240226080934.46003-4-Raju.Lakkaraju@microchip.com>
 <78d7e538-9fa0-490e-bcfb-0a5943ad80c9@lunn.ch>
 <LV8PR11MB87008454A629EE15B9CE14099F272@LV8PR11MB8700.namprd11.prod.outlook.com>
 <PH8PR11MB79656DCF7806D7390C7100DE95272@PH8PR11MB7965.namprd11.prod.outlook.com>
 <fd22d022-cad4-489c-9861-36765dd98a87@lunn.ch>
 <PH8PR11MB79655416A331370D3496854A952A2@PH8PR11MB7965.namprd11.prod.outlook.com>
 <3e84e1c9-f680-47fa-aa59-615ce57b65da@gmail.com>
 <725e8182-50de-4469-9f87-fa58179f8922@lunn.ch>
In-Reply-To: <725e8182-50de-4469-9f87-fa58179f8922@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ihF/Z0g17FdZa1mHltnL3SdzW9AdfyaNK14E96rngB37zLOWjDgbRijmezGE?=
 =?us-ascii?Q?P4wm2M0LpeJWI2LW6wDIHJXIQIRNpw1vdPvylJ8b2JTDAD2XZAgIHRa3hZQH?=
 =?us-ascii?Q?EJPeVQhM4JHyIDfL0ddZezImLS74B+HQlkZkxUyP1sxyloeGj0Jj4Jp61sJ7?=
 =?us-ascii?Q?Tnu4FwbZcpyEv9E6UOp9IV6tchsDupmJEIZya6Idot+mdS0f4j0au+RAYAwf?=
 =?us-ascii?Q?TDhg8hSKeVJXAQwJtk+x5K7i1fqgbF65nZhgmfBl4ySeXKpsxR6AR8fhTe+s?=
 =?us-ascii?Q?hNNZT27URVHJqpTSaWEV9DJQdQgJyxj1+5V/m0vlZrYh9pW9+6PMHrD4w6wk?=
 =?us-ascii?Q?zGJz8aPy2zz1AjPevGs7XzEB61tH12Q3MsicBJsxdbYlFz0DK+mv7IevNfsR?=
 =?us-ascii?Q?5nvHZFHFV2kpN+ZWbowY+Un+e2L+l20AD3yIxcKjJCXLAxr+/R1K2vKUmVEp?=
 =?us-ascii?Q?TaYn1+DaSfKeGPYDUnFxltShXmMypimcUpOLWAWBa52LldvipYjqYiGzGdvn?=
 =?us-ascii?Q?21Ir4Gu4TpzU7gqRVm+//2MDnANKtPsGt7OWAsriZ+kdC/IEoD0+amJsikXf?=
 =?us-ascii?Q?nHotpZGHt8TFNPl0cRTVdsieBccOA/w5bJNhwTbGIat8OeGzDPgJzTgmHaNH?=
 =?us-ascii?Q?Nl4Fv/rJ+1ZdFQgHVmoXSSFt8MYa0LFii9EQvTTqcxvKl2PJqL2r1e3TXWE+?=
 =?us-ascii?Q?sFnxw0xAM71X+CUaHcsJgOS/hAEZuLP/1Ij9wrLxKx0DWvrUCGutcXxu8c7Y?=
 =?us-ascii?Q?eEtWkjMnz6S3dkzHrg8wJCMUSwsbdyU8dhgIBJzLuOdV2y8Wr2vMB8CakO77?=
 =?us-ascii?Q?w0L+vYArrKqy7D1HOEAye3b6RjwHMJRQi2IUf7U0KkwY4eDTC1rvNfxcAlgF?=
 =?us-ascii?Q?Q4TNFD0AxZDo2PMsSUbvjxSUDuIEdaQo6ftrOzz4sP2T48o7IbOmHUEGuc5B?=
 =?us-ascii?Q?/ZZjojX0qw0m2QiM7vVIOGv2Oi7Wzq9ddp236RBpWwBOjQOwGe/vsiH244WV?=
 =?us-ascii?Q?Qcq5tjKTqNCDD3cBWoM21FW7OvLaYnSB1mNFo2/x6YGG27M7wKuaoNyNKiix?=
 =?us-ascii?Q?3MQ5gfBITGCMhuSEPsvcU6Scd3XbvkPqh3/HdRaauLwz7dcthquWx1BROCXu?=
 =?us-ascii?Q?iiTN1Dz19G3n76RRb3nFAzkXQ6s4XZJs+tQ6/Wxv+vmPdpthM6q+pAQqfKy/?=
 =?us-ascii?Q?OrCm/099h24/8kHx0fLN3EqV4GchxGsSLqnzNS7MWUoEatotTKFO/724pK6r?=
 =?us-ascii?Q?nf0csEl5tJ9+UONS5lYR56N/+Y19oxX1MLjaDJtr3mDyVCHddxbPaqHswnwt?=
 =?us-ascii?Q?H2c/yxYWXh4/tnnlPXLFApJFLx0dZYICmSqh/7ayQKp2sv+WIWG+dOdLZD3F?=
 =?us-ascii?Q?wHTfm1+qgsPv9raF+WMDzBRkO66sUlzwRNaXq/5uzTgqD+qm4Yi6CCJBk/yB?=
 =?us-ascii?Q?NY6YBOBVIF1pGaaKZfK1IXXrI6jotYgLDulgJJzVUX5C7JxniWm30Hw1/khj?=
 =?us-ascii?Q?0O3zAl5oCc1XiG0Y9jaw7h8qQa0EyVn+vuWplQickE+PpdRqLSwZiYMlGZ6E?=
 =?us-ascii?Q?P6jhGRFyPTqomnwHAJI9vceC8DeXDc32ICzDcaXw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB7965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abc9293c-0b6d-40b7-03c4-08dc439cf00d
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 20:34:10.0955
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GHEts4ntc7H9ND2vQrKTrTlx9+KRinBW4RfnaD3E3kZJHTO2xJ7nkAfZUdQ9qQ7g1igQBJu4Rh8LJnAINjdxL0hve2ppRe0FKlQ1Z9YDA3E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6349


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, March 13, 2024 3:53 PM
> To: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ronnie Kunin - C21729 <Ronnie.Kunin@microchip.com>; Raju Lakkaraju - =
I30499
> <Raju.Lakkaraju@microchip.com>; netdev@vger.kernel.org; davem@davemloft.n=
et; kuba@kernel.org;
> linux-kernel@vger.kernel.org; Bryan Whitehead - C21958 <Bryan.Whitehead@m=
icrochip.com>;
> richardcochran@gmail.com; UNGLinuxDriver <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake opt=
ion flags configuration
> sequences
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e content is safe
>=20
> So i think we need to agree on best practices for new drivers and documen=
t what that is, probably in
> both the ethtool man page and include/uapi/linux/ethtool.h
>=20
> * WAKE_MAGIC on its own is O.K.
> * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL
> * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL.
> * Each driver needs to enforce this, due to backwards compatibility.
>   Some may decide not to.
>=20
> Can we agree on this?

Sounds good to me.
Raju (and other MCHP folks) are out this week due to a company shutdown, bu=
t he should be able to submit a new patch for lan743x as described above wh=
en back next week.

>=20
>     Andrew