Received-SPF: pass (google.com: domain of linux-kernel+bounces-102520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 13 Mar 2024 22:11:38 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, 
	Andrew Morton <akpm@linux-foundation.org>, Nicolas Schier <nicolas@fjasle.eu>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List <linux-next@vger.kernel.org>, 
	linux-kbuild@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the mm tree
Message-ID: <gegwogwbrigfaqjoymgndji6wmllqgkhs2mmgvpksqzsil64zr@pimmxvvvgbqz>
References: <20240313150728.12e20208@canb.auug.org.au>
 <psaj3nztnhcxiwjnie3bbpsn7efcsxp3yx3mh54uello22773v@fw5qpqs4gh2i>
 <CAK7LNASa-KedA_CTww6unckAGkJCQTctdbk0d-MUsN7wQpM=kQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="h3yhzmapyppypztu"
Content-Disposition: inline
In-Reply-To: <CAK7LNASa-KedA_CTww6unckAGkJCQTctdbk0d-MUsN7wQpM=kQ@mail.gmail.com>


--h3yhzmapyppypztu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Masahiro,

On Thu, Mar 14, 2024 at 12:22:46AM +0900, Masahiro Yamada wrote:
> On Wed, Mar 13, 2024 at 6:01=E2=80=AFPM Uwe Kleine-K=C3=B6nig
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > On Wed, Mar 13, 2024 at 03:07:28PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the mm tree, today's linux-next build (powerpc allyesco=
nfig)
> > > produced this warning:
> > >
> > > Use of uninitialized value $ENV{"abs_srctree"} in concatenation (.) o=
r string at /home/sfr/next/next/lib/build_OID_registry line 38.
> > >
> > > Introduced by commit
> > >
> > >   325f7b0aaea6 ("lib/build_OID_registry: Don't mention the full path =
of the script in output")
> > >
> > > from the mm-nonmm-unstable branch of the mm tree.
> >
> > Actually the warning doesn't happen on 325f7b0aaea6. The commit is only
> > problematic in combination with commit
> >
> >         e2bad142bb3d ("kbuild: unexport abs_srctree and abs_objtree")
> >
> > . This commit suggests to use $(abspath ) or $(realpath ) instead, but I
> > fail to apply this suggestion here.
> >
> > Obviously
> >
> > diff --git a/Makefile b/Makefile
> > index 5e09b53b4850..f73a73a125e0 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -39,7 +39,7 @@ __all:
> >  # prepare rule.
> >
> >  this-makefile :=3D $(lastword $(MAKEFILE_LIST))
> > -abs_srctree :=3D $(realpath $(dir $(this-makefile)))
> > +export abs_srctree :=3D $(realpath $(dir $(this-makefile)))
> >  abs_objtree :=3D $(CURDIR)
> >
> >  ifneq ($(sub_make_done),1)
> >
> > would help.
> >
> > Any ideas how to properly handle that? Would the export be ok?
>=20
> Oh well, you are making a lot of effort just for a C comment line.

I don't care much either. Given that now I know how to somewhat keep the
originally intended information, the effort between a fixed string and
a dynamically generated one isn't very relevant.
=20
> use Cwd qw(abs_path);
>=20
> my $abs_srctree =3D abs_path($ENV{'srctree'});

Ah, I missed that srctree is an exported variable. Thanks, will prepare
a v2. akpm already dropped my initial patch from his queue.

Thanks for your input.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig         =
   |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--h3yhzmapyppypztu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXyFooACgkQj4D7WH0S
/k6YbQf+NO7nuOlyfJUNH/EzC39lZjopqSOniArTPILTVBheThlnsa8fo+zR76W7
U84Mr3LmKdDQ8zyABuQHA6Ok7Q080/XrJnASkY5D9/gOXX6RbMzY0P5cOv67Xexm
UVGYJnasHwz0y9iNRuKnrWbmVaQPjQui+iB4IeLweckki8TenaSUctBeK8A9w7wv
LjjGC3Xz0MFbf70waskLDTFMGHRM3lZQ+ilSrsSlib2OoqYHPMyaL8anjr6m82mI
WKbwu+o027cB/2zkMY4Bc5pF+COeObjrA/ATmbXVRLduv/ATSF3z4w0A7eyLgyKL
w2N6oV32GTQS8cp0f6/3NliEIZQQNg==
=pHxQ
-----END PGP SIGNATURE-----

--h3yhzmapyppypztu--