Received-SPF: pass (google.com: domain of linux-kernel+bounces-102532-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d91a8363-df75-78a1-467e-878a04859ace@oracle.com>
Date: Wed, 13 Mar 2024 14:27:35 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] KVM: x86/mmu: x86: Don't overflow lpage_info when
 checking attributes
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "seanjc@google.com" <seanjc@google.com>,
        "hao.p.peng@linux.intel.com" <hao.p.peng@linux.intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20240312173334.2484335-1-rick.p.edgecombe@intel.com>
 <ccb21523-54b8-770a-bdac-c63f9c8080db@oracle.com>
 <60d6242e12030c744ff88322b84d0aa586e2d43d.camel@intel.com>
Content-Language: en-US
From: Dongli Zhang <dongli.zhang@oracle.com>
In-Reply-To: <60d6242e12030c744ff88322b84d0aa586e2d43d.camel@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?alpsUzZBemZtTDVtRkg3OEFGMUsyQjB0NmNoeFA3ZHdKdnQzYXVXMDFFUmQr?=
 =?utf-8?B?dW1HMlAyeTlOckNacnExRlZaL1RhN2pvS1U1U0kreDdJRmJVWGpZQ0FKSUJa?=
 =?utf-8?B?TGtIK2VqMkorZG1rRFFndE9qdCtXTnIrMitHeStIUldpWlpZWEFvVWMrNmtL?=
 =?utf-8?B?VWhuYUE4MXFuc3BCM3Z1WDNUS3J0akJOOFdVU0VjYVBxcC9WZ3poY29LcGQ5?=
 =?utf-8?B?ODBFdHBiQ29waHlUR3g3dG9zMG5mRDRZMjBOS1VMRVlIcTVzWjdJbEY0eFcv?=
 =?utf-8?B?Z1lzblJFcUl6WVpEQnZ2ZDNhWm9WT3o0bS9rRDM0S2RURk1GLzJBR1JYeXlm?=
 =?utf-8?B?cklzdDMxMXF4U2Z6RllnTWJsbndFOXFZMERPbmZsZk50ZVJhclJEOUVOTHFs?=
 =?utf-8?B?UkdxbmFiRmZGTHJpSkxSZzNvUUlwYVpmbmJoMUZHc2tIK05EYWxSUTRBcW5O?=
 =?utf-8?B?WFRsZEYxUE9KUWE5bC8rMXRWNnJOcFZWb3pxeGlBV1F1TkNqV3VOL0FHcVla?=
 =?utf-8?B?UTdKbDJ1VktjOW11VmxZZUk3aitNMXM0c0QzQ3N1TFNpYUtxMFp2dWc0ZjUx?=
 =?utf-8?B?MXhvM2JGRkZ2NzcyME1ZZjloWUZnZGlJaEo0REJhTXlGYnlLU1FRK2owclF1?=
 =?utf-8?B?cDE1T0tXd25wSXJqVW5NQ2V2bXpJK0ZCQzVTOGk0YlNRZFBockZabXYvcHRW?=
 =?utf-8?B?dkhLMWNRU2thbUVBN3JOTjAxTVBaRmRPOHpqSmpmaWdlZEd4RXNnYTd6UlZj?=
 =?utf-8?B?UGFSTXU1VUUxTGxOaE5RVnR4WUtNNkE4Zm5EY0pxS2JOeEpiL2doTU5QZlI1?=
 =?utf-8?B?SHc0UndkTUFYdk1xTWZVM1VJakZBcWltSm1xR2JBSVNGWmpBV0Noam5JOExo?=
 =?utf-8?B?a3FuSVc4dm10SW5zNjBDdzhZZjdXbkpYNTF4a1B2UjhqcDArWi80dUJDdFlN?=
 =?utf-8?B?V00zQ2VoblQ1TFlSQXRVcS9ScUVxRmFsOElKY3BlbXFtb1BubWpHM3RJWFRt?=
 =?utf-8?B?cnlZSC9hYnk3alR1RUdWbU54MkpRSlI3SlEwUmZiVitmZTJKcTJoR1B6NXZr?=
 =?utf-8?B?ZTdBaFFDUlBsL1VjSlM4T29uL1ZxQTdybXNzSFBYMWhwemxzY3Bob0w5YUVY?=
 =?utf-8?B?WUliY3lYcHA5emI3cllCZVBLNW1wcE1kbVV1YUNsWEJCNlRCT2xsUWpXWEFi?=
 =?utf-8?B?YkFuaDFrLzhtek0wSWJ4UW5ETUhIZ0JqWE9GOFhqWEVSbU1xVFpaMW9ISkRt?=
 =?utf-8?B?ellFc2FBQkNYRXZ3M21IZzNDQnVEbnFxeWozN2o0WnNXajk4NklZOWowSFlV?=
 =?utf-8?B?czRlSXlRT25rVGxEcnkrSmNXeXU4dEhUNW5SRVNLVlBGYm10RWRMeldubzIv?=
 =?utf-8?B?ZmtUTWJpaytDVEMzQmlZMkhSaDh5RVdZcWhyUFBpRjlOT245K2U0MzlCSUND?=
 =?utf-8?B?SlphKzJnMm1NQzljdlBUYmg1cXpETm9nOFdteXRPZzd4WG5pRWxkK2dJM0Ri?=
 =?utf-8?B?TTRyUGZ6c3BiWkE2NUlFUEhQZEtjTmxySWpPNEs1VmIrTG1BTXpPWFd3SkpG?=
 =?utf-8?B?NHNUc1l6SFVrTFF4VWozRmlFeHUwSU0rQk80Q0hHUVB6SE1lQ2tPWVFvUDFo?=
 =?utf-8?B?SjZtMStLYmZEVWVFWURNOXRjN0thRllmUXVGaytPWnVSd1FuaFFoU0xHVytO?=
 =?utf-8?B?Ull4QytzSDZHQklsN2xHcmUxemozZG1BVVdXeXQ4MjhPc2JocEJtaW5hOCtl?=
 =?utf-8?B?MXhDZWwyQ0d6UGdQQXRPcU11SXpzQnlSSmJOVEt2NkxCRGIvTHpJbDhteE9t?=
 =?utf-8?B?S2d4aFNoMFlTQWFUTUlob0pqZXRuZ1pqY1NGa0RMVDZtKzdkeVMySjVXeVpY?=
 =?utf-8?B?V1BMT1dwcFlobWdFekZEWGRFMzhBUVhETUk1YytjUHNrUE1xQmlLaUFXakE2?=
 =?utf-8?B?K2V1RExtdVdPZlByM3VEdXhtWlFPWXMxNjdnM2lFOTlxRWlpL254TENVbmhR?=
 =?utf-8?B?SjhtYU9IWGd4NTNvaGRwUlRJcDRVR1VFVm9hVDVDMUNudWdwbFQxK1pqTUtx?=
 =?utf-8?B?TUhyQ0VGQWJIVmxxVkFRS0NORmV3dnlsTnpTTVBuUVNNVXpxMklaSTNqSGkv?=
 =?utf-8?Q?akAVSP9EYtd++IZDV0hb/sRMP?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	GZTrARDp4BuQc6+udYj3UCt0kdslIqYAIxyjSYlnBt1WMoUIxLGc6aHQ2vPH0lH2IfeFPZsTBTeumTOgDzTV0cG7Y9w1XsuJqdiqsgY8Y5uHmqgUcu9nFly5anmVzrzNNrTOCmiWN4VmHLYlLpNkwo6yIb1nzn7mmeINdZzwD2A07wDiJFVzxnKTZn+tciA1hrhu/mXC+rC/JB38F3iOqgVdIE+ZF0QPGXv/N2kj1kMdCJ12cXWJSK2DZkWvG8O06xjMrzPLHu0riMBxnVkPc/o1XEC5/xOzNjDNVrSUSP2Lba7AvA0Qv1EqK0l5gmr0ES88oeJS5952QSLFrmEIxFNZG118lYPv9BLft6sx7JhPs2hodOtZgNwHK5Uv7KvzZYQyHxJ87VF/7Pde+TDCRyrX+gjBHZSyVU58rUzmrT9VV3m+LLPogIazNdjzTcFxAnvpSYwmrn1KzjD5ZJ6MQQa6HXwy4lDZD30LnN6oCbNZZCyp17WvX0dK7l+DZDz0EqHIj3KtKCfJBycv/N+kfYZylf+K7sMplZ/oC5465z0u7qm3d2DxJfcbbUNMlc5lo7DL/Gm0BCZY/0+BrTtkKyM6hjR0Lq5UeSE6TzvmSg8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1c64328-de2c-46dd-19d9-08dc43a4689f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 21:27:39.0673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tGgay8L9a2DnoyWBAmY+FDVdYj6+6mUAztY4nwW0doawdB99Rf1KRjaGImRrqThzQElckLzNe3+zL0YjtqIXPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4189
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403130164
X-Proofpoint-ORIG-GUID: gLurLdo2Nqkl_gpb9NvR4fl6lHHnFuUH
X-Proofpoint-GUID: gLurLdo2Nqkl_gpb9NvR4fl6lHHnFuUH


On 3/13/24 09:25, Edgecombe, Rick P wrote:
> On Wed, 2024-03-13 at 02:49 -0700, Dongli Zhang wrote:
>> The memslot id=10 has:
>> - base_gfn=1048576
>> - npages=1024
>>
>> Therefore, "level - 1  will not contain an entry for each GFN at page
>> size
>> level". If aligned, we expect lpage_info[0] to have 512 elements.
>>
>> 1GB: lpage_info[1] has 1 element
>> 2MB: lpage_info[0] has 2 elemtnts
> 
> 1048576 GFN is 2MB aligned, 1024 pages is also 2MB aligned. There are
> 512 4k pages in a 2MB huge page, so size of 2 for npages=1024 looks
> right to me. One struct for each potential 2MB huge page in the range.
> 
> I think overall you are saying in this response that you didn't find
> any problem in the analysis or fix. Is that correct?

I do not find any problem in the analysis or fix, except the same curiosity on
KVM_LPAGE_MIXED_FLAG.

Thank you very much!

Dongli Zhang