Received-SPF: pass (google.com: domain of linux-kernel+bounces-102581-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240313083828.5048-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <619c6117-d9b2-4520-9138-311327b17a8e@linaro.org>
In-Reply-To: <619c6117-d9b2-4520-9138-311327b17a8e@linaro.org>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Wed, 13 Mar 2024 22:08:32 +0000
Message-ID: <CA+V-a8vicbBrnu__w=KubF3VfRte_v23pUumFEd7O3buSjOyPg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow
 'input' and 'output-enable' properties
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>, Linus Walleij <linus.walleij@linaro.org>, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Magnus Damm <magnus.damm@gmail.com>, linux-renesas-soc@vger.kernel.org, 
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, 
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Krzysztof,

Thank you for the review.

On Wed, Mar 13, 2024 at 5:02=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 13/03/2024 09:38, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > On the RZ/G3S SMARC platform, the 'input' property is utilized in gpio-=
hog
> > nodes, and the 'output-enable' property is used for ETH0/1 TXC pins. Up=
date
> > the binding documentation to include these properties, addressing the
> > following dtbs_check warnings:
> >
> > arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: k=
ey-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
> >       'input' does not match any of the regexes: 'pinctrl-[0-9]+'
> >       True is not of type 'object'
> >       [[144, 1]] is not of type 'object'
> >       ['key-1-gpio-irq'] is not of type 'object'
> >       from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rz=
g2l-pinctrl.yaml#
> >
> > arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: e=
th0: 'anyOf' conditional failed, one must be fixed:
> >       'mux', 'tx_ctl', 'txc' do not match any of the regexes: 'pinctrl-=
[0-9]+'
> >       'output-enable' does not match any of the regexes: 'pinctrl-[0-9]=
+'
> >       from schema $id: http://devicetree.org/schemas/pinctrl/renesas,rz=
g2l-pinctrl.yaml#
> >
>
> In the future, please trim the error messages only to relevant parts, e.g=
.
>
> arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: pinctrl@11030000: key=
-1-gpio-hog: 'anyOf' conditional failed, one must be fixed:
>         'input' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Because all other four lines are really not helping.
>
Sure I will keep that in mind.

> Anyway, no need to resend just for that:
>
Thanks.

Cheers,
Prabhakar