Received: by 2002:ab2:5c0e:0:b0:1ef:a325:1205 with SMTP id i14csp32628lqk; Wed, 13 Mar 2024 15:29:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVNNoazWVUyan75GgK1G5lQW/EDMy/J7cmZIxYoxWGZoV4vThXysKgwhI/HeAN1Nmx2FekDj97jgvpmTpMzOtSm4+3JwW988ktrTszc9g== X-Google-Smtp-Source: AGHT+IFD9VLBB5UOgdYRYQl/AvgjycHVXqEJ+djK3B0qK3fGLfjV3YEPBYon89jW9pm7+duXFPhp X-Received: by 2002:a05:6808:f12:b0:3c2:aa94:3399 with SMTP id m18-20020a0568080f1200b003c2aa943399mr105868oiw.2.1710368990193; Wed, 13 Mar 2024 15:29:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710368990; cv=pass; d=google.com; s=arc-20160816; b=kHaQ+ZEnNY9xLHKAh4YeHedsVIr0e1n7NO+gWTkRMVhwxjGhSqF7xtx42NQzd+c+ps g5B70ZMDVXgGxBySGmF58Wt+ckE9D8RmF5EJedIlYDHCYmYzMWaPH1eRXFHpGqBIE81l lRRDZTuPCHVMRngCoH2jCgShI35hNmmqzfSWyChugW1z1qC4WtuOyPMTBDfOg/brisrW wEpd7v4gP8WZ+4dL4oKH6+okeLi60mQnwfkdS3UZ5kZXZrt+67qRxWcwp1PKvsB0ABb1 Xp6Z9CpZ65dVsohxF+UZq2V7TBfJse3VuWiZXW+iuGQHsbzJWf7LJZPxofAtNjol3reO pO/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=12CyAa4k38z6rcIwWOkPhdFUnWRFJxdmKxlTnpdxwmo=; fh=GBKHpdhsT+QSJ11b11Ogzdf2eUA1JxjetaCUhvaFKBQ=; b=Xvlz/VIPoJh65hScq8PrAOIYi/JF1eZ6Xx9zuj7wBqL9OFHLQWv7IyHCeLRAmGHoYt MIGmY+jboXHP6HZhGMq9Gbvtsf32vToPDI+oDoMfyqj25/NrqcV4M0x9YX02ZNz6IsMC KRV8o1VWDroKa+VcT/Aj3sBkcEhnINTuQvav4OuGuIIbORZ5EHL6suFhxs9+WLqui5fO jzKg5bhfV0HeM9Dhh0AaX2A9TrAJUWwu4pQEmeOapyO16i5qIZBhm+7xn9rNYRW2emoH UjSUfqAyU+9+NsshGAmFNUsVMUf7qcnx7/adpKB3sGcWSvKi7nlnwnNKQKlw9Q9DGiQM RY9g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h87fucOd; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-102594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102594-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f6-20020a05620a408600b00787e1927634si190119qko.502.2024.03.13.15.29.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 15:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-102594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h87fucOd; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-102594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102594-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D71701C2136B for ; Wed, 13 Mar 2024 22:29:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1475B59B66; Wed, 13 Mar 2024 22:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h87fucOd" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA7B5917B for ; Wed, 13 Mar 2024 22:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710368984; cv=none; b=MdW5WbuinHaEl1+C8TKBPO4qJGsHyOvwoK85va/rEFtVC1FvSom8eQGFMym6i0hHvmdR6hqaNmUlw5hMgo3yXAxPrx6ZLJH7Jk6ieyT217jQEidaEmLrbpFHdGQVZ5gh+Jc57jYp6D0892fyrhCUqV1Ft3ioz0PWcYaRR5RkSKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710368984; c=relaxed/simple; bh=jDn8w2lAj/HkiVf9cFQYrMkeMkPnT2d5AXwCaMiH39k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jg8YaBvRwQeQNYgVu8ZmMFgRCD15RRJjnrIxdV5MSnPny2kiIzDbUAb/dagjSsLLgGqXkRfbvBQLJkDlppCooCUBzpRY8fofyewu/C8tvmoj5kDEU7p1DCpNGBQvtcpSp7GevTQGATdL5CU2wd4egjfdd6jljm7AoH7CTlrY1qA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h87fucOd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710368981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=12CyAa4k38z6rcIwWOkPhdFUnWRFJxdmKxlTnpdxwmo=; b=h87fucOdT/+J4oYlDBmy1X5wN0dnF5xTithEtHeRk4Qj1uNeQHtkpvzi4WW16rpBh+9k44 Nj1x0k63nd4jQyG7Ngm/lLjstlhse49zbqc5ID9/vABPZF9N3D141H6yOfbvkHaKDzyZ2/ eTCENY/pAvP1fnAjqao9ncKhBLhMcYE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-QjF5xAJoNrOVnjaAdFAKJQ-1; Wed, 13 Mar 2024 18:29:38 -0400 X-MC-Unique: QjF5xAJoNrOVnjaAdFAKJQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-412db0e24aeso1633395e9.1 for ; Wed, 13 Mar 2024 15:29:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710368977; x=1710973777; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=12CyAa4k38z6rcIwWOkPhdFUnWRFJxdmKxlTnpdxwmo=; b=iQwChrfaHFBnuKOtUcQ8NVPVR/OTgjAmXUPZLiBCvcX2VcViqz464M0EV7EpQIFyrO AjzaaqRwdh7TNe5kJMRmMDgGf/vhagkTrMUsXM71u18ufgtsI2tnlqqUmWyVp6waY386 03vgFDbHJepE+PE8Kdh3tvIynsQcOD4kbMl+Ty86N8sQIErnJsrtc7V8b+qBo5oya00k W/Tyiwk9M3c+aRA2APGc+3jdiV4Udjg4Qtp9nDE6k1OlRQUrFTbJZv31ppbwr/MM2/BY kpwSR9/9gf8R7Gyz/d0u8gJSs3IkoHqqd+tJzhYntoE8Li6db3RKCUKHgLum1glRcZlo 5fJQ== X-Forwarded-Encrypted: i=1; AJvYcCWmLamzR3+NL0CQ5nQD6+qBXMgS8kquwiqMeBqjk463yuJLM0Nm34jJskg2dJzQgJSEh/ZU9ivQDN+cj3rVZ8oCdzyQ4twp/gPEZo26 X-Gm-Message-State: AOJu0YwT3+8pdV3U3gtBGU2iJ3bWOLZwVz56XTz4EPafu/HJTOz+W5DR Vxfap/eDkVFwbdiqX1SjDH/EPWBH5W1JgyFLAUMiaNAutiyANxGL1EskAEnMrj0lxiLXd6mU14d tK1yxGcOHBjaqsuP6fxBCtYxqd3zKI7XyuEBmiEwarX8rr9nsfTGiUaszsRCGvA== X-Received: by 2002:a05:600c:a0e:b0:413:304a:a31 with SMTP id z14-20020a05600c0a0e00b00413304a0a31mr96358wmp.24.1710368977089; Wed, 13 Mar 2024 15:29:37 -0700 (PDT) X-Received: by 2002:a05:600c:a0e:b0:413:304a:a31 with SMTP id z14-20020a05600c0a0e00b00413304a0a31mr96350wmp.24.1710368976752; Wed, 13 Mar 2024 15:29:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:2600:cd60:7701:f644:b131? (p200300cbc70e2600cd607701f644b131.dip0.t-ipconnect.de. [2003:cb:c70e:2600:cd60:7701:f644:b131]) by smtp.gmail.com with ESMTPSA id by1-20020a056000098100b0033d9f0dcb35sm146131wrb.87.2024.03.13.15.29.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 15:29:36 -0700 (PDT) Message-ID: <4a1f9359-8ecb-4962-92f5-a52cf2fd8564@redhat.com> Date: Wed, 13 Mar 2024 23:29:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory: Fix missing pte marker for !page on pte zaps Content-Language: en-US To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Muhammad Usama Anjum References: <20240313213107.235067-1-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.03.24 23:26, Peter Xu wrote: > On Wed, Mar 13, 2024 at 11:03:04PM +0100, David Hildenbrand wrote: >> On 13.03.24 22:31, peterx@redhat.com wrote: >>> From: Peter Xu >>> >>> Commit 0cf18e839f64 of large folio zap work broke uffd-wp. Now mm's uffd >>> unit test "wp-unpopulated" will trigger this WARN_ON_ONCE(). >> >> Good that I added the WARN_ON_ONCE() :) > > To be explict, VM_WARN_ON_ONCE. :) And that's my guess that you didn't hit > it when you posted the series and did the tests, as I know latest distros > like Fedora dropped DEBUG_VM, so maybe you had your base config out of > there (but I normally have it irrelevant of that). It's rather surprising that this went unnoticed for quite a while. I usually do run with DEBUG_VM, but I have a bunch of different VMs where I tests stuff, likely it was off when I ran the selftests. -- Cheers, David / dhildenb