Received-SPF: pass (google.com: domain of linux-kernel+bounces-102597-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <dca2d74b4078a0c2488cefd9beeaeb819a5c7fc9.camel@scylladb.com>
Subject: Re: [RFC PATCH 0/2] Introduce serialized smp_call_function APIs
From: Avi Kivity <avi@scylladb.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Peter Oskolkov
	 <posk@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, 
 "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>, Boqun Feng
 <boqun.feng@gmail.com>, Andrew Hunter <ahh@google.com>,  Maged Michael
 <maged.michael@gmail.com>, gromer@google.com, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>,  Paul Mackerras <paulus@samba.org>, Michael
 Ellerman <mpe@ellerman.id.au>, Linus Torvalds
 <torvalds@linux-foundation.org>
Date: Thu, 14 Mar 2024 00:23:27 +0200
In-Reply-To: <6952b581-68d2-476b-9f7e-e9746c8c0473@efficios.com>
References: <20240313205622.2179659-1-mathieu.desnoyers@efficios.com>
	 <7c1860d783e0f317160069bf77d8fafdf01a9f97.camel@scylladb.com>
	 <6952b581-68d2-476b-9f7e-e9746c8c0473@efficios.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-03-13 at 18:06 -0400, Mathieu Desnoyers wrote:
> On 2024-03-13 17:14, Avi Kivity wrote:
> > On Wed, 2024-03-13 at 16:56 -0400, Mathieu Desnoyers wrote:
> > > commit 944d5fe50f3f ("sched/membarrier: reduce the ability to
> > > hammer=20
> > > on sys_membarrier")
> > > introduces a mutex over all membarrier operations to reduce its
> > > ability
> > > to slow down the rest of the system.
> > >=20
> > > This RFC series has two objectives:
> > >=20
> > > 1) Move this mutex to the smp_call_function APIs so other system
> > > calls
> > > =C2=A0=C2=A0 using smp_call_function IPIs are limited in the same way=
,
> > >=20
> > > 2) Restore scalability of MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ
> > > with
> > > =C2=A0=C2=A0 MEMBARRIER_CMD_FLAG_CPU, which targets specific CPUs wit=
h
> > > IPIs.
> > > =C2=A0=C2=A0 This may or may not be useful, and I would welcome bench=
marks
> > > from
> > > =C2=A0=C2=A0 users of this feature to figure out if this is worth it.
> > >=20
> > > This series applies on top of v6.8.
> > >=20
> >=20
> >=20
> > I see this doesn't restore scaling of
> > MEMBARRIER_CMD_PRIVATE_EXPEDITED,=20
> > which I use (and wasn't aware was broken).
>=20
> It's mainly a mitigation for IPI Storming: CVE-2024-26602 disclosed


Very interesting.


> as part of [1].
>=20
> >=20
> > I don't have comments on the patches, but do have ideas on how to
> > work=20
> > around the problem in Seastar. So this was a useful heads-up for
> > me.
>=20
> Note that if you don't use membarrier private expedited too heavily,
> you should not notice any difference. But nevertheless I would be
> interested to hear about any regression on performance of real
> workloads resulting from commit 944d5fe50f3f.
>=20


In fact I did observe the original text of 944d5fe50f3f ("On some
systems, sys_membarrier can be very expensive, causing overall
slowdowns for everything") to be true [1]. So rather than causing
a regression, this commit made me fix a problem.

The smp_call_function_many_cond() in [1] is very likely due to
sys_membarrier, and it's slow since it's running on a virtual machine
without posted interrupt virtualization. Usually we detect virtual
machines and call membarrier() less frequently, but on that instance
(AWS d3en) the detection failed and triggered that IPI storm.

My fix is to just detect if there's a concurrent membarrier running and
fall back to doing something else, I don't think it's generally
applicable.

[1] https://github.com/scylladb/scylladb/issues/17207